#7 False positive if in method returned type from System.IO

inyutin-maxim · inyutin-maxim · commit 922010ccf355 · 2019-04-26T22:15:43.000+03:00
Now code fix applying from Invocation Expression or Object Creation Expression
diff --git a/System.IO.Abstractions.Analyzers.Tests/Analyzers/FileServiceInterfaceInjectionAnalyzerTests.cs b/System.IO.Abstractions.Analyzers.Tests/Analyzers/FileServiceInterfaceInjectionAnalyzerTests.cs
diff --git a/System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileServiceConstructorInitialCodeFixTests.cs b/System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileServiceConstructorInitialCodeFixTests.cs
@@ -1,5 +1,5 @@
 using System.Collections.Generic;
-using System.IO.Abstractions.Analyzers.Analyzers;
+using System.IO.Abstractions.Analyzers.Analyzers.FileSystemTypeAnalyzers;
 using System.IO.Abstractions.Analyzers.CodeFixes;
 using Microsoft.CodeAnalysis;
 using Roslyn.Testing.CodeFix;
@@ -8,7 +8,7 @@
 namespace System.IO.Abstractions.Analyzers.Tests.CodeFixes
 {
 	public class FileServiceConstructorInitialCodeFixTests :
-		CSharpCodeFixProviderTest<FileServiceInterfaceInjectionAnalyzer, FileServiceConstructorInitialCodeFix>
+		CSharpCodeFixProviderTest<PathAnalyzer, FileServiceConstructorInitialCodeFix>
 	{
 		[Theory]
 		[InlineData("BeforeFix.txt", "AfterFix.txt")]
diff --git a/System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileServiceInterfaceInjectionCodeFixTests.cs b/System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileServiceInterfaceInjectionCodeFixTests.cs
@@ -1,5 +1,5 @@
 using System.Collections.Generic;
-using System.IO.Abstractions.Analyzers.Analyzers;
+using System.IO.Abstractions.Analyzers.Analyzers.FileSystemTypeAnalyzers;
 using System.IO.Abstractions.Analyzers.CodeFixes;
 using Microsoft.CodeAnalysis;
 using Roslyn.Testing.CodeFix;
@@ -8,7 +8,7 @@
 namespace System.IO.Abstractions.Analyzers.Tests.CodeFixes
 {
 	public class FileServiceInterfaceInjectionCodeFixTests :
-		CSharpCodeFixProviderTest<FileServiceInterfaceInjectionAnalyzer, FileServiceInterfaceInjectionCodeFix>
+		CSharpCodeFixProviderTest<PathAnalyzer, FileServiceInterfaceInjectionCodeFix>
 	{
 		[Theory]
 		[InlineData("BeforeFix.txt", "AfterFix.txt")]
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/FileServiceInterfaceInjectionAnalyzer/Valid.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/FileServiceInterfaceInjectionAnalyzer/Valid.txt
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/FileServiceInterfaceInjectionAnalyzer/Valid2.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/FileServiceInterfaceInjectionAnalyzer/Valid2.txt
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/FileServiceInterfaceInjectionAnalyzer/WithOutFileSystem.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/FileServiceInterfaceInjectionAnalyzer/WithOutFileSystem.txt
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/AfterFix.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/AfterFix.txt
@@ -14,12 +14,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/AfterFixWithCustomField.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/AfterFixWithCustomField.txt
@@ -14,12 +14,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/BeforeFix.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/BeforeFix.txt
@@ -10,12 +10,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/BeforeFixWithCustomField.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceConstructorInitialCodeFix/BeforeFixWithCustomField.txt
@@ -12,12 +12,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/AfterFix.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/AfterFix.txt
@@ -14,12 +14,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/AfterFixConstructorParameterUniqName.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/AfterFixConstructorParameterUniqName.txt
@@ -14,12 +14,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/AfterFixContainsAssignment.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/AfterFixContainsAssignment.txt
@@ -14,12 +14,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFix.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFix.txt
@@ -10,12 +10,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixContainsAssignment.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixContainsAssignment.txt
@@ -11,12 +11,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixExistingConstructorParameter.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixExistingConstructorParameter.txt
@@ -10,12 +10,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixExistingConstructorParameterUniqName.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixExistingConstructorParameterUniqName.txt
@@ -12,12 +12,7 @@ namespace SomeNameSpace
 
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixExistsAbstractionsUsing.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixExistsAbstractionsUsing.txt
@@ -7,12 +7,7 @@ namespace SomeNameSpace
 	{
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixWithoutConstructor.txt b/System.IO.Abstractions.Analyzers.Tests/TestData/CodeFix/FileServiceInterfaceInjectionCodeFix/BeforeFixWithoutConstructor.txt
@@ -6,12 +6,7 @@ namespace SomeNameSpace
 	{
 		public void SomeMethod()
 		{
-			const string filePath = "C:\\temp.txt";
-
-			if (File.Exists(filePath))
-			{
-				File.Delete(filePath);
-			}
+			var newPath = Path.Combine("C:\\", "temp.txt");
 		}
 	}
 }
diff --git a/System.IO.Abstractions.Analyzers/Analyzers/FileServiceInterfaceInjectionAnalyzer.cs b/System.IO.Abstractions.Analyzers/Analyzers/FileServiceInterfaceInjectionAnalyzer.cs
diff --git a/System.IO.Abstractions.Analyzers/CodeFixes/FileServiceConstructorInitialCodeFix.cs b/System.IO.Abstractions.Analyzers/CodeFixes/FileServiceConstructorInitialCodeFix.cs
diff --git a/System.IO.Abstractions.Analyzers/CodeFixes/FileServiceInterfaceInjectionCodeFix.cs b/System.IO.Abstractions.Analyzers/CodeFixes/FileServiceInterfaceInjectionCodeFix.cs

Original file line number	Diff line number	Diff line change
`@@ -14,12 +14,7 @@ namespace SomeNameSpace`
`14`	`14`
`15`	`15`	`public void SomeMethod()`
`16`	`16`	`{`
`17`		`- const string filePath = "C:\\temp.txt";`
`18`		`-`
`19`		`- if (File.Exists(filePath))`
`20`		`- {`
`21`		`- File.Delete(filePath);`
`22`		`- }`
	`17`	`+ var newPath = Path.Combine("C:\\", "temp.txt");`
`23`	`18`	`}`
`24`	`19`	`}`
`25`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,12 +10,7 @@ namespace SomeNameSpace`
`10`	`10`
`11`	`11`	`public void SomeMethod()`
`12`	`12`	`{`
`13`		`- const string filePath = "C:\\temp.txt";`
`14`		`-`
`15`		`- if (File.Exists(filePath))`
`16`		`- {`
`17`		`- File.Delete(filePath);`
`18`		`- }`
	`13`	`+ var newPath = Path.Combine("C:\\", "temp.txt");`
`19`	`14`	`}`
`20`	`15`	`}`
`21`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,12 +12,7 @@ namespace SomeNameSpace`
`12`	`12`
`13`	`13`	`public void SomeMethod()`
`14`	`14`	`{`
`15`		`- const string filePath = "C:\\temp.txt";`
`16`		`-`
`17`		`- if (File.Exists(filePath))`
`18`		`- {`
`19`		`- File.Delete(filePath);`
`20`		`- }`
	`15`	`+ var newPath = Path.Combine("C:\\", "temp.txt");`
`21`	`16`	`}`
`22`	`17`	`}`
`23`	`18`	`}`