#8 IO0003 false positive if IDirectory is used

Author: inyutin-maxim

System.IO.Abstractions.Analyzers.Tests/Analyzers/DirectoryAnalyzerTests.cs

@@ -11,6 +11,7 @@ public class DirectoryAnalyzerTests: CSharpDiagnosticAnalyzerTest<DirectoryAnaly
 	{
 		[Theory]
 		[InlineData("Valid.txt")]
+		[InlineData("FalsePositive.txt")]
 		public void Analyzer_is_not_triggered(string filename)
 		{
 			var source = ReadFile(filename);

System.IO.Abstractions.Analyzers.Tests/TestData/Analyzer/DirectoryAnalyzer/FalsePositive.txt

@@ -0,0 +1,13 @@
+namespace Foobar
+{
+    using System.Collections.Generic;
+    using System.IO;
+    using System.IO.Abstractions;
+    using System.Linq;
+
+    internal static class DirectoryExtensions
+    {
+        public static IEnumerable<string> GetJpegs(this IDirectory directory, string path) => directory.EnumerateFiles(path, "*.jpeg", SearchOption.TopDirectoryOnly).Union(
+                directory.EnumerateFiles(path, "*.jpg", SearchOption.TopDirectoryOnly));
+    }
+}

System.IO.Abstractions.Analyzers/Analyzers/BaseFileSystemNodeAnalyzer.cs

@@ -57,7 +57,7 @@ private bool IsStaticInvocationStartWith(InvocationExpressionSyntax invocation)
 			return invocation.IsKind(SyntaxKind.InvocationExpression)
 					&& invocation.Expression.NormalizeWhitespace()
 						.ToFullString()
-						.StartsWith(GetFileSystemType().Name + ".", StringComparison.CurrentCultureIgnoreCase);
+						.StartsWith(GetFileSystemType().Name + ".", StringComparison.Ordinal);
 		}
 	}
 }

System.IO.Abstractions.Analyzers/CodeFixes/FileServiceInterfaceInjectionCodeFix.cs

@@ -35,7 +35,8 @@ public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context)
 			var constructor = RoslynClassFileSystem.GetConstructor(classDeclarationSyntax);
 
 			if (!RoslynClassFileSystem.HasFileSystemField(classDeclarationSyntax)
-				|| constructor != null && !RoslynClassFileSystem.ConstructorHasFileSystemParameter(constructor))
+				|| constructor != null && !RoslynClassFileSystem.ConstructorHasFileSystemParameter(constructor)
+				|| constructor != null && !RoslynClassFileSystem.ConstructorHasAssignmentExpression(constructor))
 			{
 				context.RegisterCodeFix(new FileServiceInterfaceInjectionCodeAction(Title,
 						context.Document,

System.IO.Abstractions.Analyzers/RoslynToken/RoslynClassFileSystem.cs

@@ -47,7 +47,7 @@ public static UsingDirectiveSyntax GetSystemIoUsing(CompilationUnitSyntax unit)
 		public static UsingDirectiveSyntax GetUsing(CompilationUnitSyntax unit, string usingName)
 		{
 			return unit.Usings.FirstOrDefault(x =>
-				x.Name.NormalizeWhitespace().ToFullString().Equals(usingName, StringComparison.CurrentCultureIgnoreCase));
+				x.Name.NormalizeWhitespace().ToFullString().Equals(usingName, StringComparison.Ordinal));
 		}
 
 		public static FieldDeclarationSyntax CreateFileSystemFieldDeclaration()