fix: always keep FileAttributes.Directory on directories (#970)

Fix #957:
Always keep `FileAttributes.Directory` on directories (and never on files).

Author: vbreuss

src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs

@@ -82,7 +82,7 @@ public override IFileSystemInfo ResolveLinkTarget(bool returnFinalTarget)
         public override FileAttributes Attributes
         {
             get { return GetMockFileDataForRead().Attributes; }
-            set { GetMockFileDataForWrite().Attributes = value; }
+            set { GetMockFileDataForWrite().Attributes = value | FileAttributes.Directory; }
         }
 
         /// <inheritdoc />

src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileInfo.cs

@@ -66,7 +66,7 @@ public override FileAttributes Attributes
             set
             {
                 var mockFileData = GetMockFileDataForWrite();
-                mockFileData.Attributes = value;
+                mockFileData.Attributes = value & ~FileAttributes.Directory;
             }
         }
 

tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs

@@ -66,6 +66,19 @@ public void MockDirectoryInfo_Attributes_ShouldReturnMinusOneForNonExistingFile(
             Assert.That(directoryInfo.Attributes, Is.EqualTo(expected));
         }
 
+        [Test]
+        public void MockDirectoryInfo_Attributes_Clear_ShouldRemainDirectory()
+        {
+            var fileSystem = new MockFileSystem();
+            var path = XFS.Path(@"c:\existing\directory");
+            fileSystem.Directory.CreateDirectory(path);
+            var directoryInfo = fileSystem.DirectoryInfo.New(path);
+            directoryInfo.Attributes = 0;
+
+            Assert.That(fileSystem.File.Exists(path), Is.False);
+            Assert.That(directoryInfo.Attributes, Is.EqualTo(FileAttributes.Directory));
+        }
+
         [Test]
         public void MockDirectoryInfo_Attributes_SetterShouldThrowDirectoryNotFoundExceptionOnNonExistingFileOrDirectory()
         {