More sanity checks, and always recompile metadata files after ffxiv patches.

Author: Lunaretic

xivModdingFramework/SqPack/FileTypes/Dat.cs

@@ -442,6 +442,12 @@ public async Task<byte[]> GetType2Data(string internalPath, bool forceOriginal)
         /// <returns>Byte array containing the decompressed type 2 data.</returns>
         public async Task<byte[]> GetType2Data(long offset, XivDataFile dataFile)
         {
+            if (offset <= 0)
+            {
+                throw new InvalidDataException("Cannot get file data without valid offset.");
+            }
+
+
             var type2Bytes = new List<byte>();
 
             // This formula is used to obtain the dat number in which the offset is located
@@ -770,6 +776,10 @@ public async Task<byte[]> CreateType2Data(byte[] dataToCreate)
         /// <returns>A tuple containing the mesh count, material count, and decompressed data</returns>
         public async Task<(int MeshCount, int MaterialCount, byte[] Data)> GetType3Data(long offset, XivDataFile dataFile)
         {
+            if (offset <= 0)
+            {
+                throw new InvalidDataException("Cannot get file data without valid offset.");
+            }
 
             // This formula is used to obtain the dat number in which the offset is located
             var datNum = (int) ((offset / 8) & 0x0F) / 2;
@@ -934,6 +944,11 @@ public async Task<XivTex> GetType4Data(string internalPath, bool forceOriginal)
 
         public async Task<int> GetCompressedFileSize(long offset, XivDataFile dataFile)
         {
+            if (offset <= 0)
+            {
+                throw new InvalidDataException("Cannot get file size data without valid offset.");
+            }
+
 
             var xivTex = new XivTex();
 
@@ -1079,6 +1094,11 @@ public async Task<int> GetCompressedFileSize(long offset, XivDataFile dataFile)
         /// <returns>An XivTex containing all the type 4 texture data</returns>
         public async Task<XivTex> GetType4Data(long offset, XivDataFile dataFile)
         {
+            if (offset <= 0)
+            {
+                throw new InvalidDataException("Cannot get file size data without valid offset.");
+            }
+
             var xivTex = new XivTex();
 
             var decompressedData = new List<byte>();

xivModdingFramework/Variants/FileTypes/Imc.cs

@@ -486,11 +486,17 @@ public async Task SaveFullImcInfo(FullImcInfo info, IItemModel item)
 
         public async Task SaveFullImcInfo(FullImcInfo info, string path, string itemName = null, string category = null, string source = null)
         {
+            if (info == null || info.TypeIdentifier != ImcType.Set && info.TypeIdentifier != ImcType.NonSet)
+            {
+                throw new InvalidDataException("Cannot save invalid IMC file.");
+            }
+
             var index = new Index(_gameDirectory);
             var dat = new Dat(_gameDirectory);
 
             var data = new List<byte>();
 
+
             // 4 Header bytes.
             data.AddRange(BitConverter.GetBytes((short) info.SubsetCount));
             data.AddRange(BitConverter.GetBytes((short) info.TypeIdentifier));
@@ -607,9 +613,9 @@ public class FullImcInfo
             /// Get the number of subsets.
             ///  -NOT- the same as number of material variants.
             /// </summary>
-            public int SubsetCount { get
+            public short SubsetCount { get
                 {
-                    return SubsetList.Count;
+                    return (short)SubsetList.Count;
                 }
                 set {
                     throw new NotSupportedException("Attempted to directly set SubsetCount.");