Fix colorset editor error on pre-7.2 game data

helpful-fox-senko-san · helpful-fox-senko-san · commit 33dbcfb69e22 · 2025-05-11T05:27:06.000Z
diff --git a/xivModdingFramework/Materials/FileTypes/STM.cs b/xivModdingFramework/Materials/FileTypes/STM.cs
@@ -249,7 +249,7 @@ public StainingTemplateEntry(byte[] data, int offset, EStainingTemplate template
                     // No data.
                     continue;
                 }
-                else
+                else if (arraySize < numDyes)
                 {
                     // Indexed array, where we have [n] # of real entries,
                     // then 254 one-byte index entries referencing those [n] entries.
@@ -402,7 +402,7 @@ public StainingTemplateFile(byte[] data, EStainingTemplate templateType)
                 offset += oldFormat ? 2 : 4;
             }
 
-            const int _headerEntrySize = 8;
+            int _headerEntrySize = oldFormat ? 4 : 8;
             var endOfHeader = (8 + (_headerEntrySize * entryCount));
 
             for (int i = 0; i < entryCount; i++)

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ public StainingTemplateEntry(byte[] data, int offset, EStainingTemplate template`
`249`	`249`	`// No data.`
`250`	`250`	`continue;`
`251`	`251`	`}`
`252`		`- else`
	`252`	`+ else if (arraySize < numDyes)`
`253`	`253`	`{`
`254`	`254`	`// Indexed array, where we have [n] # of real entries,`
`255`	`255`	`// then 254 one-byte index entries referencing those [n] entries.`
`@@ -402,7 +402,7 @@ public StainingTemplateFile(byte[] data, EStainingTemplate templateType)`
`402`	`402`	`offset += oldFormat ? 2 : 4;`
`403`	`403`	`}`
`404`	`404`
`405`		`- const int _headerEntrySize = 8;`
	`405`	`+ int _headerEntrySize = oldFormat ? 4 : 8;`
`406`	`406`	`var endOfHeader = (8 + (_headerEntrySize * entryCount));`
`407`	`407`
`408`	`408`	`for (int i = 0; i < entryCount; i++)`