Removed errors on attempting to delete files which did not exist. (Though the function still returns false in these cases)

Author: Lunaretic

xivModdingFramework/Mods/Modding.cs

@@ -471,11 +471,7 @@ where mod.fullPath.Equals(modItemPath)
             if (modToRemove.source == "FilesAddedByTexTools")
             {
                 var index = new Index(_gameDirectory);
-                var success = await index.DeleteFileDescriptor(modItemPath, XivDataFiles.GetXivDataFile(modToRemove.datFile));
-                if(!success)
-                {
-                    throw new Exception("Failed to delete file descriptor.");
-                }
+                await index.DeleteFileDescriptor(modItemPath, XivDataFiles.GetXivDataFile(modToRemove.datFile));
             }
             if (modToRemove.enabled)
             {
@@ -523,11 +519,7 @@ where modPack.name.Equals(modPackName)
                 if (modToRemove.source == "FilesAddedByTexTools")
                 {
                     var index = new Index(_gameDirectory);
-                    var success = await index.DeleteFileDescriptor(modToRemove.fullPath, XivDataFiles.GetXivDataFile(modToRemove.datFile));
-                    if (!success)
-                    {
-                        throw new Exception("Failed to delete file descriptor.");
-                    }
+                    await index.DeleteFileDescriptor(modToRemove.fullPath, XivDataFiles.GetXivDataFile(modToRemove.datFile));
                 }
                 if (modToRemove.enabled)
                 {

xivModdingFramework/SqPack/FileTypes/Index.cs

@@ -903,7 +903,7 @@ public async Task<bool> DeleteFileDescriptor(string fullPath, XivDataFile dataFi
                     }
                 }
 
-                // Cancel if we failed to find the file.
+                // If the file was already deleted, nothing to do here.
                 if (deleteLocation == 0)
                 {
                     _semaphoreSlim.Release();
@@ -976,9 +976,11 @@ public async Task<bool> DeleteFileDescriptor(string fullPath, XivDataFile dataFi
 
                 if (!foundFolder)
                 {
-                    // Something went wrong here / The index is in a bad state.
-                    _semaphoreSlim.Release();
-                    return false;
+                    // This is a pretty weird state to get here.
+                    // The file had to exist, but the folder it was in had to *not* exist.
+                    // This is tentatively a non-error, as we should really continue and purge the
+                    // Index2 Entry for the file as well, but it's definitely a weird/invalid index state 
+                    // that got us here.
                 }