Disable root cloner when Lumina mode is enabled. (Unstable/dangerous)

Lunaretic · Lunaretic · commit f3a0e60e6747 · 2021-03-13T21:54:04.000-05:00
diff --git a/xivModdingFramework/Mods/RootCloner.cs b/xivModdingFramework/Mods/RootCloner.cs
@@ -52,6 +52,15 @@ public static async Task<Dictionary<string, string>> CloneRoot(XivDependencyRoot
                 throw new InvalidDataException("Cannot clone unsupported root.");
             }
 
+            if(XivCache.GameInfo.UseLumina)
+            {
+                // Using the root cloner with Lumina import mode enabled is unstable/not safe.
+                // ( The state of the game files in the TT system may not match the state of the 
+                // Lumina mod setup, and the modlist/etc. can get bashed as this function directly
+                // modifies the modlist during the cloning process. )
+                throw new Exception("Item Conversion cannot be used with Lumina import mode.");
+            }
+
 
             if (ProgressReporter != null)
             {

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,15 @@ public static async Task<Dictionary<string, string>> CloneRoot(XivDependencyRoot`
`52`	`52`	`throw new InvalidDataException("Cannot clone unsupported root.");`
`53`	`53`	`}`
`54`	`54`
	`55`	`+ if(XivCache.GameInfo.UseLumina)`
	`56`	`+ {`
	`57`	`+ // Using the root cloner with Lumina import mode enabled is unstable/not safe.`
	`58`	`+ // ( The state of the game files in the TT system may not match the state of the`
	`59`	`+ // Lumina mod setup, and the modlist/etc. can get bashed as this function directly`
	`60`	`+ // modifies the modlist during the cloning process. )`
	`61`	`+ throw new Exception("Item Conversion cannot be used with Lumina import mode.");`
	`62`	`+ }`
	`63`	`+`
`55`	`64`
`56`	`65`	`if (ProgressReporter != null)`
`57`	`66`	`{`