Added emergency backup restore functionality for completely broken index files.

Author: Lunaretic

xivModdingFramework/Helpers/ProblemChecker.cs

@@ -138,6 +138,12 @@ public Task RepairIndexDatCounts(XivDataFile dataFile)
             });
         }
 
+        /// <summary>
+        /// This function returns TRUE if the backups should be used, and FALSE if they should not.
+        /// </summary>
+        /// <param name="dataFile"></param>
+        /// <param name="backupsDirectory"></param>
+        /// <returns></returns>
         public Task<bool> CheckForOutdatedBackups(XivDataFile dataFile, DirectoryInfo backupsDirectory)
         {
             return Task.Run(() =>
@@ -149,10 +155,32 @@ public Task<bool> CheckForOutdatedBackups(XivDataFile dataFile, DirectoryInfo ba
 
                 // Since the material addition directly adds to section 1 we can no longer check for outdated using that section header
                 // so instead compare the hashes of sections 2 and 3
-                var backupHashSection2 =  _index.GetIndexSection2Hash(backupDataFile);
-                var currentHashSection2 = _index.GetIndexSection2Hash(currentDataFile);
-                var backupHashSection3 = _index.GetIndexSection3Hash(backupDataFile);
-                var currentHashSection3 = _index.GetIndexSection3Hash(currentDataFile);
+                byte[] currentHashSection2;
+                byte[] currentHashSection3;
+                byte[] backupHashSection2;
+                byte[] backupHashSection3;
+                try
+                {
+                    currentHashSection2 = _index.GetIndexSection2Hash(currentDataFile);
+                    currentHashSection3 = _index.GetIndexSection3Hash(currentDataFile);
+                }
+                catch
+                {
+                    // Base files are fucked, use *any* backups.
+                    return true;
+                }
+
+                try
+                {
+                    backupHashSection2 = _index.GetIndexSection2Hash(backupDataFile);
+                    backupHashSection3 = _index.GetIndexSection3Hash(backupDataFile);
+                }
+                catch
+                {
+                    // Backups are fucked, can't use those.
+                    return false;
+                }
+
 
                 return backupHashSection2.SequenceEqual(currentHashSection2) && backupHashSection3.SequenceEqual(currentHashSection3);
             });
@@ -288,11 +316,18 @@ public Task<bool> RestoreBackups(DirectoryInfo backupsDirectory)
 
                     if (!File.Exists(backupFile.FullName)) continue;
 
-                    var outdatedCheck = await CheckForOutdatedBackups(xivDataFile, backupsDirectory);
-
-                    if (!outdatedCheck)
+                    try
                     {
-                        outdated = true;
+                        var outdatedCheck = await CheckForOutdatedBackups(xivDataFile, backupsDirectory);
+
+                        if (!outdatedCheck)
+                        {
+                            outdated = true;
+                        }
+                    }
+                    catch { 
+                        // If the outdated check errored out, we likely have completely broken internal dat files.
+                        // ( Either deleted or 0 byte files ), so replacing them with *anything* is an improvement.
                     }
                 }
 

xivModdingFramework/SqPack/FileTypes/Index.cs

@@ -83,21 +83,26 @@ public void UpdateIndexDatCount(XivDataFile dataFile, int datNum)
                 Path.Combine(_gameDirectory.FullName, $"{dataFile.GetDataFileName()}{Index2Extension}")
             };
 
-            for (var i = 0; i < indexPaths.Length; i++)
+            _semaphoreSlim.Wait();
+            try
             {
-                _semaphoreSlim.Wait();
-                using (var br = new BinaryReader(File.OpenRead(indexPaths[i])))
+                for (var i = 0; i < indexPaths.Length; i++)
                 {
-                    br.BaseStream.Seek(1104, SeekOrigin.Begin);
-                    if (i == 0)
-                    {
-                        index1 = br.ReadByte();
-                    }
-                    else
+                    using (var br = new BinaryReader(File.OpenRead(indexPaths[i])))
                     {
-                        index2 = br.ReadByte();
+                        br.BaseStream.Seek(1104, SeekOrigin.Begin);
+                        if (i == 0)
+                        {
+                            index1 = br.ReadByte();
+                        }
+                        else
+                        {
+                            index2 = br.ReadByte();
+                        }
                     }
                 }
+            } finally
+            {
                 _semaphoreSlim.Release();
             }
 
@@ -114,12 +119,18 @@ public byte[] GetIndexSection1Hash(DirectoryInfo indexPath)
             byte[] sha1Bytes;
 
             _semaphoreSlim.Wait();
-            using (var br = new BinaryReader(File.OpenRead(indexPath.FullName)))
+            try
             {
-                br.BaseStream.Seek(1040, SeekOrigin.Begin);
-                sha1Bytes = br.ReadBytes(20);
+                using (var br = new BinaryReader(File.OpenRead(indexPath.FullName)))
+                {
+                    br.BaseStream.Seek(1040, SeekOrigin.Begin);
+                    sha1Bytes = br.ReadBytes(20);
+                }
+            }
+            finally
+            {
+                _semaphoreSlim.Release();
             }
-            _semaphoreSlim.Release();
 
             return sha1Bytes;
         }
@@ -134,12 +145,18 @@ public byte[] GetIndexSection2Hash(DirectoryInfo indexPath)
             byte[] sha1Bytes;
 
             _semaphoreSlim.Wait();
-            using (var br = new BinaryReader(File.OpenRead(indexPath.FullName)))
+            try
             {
-                br.BaseStream.Seek(1116, SeekOrigin.Begin);
-                sha1Bytes = br.ReadBytes(20);
+                using (var br = new BinaryReader(File.OpenRead(indexPath.FullName)))
+                {
+                    br.BaseStream.Seek(1116, SeekOrigin.Begin);
+                    sha1Bytes = br.ReadBytes(20);
+                }
+            }
+            finally
+            {
+                _semaphoreSlim.Release();
             }
-            _semaphoreSlim.Release();
 
             return sha1Bytes;
         }
@@ -154,12 +171,18 @@ public byte[] GetIndexSection3Hash(DirectoryInfo indexPath)
             byte[] sha1Bytes;
 
             _semaphoreSlim.Wait();
-            using (var br = new BinaryReader(File.OpenRead(indexPath.FullName)))
+            try
             {
-                br.BaseStream.Seek(1188, SeekOrigin.Begin);
-                sha1Bytes = br.ReadBytes(20);
+                using (var br = new BinaryReader(File.OpenRead(indexPath.FullName)))
+                {
+                    br.BaseStream.Seek(1188, SeekOrigin.Begin);
+                    sha1Bytes = br.ReadBytes(20);
+                }
+            }
+            finally
+            {
+                _semaphoreSlim.Release();
             }
-            _semaphoreSlim.Release();
 
 
             return sha1Bytes;