feat: replace magic numbers with enums throughout codebase

- Replaced all magic numbers with proper enum values from types/trading.py
- OrderSide enum: BUY=0, SELL=1
- OrderType enum: LIMIT=1, MARKET=2, STOP=4, etc.
- OrderStatus enum: OPEN=1, FILLED=2, CANCELLED=3, etc.
- PositionType enum: LONG=1, SHORT=2
- TradeLogType enum: BUY=0, SELL=1

- Fixed test failures from previous refactoring:
  - Updated retry count expectations in HTTP client tests
  - Added exception conversion for connection errors
  - Fixed standardized error message expectations
  - Updated order cancellation/modification tests to expect exceptions
  - Fixed missing runtime imports of PositionType enum
  - Corrected enum value expectations in type tests

- Updated CHANGELOG.md for version 2.0.6
- All 299 tests now pass successfully

This improves code readability, type safety, and prevents invalid numeric values.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: TexasCoding

CHANGELOG.md

@@ -13,6 +13,31 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Old implementations are removed when improved
 - Clean, modern code architecture is prioritized
 
+## [2.0.6] - 2025-08-03
+
+### Changed
+- **🔢 Enum Usage**: Replaced magic numbers with proper enum values throughout codebase
+  - All order side values now use `OrderSide` enum (BUY=0, SELL=1)
+  - All order type values now use `OrderType` enum (LIMIT=1, MARKET=2, STOP=4, etc.)
+  - All order status values now use `OrderStatus` enum (OPEN=1, FILLED=2, CANCELLED=3, etc.)
+  - All position type values now use `PositionType` enum (LONG=1, SHORT=2)
+  - Trade log types now use `TradeLogType` enum (BUY=0, SELL=1)
+  - Improved code readability and maintainability
+  - All enum values match ProjectX Gateway documentation
+
+### Fixed
+- **🧪 Test Suite**: Fixed all test failures from recent refactoring
+  - HTTP client retry logic tests now expect correct retry counts
+  - Connection/timeout errors properly converted to `ProjectXConnectionError`
+  - Order cancellation and modification tests updated to expect exceptions
+  - Market data tests updated for standardized error messages
+  - Type tests updated with correct enum values
+
+### Improved
+- **📖 Code Documentation**: Updated inline documentation to reference enums
+- **🔍 Type Safety**: Better type checking with enum usage
+- **🐛 Bug Prevention**: Enum usage prevents invalid numeric values
+
 ## [2.0.5] - 2025-08-03
 
 ### Added

docs/conf.py

@@ -23,8 +23,8 @@
 project = "project-x-py"
 copyright = "2025, Jeff West"
 author = "Jeff West"
-release = "2.0.5"
-version = "2.0.5"
+release = "2.0.6"
+version = "2.0.6"
 
 # -- General configuration ---------------------------------------------------
 

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "project-x-py"
-version = "2.0.5"
+version = "2.0.6"
 description = "High-performance Python SDK for futures trading with real-time WebSocket data, technical indicators, order management, and market depth analysis"
 readme = "README.md"
 license = { text = "MIT" }

src/project_x_py/__init__.py

@@ -97,7 +97,7 @@
 
 from project_x_py.client.base import ProjectXBase
 
-__version__ = "2.0.5"
+__version__ = "2.0.6"
 __author__ = "TexasCoding"
 
 # Core client classes - renamed from Async* to standard names

src/project_x_py/client/auth.py

@@ -139,7 +139,7 @@ async def authenticate(self: "ProjectXClientProtocol") -> None:
             >>>     print(f"Authenticated as {client.account_info.username}")
             >>>     print(f"Using account: {client.account_info.name}")
         """
-        logger.info(LogMessages.AUTH_START, extra={"username": self.username})
+        logger.debug(LogMessages.AUTH_START, extra={"username": self.username})
 
         # Authenticate and get token
         auth_data = {
@@ -210,7 +210,7 @@ async def authenticate(self: "ProjectXClientProtocol") -> None:
 
         self.account_info = selected_account
         self._authenticated = True
-        logger.info(
+        logger.debug(
             LogMessages.AUTH_SUCCESS,
             extra={
                 "account_name": selected_account.name,

src/project_x_py/client/http.py

@@ -47,6 +47,7 @@ async def main():
 
 from project_x_py.exceptions import (
     ProjectXAuthenticationError,
+    ProjectXConnectionError,
     ProjectXDataError,
     ProjectXError,
     ProjectXRateLimitError,
@@ -178,7 +179,7 @@ async def _make_request(
             has_data=data is not None,
             has_params=params is not None,
         ):
-            logger.info(
+            logger.debug(
                 LogMessages.API_REQUEST, extra={"method": method, "endpoint": endpoint}
             )
 
@@ -197,13 +198,16 @@ async def _make_request(
             self.api_call_count += 1
             start_time = time.time()
 
-            response = await client.request(
-                method=method,
-                url=url,
-                json=data,
-                params=params,
-                headers=request_headers,
-            )
+            try:
+                response = await client.request(
+                    method=method,
+                    url=url,
+                    json=data,
+                    params=params,
+                    headers=request_headers,
+                )
+            except (httpx.ConnectError, httpx.TimeoutException) as e:
+                raise ProjectXConnectionError(str(e)) from e
 
             # Log API call
             log_api_call(

src/project_x_py/indicators/__init__.py

@@ -190,7 +190,7 @@
 )
 
 # Version info
-__version__ = "2.0.5"
+__version__ = "2.0.6"
 __author__ = "TexasCoding"
 
 

src/project_x_py/models.py

@@ -53,9 +53,9 @@
         contractId="CON.F.US.MGC.M25",
         creationTimestamp="2024-01-01T10:00:00Z",
         updateTimestamp="2024-01-01T10:00:05Z",
-        status=1,  # Open
-        type=1,  # Limit
-        side=0,  # Bid
+        status=OrderStatus.OPEN,
+        type=OrderType.LIMIT,
+        side=OrderSide.BUY,
         size=5,
         limitPrice=2050.0,
     )
@@ -66,7 +66,7 @@
         accountId=1001,
         contractId="CON.F.US.MGC.M25",
         creationTimestamp="2024-01-01T10:00:00Z",
-        type=1,  # Long
+        type=PositionType.LONG,
         size=5,
         averagePrice=2050.0,
     )
@@ -265,7 +265,8 @@ class Position:
         accountId (int): Account holding the position
         contractId (str): Contract of the position
         creationTimestamp (str): When the position was opened (ISO format)
-        type (int): Position type code (1=LONG, 2=SHORT)
+        type (int): Position type code (PositionType enum):
+            0=UNDEFINED, 1=LONG, 2=SHORT
         size (int): Position size (number of contracts, always positive)
         averagePrice (float): Average entry price of the position
 
@@ -274,7 +275,7 @@ class Position:
         For P&L calculations, use PositionManager.calculate_position_pnl() method.
 
     Example:
-        >>> direction = "LONG" if position.type == 1 else "SHORT"
+        >>> direction = "LONG" if position.type == PositionType.LONG else "SHORT"
         >>> print(
         ...     f"{direction} {position.size} {position.contractId} @ ${position.averagePrice}"
         ... )

src/project_x_py/order_manager/core.py

@@ -41,6 +41,7 @@
 from project_x_py.exceptions import ProjectXOrderError
 from project_x_py.models import Order, OrderPlaceResponse
 from project_x_py.types import OrderStats
+from project_x_py.types.trading import OrderStatus
 from project_x_py.utils import (
     ErrorMessages,
     LogContext,
@@ -441,14 +442,14 @@ async def is_order_filled(self, order_id: str | int) -> bool:
                 async with self.order_lock:
                     status = self.order_status_cache.get(order_id_str)
                     if status is not None:
-                        return status == 2  # 2 = Filled
+                        return status == OrderStatus.FILLED
 
                 if attempt < 2:  # Don't sleep on last attempt
                     await asyncio.sleep(0.2)  # Brief wait for real-time update
 
         # Fallback to API check
         order = await self.get_order_by_id(int(order_id))
-        return order is not None and order.status == 2  # 2 = Filled
+        return order is not None and order.status == OrderStatus.FILLED
 
     async def get_order_by_id(self, order_id: int) -> Order | None:
         """
@@ -520,8 +521,8 @@ async def cancel_order(self, order_id: int, account_id: int | None = None) -> bo
             if success:
                 # Update cache
                 if str(order_id) in self.tracked_orders:
-                    self.tracked_orders[str(order_id)]["status"] = 3  # Cancelled
-                    self.order_status_cache[str(order_id)] = 3
+                    self.tracked_orders[str(order_id)]["status"] = OrderStatus.CANCELLED
+                    self.order_status_cache[str(order_id)] = OrderStatus.CANCELLED
 
                 self.stats["orders_cancelled"] = (
                     self.stats.get("orders_cancelled", 0) + 1

src/project_x_py/order_manager/order_types.py

@@ -45,6 +45,7 @@
 from typing import TYPE_CHECKING
 
 from project_x_py.models import OrderPlaceResponse
+from project_x_py.types.trading import OrderType
 
 if TYPE_CHECKING:
     from project_x_py.types import OrderManagerProtocol
@@ -88,7 +89,7 @@ async def place_market_order(
             contract_id=contract_id,
             side=side,
             size=size,
-            order_type=2,  # Market
+            order_type=OrderType.MARKET,
             account_id=account_id,
         )
 
@@ -120,7 +121,7 @@ async def place_limit_order(
             contract_id=contract_id,
             side=side,
             size=size,
-            order_type=1,  # Limit
+            order_type=OrderType.LIMIT,
             limit_price=limit_price,
             account_id=account_id,
         )
@@ -154,7 +155,7 @@ async def place_stop_order(
             contract_id=contract_id,
             side=side,
             size=size,
-            order_type=4,  # Stop
+            order_type=OrderType.STOP,
             stop_price=stop_price,
             account_id=account_id,
         )
@@ -187,7 +188,7 @@ async def place_trailing_stop_order(
         """
         return await self.place_order(
             contract_id=contract_id,
-            order_type=5,  # Trailing stop order
+            order_type=OrderType.TRAILING_STOP,
             side=side,
             size=size,
             trail_price=trail_price,