Phase 8: Fix type checking and linting errors

- Fixed type checking errors in position_manager operations and core modules
- Updated ProjectXBase references to use ProjectXClientProtocol for better type safety
- Added proper isinstance checks before calling .get() on API responses
- Fixed import sorting issues flagged by ruff
- All mypy type checks now pass successfully

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: TexasCoding

src/project_x_py/position_manager/core.py

@@ -74,7 +74,6 @@ async def main():
 from datetime import datetime
 from typing import TYPE_CHECKING, Any, Optional
 
-from project_x_py.client.base import ProjectXBase
 from project_x_py.models import Position
 from project_x_py.position_manager.analytics import PositionAnalyticsMixin
 from project_x_py.position_manager.monitoring import PositionMonitoringMixin
@@ -83,7 +82,10 @@ async def main():
 from project_x_py.position_manager.tracking import PositionTrackingMixin
 from project_x_py.risk_manager import RiskManager
 from project_x_py.types.config_types import PositionManagerConfig
-from project_x_py.types.protocols import RealtimeDataManagerProtocol
+from project_x_py.types.protocols import (
+    ProjectXClientProtocol,
+    RealtimeDataManagerProtocol,
+)
 from project_x_py.types.response_types import (
     PositionSizingResponse,
     RiskAnalysisResponse,
@@ -96,7 +98,6 @@ async def main():
 from project_x_py.utils.stats_tracking import StatsTrackingMixin
 
 if TYPE_CHECKING:
-    from project_x_py.client import ProjectXBase
     from project_x_py.order_manager import OrderManager
     from project_x_py.realtime import ProjectXRealtimeClient
 
@@ -175,7 +176,7 @@ class PositionManager(
 
     def __init__(
         self,
-        project_x_client: "ProjectXBase",
+        project_x_client: "ProjectXClientProtocol",
         event_bus: Any,
         risk_manager: Optional["RiskManager"] = None,
         data_manager: Optional["RealtimeDataManagerProtocol"] = None,
@@ -227,7 +228,7 @@ def __init__(
         PositionMonitoringMixin.__init__(self)
         StatsTrackingMixin._init_stats_tracking(self)
 
-        self.project_x = project_x_client
+        self.project_x: ProjectXClientProtocol = project_x_client
         self.event_bus = event_bus  # Store the event bus for emitting events
         self.risk_manager = risk_manager
         self.data_manager = data_manager

src/project_x_py/position_manager/monitoring.py

@@ -60,6 +60,8 @@ async def on_alert(event):
 if TYPE_CHECKING:
     from asyncio import Lock
 
+    from project_x_py.types.protocols import ProjectXClientProtocol
+
 logger = logging.getLogger(__name__)
 
 
@@ -75,7 +77,7 @@ class PositionMonitoringMixin:
         logger: logging.Logger
         stats: dict[str, Any]
         _realtime_enabled: bool
-        project_x: "ProjectXBase"
+        project_x: "ProjectXClientProtocol"
         data_manager: "RealtimeDataManagerProtocol | None"
 
         # Methods from other mixins/main class

src/project_x_py/position_manager/operations.py

@@ -149,15 +149,17 @@ async def close_position_direct(
         ):
             response = await self.project_x._make_request("POST", url, data=payload)
 
-            if response:
+            if response and isinstance(response, dict):
                 success = response.get("success", False)
 
                 if success:
                     logger.info(
                         LogMessages.POSITION_CLOSED,
                         extra={
                             "contract_id": contract_id,
-                            "order_id": response.get("orderId"),
+                            "order_id": response.get("orderId")
+                            if isinstance(response, dict)
+                            else None,
                         },
                     )
                     # Remove from tracked positions if present
@@ -175,7 +177,11 @@ async def close_position_direct(
 
                     self.stats["closed_positions"] += 1
                 else:
-                    error_msg = response.get("errorMessage", "Unknown error")
+                    error_msg = (
+                        response.get("errorMessage", "Unknown error")
+                        if isinstance(response, dict)
+                        else "Unknown error"
+                    )
                     logger.error(
                         LogMessages.POSITION_ERROR,
                         extra={"operation": "close_position", "error": error_msg},
@@ -280,7 +286,7 @@ async def partially_close_position(
 
             response = await self.project_x._make_request("POST", url, data=payload)
 
-            if response:
+            if response and isinstance(response, dict):
                 success = response.get("success", False)
 
                 if success:
@@ -290,7 +296,9 @@ async def partially_close_position(
                             "contract_id": contract_id,
                             "partial": True,
                             "size": close_size,
-                            "order_id": response.get("orderId"),
+                            "order_id": response.get("orderId")
+                            if isinstance(response, dict)
+                            else None,
                         },
                     )
                     # Trigger position refresh to get updated sizes
@@ -301,7 +309,11 @@ async def partially_close_position(
 
                     self.stats["positions_partially_closed"] += 1
                 else:
-                    error_msg = response.get("errorMessage", "Unknown error")
+                    error_msg = (
+                        response.get("errorMessage", "Unknown error")
+                        if isinstance(response, dict)
+                        else "Unknown error"
+                    )
                     logger.error(
                         LogMessages.POSITION_ERROR,
                         extra={"operation": "partial_close", "error": error_msg},

src/project_x_py/types/protocols.py

@@ -354,7 +354,7 @@ async def close_position(
 class PositionManagerProtocol(Protocol):
     """Protocol defining the interface that mixins expect from PositionManager."""
 
-    project_x: "ProjectXBase"
+    project_x: "ProjectXClientProtocol"
     logger: Any
     event_bus: Any  # EventBus instance
     position_lock: asyncio.Lock