fix: resolve all mypy type errors in protocols and async method signatures

Author: TexasCoding

CLAUDE.md

@@ -2,6 +2,15 @@
 
 This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
 
+## Memory Check Protocol:
+
+Before responding to any request, I must:
+
+1. Search memory for user preferences related to the current topic/request
+2. Apply saved preferences without asking again
+3. Only save NEW preferences, corrections, or special treatments - not tasks or general info
+4. Check for topic-specific preferences (e.g., favorite subjects, style preferences, format preferences)
+
 ## CRITICAL: Testing and Running Examples
 
 **ALWAYS use `./test.sh` to run tests and examples.** The environment variables are not set globally, but test.sh handles this automatically.
@@ -980,167 +989,3 @@ async with ProjectX.from_env() as client:
 - **Fixed**: Eliminated all statistics-related deadlocks with single RW lock per component
 - **Changed**: All statistics methods now require `await` for consistency and performance
 - **Removed**: Legacy statistics mixins (EnhancedStatsTrackingMixin, StatsTrackingMixin)
-
-### v3.2.1 - Previous Release (2025-08-19)
-- **Added**: Complete statistics and analytics system with health monitoring and performance tracking
-- **Added**: Fine-grained locking system to prevent deadlocks (replaced single `_stats_lock` with category-specific locks)
-- **Added**: Consistent synchronous statistics API across all components for thread-safe access
-- **Fixed**: Critical deadlock when OrderManager and StatisticsAggregator accessed locks in opposite order
-- **Fixed**: API consistency issues - all `get_memory_stats()` methods now synchronous
-- **Enhanced**: StatisticsAggregator with 5-second TTL caching and cross-component metrics
-- **Enhanced**: Health scoring algorithm (0-100) with intelligent system monitoring
-
-### v3.2.0 - Previous Release (2025-08-17)
-- **Added**: Comprehensive type system overhaul with TypedDict and Protocol definitions
-- **Added**: StatsTrackingMixin for error and memory tracking across all managers
-- **Added**: Standardized deprecation system with @deprecated decorators
-- **Fixed**: Type hierarchy issues between ProjectXBase and ProjectXClientProtocol
-- **Fixed**: Response type handling for dict|list union types
-- **Improved**: Test coverage with 47 new tests for type system
-- **Improved**: Reduced type errors from 100+ to just 13 edge cases
-
-### v3.1.13
-- **Fixed**: Event system data structure mismatches causing order fill detection failures
-  - Bracket orders now properly detect fills without 60-second timeouts
-  - Event handlers handle both `order_id` and nested `order` object structures
-  - ManagedTrade correctly listens to ORDER_FILLED instead of ORDER_MODIFIED
-- **Fixed**: Type annotations for SignalR hub connections
-  - Created HubConnection type alias for proper IDE support
-  - market_connection and user_connection now have proper types instead of Any
-- **Improved**: Real-time connection stability with circuit breaker pattern
-- **Improved**: Data storage robustness with thread-safety and performance optimizations
-- **Enhanced**: Test coverage increased from 30% to 93% for client module
-- **Fixed**: Multiple asyncio deprecation warnings
-
-### v3.1.12
-- **Enhanced**: Significantly improved `01_events_with_on.py` real-time data example
-  - Added CSV export functionality with interactive prompts
-  - Plotly-based candlestick chart generation
-  - Non-blocking user input handling
-  - Better bar display formatting and visual indicators
-  - Automatic browser opening for generated charts
-
-### v3.1.11
-- **Fixed**: ManagedTrade `_get_market_price()` implementation
-  - ManagedTrade can now fetch current market prices from data manager
-  - Automatic fallback through multiple timeframes (1sec, 15sec, 1min, 5min)
-  - Enables risk-managed trades without explicit entry prices
-  - Proper integration with TradingSuite's data manager
-
-### v3.1.10
-- Minor version bump for internal improvements
-
-### v3.1.9
-- **Fixed**: Tick price alignment in real-time data manager
-  - All OHLC prices now properly aligned to instrument tick size
-  - `get_current_price()` returns tick-aligned values
-  - Prevents invalid prices (e.g., $23,927.62 for NQ now snaps to $23,927.50)
-- **Documented**: ProjectX volume data limitation (platform-specific, not full exchange volume)
-
-### v3.1.8 - Previous Release
-- **Fixed**: Real-time data processing for E-mini contracts (NQ/ES) that resolve to different symbols
-- **Added**: Bar timer mechanism to create empty bars during low-volume periods
-- **Improved**: Symbol matching to handle contract resolution (e.g., NQ→ENQ)
-- **Enhanced**: Real-time data manager now properly processes all futures contracts
-
-### v3.1.7
-- Minor updates and improvements
-- Documentation enhancements
-
-### v3.1.6 - Critical Deadlock Fix
-- **Fixed**: Deadlock when calling `suite.data` methods from event handler callbacks (Issue #39)
-- **Improved**: Event emission now non-blocking to prevent handler deadlocks
-- **Enhanced**: Event triggering moved outside lock scope for better concurrency
-- **Added**: Missing asyncio import in data_processing module
-- **Maintained**: Full API compatibility - no breaking changes
-
-### v3.1.5 - Enhanced Bar Data Retrieval
-- **Added**: Optional `start_time` and `end_time` parameters to `get_bars()` method
-- **Improved**: Precise time range specification for historical data queries
-- **Enhanced**: Full timezone support with automatic UTC conversion
-- **Maintained**: Complete backward compatibility with existing `days` parameter
-
-### v3.1.4 - WebSocket Connection Fix
-- **Fixed**: Critical WebSocket error with missing `_use_batching` attribute
-- **Improved**: Proper mixin initialization in ProjectXRealtimeClient
-- **Enhanced**: More robust real-time connection handling
-
-### v3.0.2 - Bug Fixes and Improvements
-- **Order Lifecycle Tracking**: Fixed asyncio concurrency and field reference issues
-- **Order Templates**: Fixed instrument lookup to use cached object
-- **Cleanup Functionality**: Added comprehensive order/position cleanup
-- **Documentation**: Updated all docs to reflect current version
-
-### v3.0.1 - Production Ready
-- **Performance Optimizations**: Enhanced connection pooling and caching
-- **Event Bus System**: Unified event handling across all components
-- **Risk Management**: Integrated risk manager with position limits and monitoring
-- **Order Tracking**: Comprehensive order lifecycle tracking and management
-- **Memory Management**: Optimized sliding windows and automatic cleanup
-- **Enhanced Models**: Improved data models with better type safety
-
-### v3.0.0 - Major Architecture Improvements
-- **Trading Suite**: Unified trading suite with all managers integrated
-- **Advanced Order Types**: OCO, bracket orders, and position-based orders
-- **Real-time Integration**: Seamless WebSocket data flow across all components
-- **Protocol-based Design**: Type-safe protocols for all major interfaces
-
-### v2.0.4 - Package Refactoring
-- Converted monolithic modules to multi-file packages
-- All core modules organized as packages with focused submodules
-- Improved code organization and maintainability
-
-### Trading Suite Usage (v3.0.0+)
-```python
-# Complete trading suite with all managers
-from project_x_py import TradingSuite
-
-async def main():
-    suite = await TradingSuite.create(
-        "MNQ",
-        timeframes=["1min", "5min"],
-        features=["orderbook", "risk_manager"],  # Optional features
-        initial_days=5
-    )
-
-    # All managers are integrated and ready
-    # No need to call start() - already connected
-
-    # Access individual managers
-    order = await suite.orders.place_market_order(
-        contract_id=suite.instrument_info.id,
-        side=0,  # Buy
-        size=1
-    )
-
-    position = await suite.positions.get_position("MNQ")
-    bars = await suite.data.get_data("1min")
-```
-
-### Key Async Examples
-```python
-# Basic usage
-async with ProjectX.from_env() as client:
-    await client.authenticate()
-    bars = await client.get_bars("MNQ", days=5)
-
-# Real-time data with TradingSuite
-async def stream_data():
-    suite = await TradingSuite.create(
-        "MNQ",
-        timeframes=["1min", "5min"]
-    )
-
-    # Register event handlers
-    from project_x_py import EventType
-
-    async def handle_bar(event):
-        print(f"New bar: {event.data}")
-
-    await suite.on(EventType.NEW_BAR, handle_bar)
-
-    # Data is already streaming
-    # Access current data
-    current_price = await suite.data.get_current_price()
-    bars = await suite.data.get_data("1min")
-```

src/project_x_py/order_manager/position_orders.py

@@ -355,7 +355,7 @@ def untrack_order(self: "OrderManagerProtocol", order_id: int) -> None:
 
             logger.debug(f"Untracked order {order_id}")
 
-    def get_position_orders(
+    async def get_position_orders(
         self: "OrderManagerProtocol", contract_id: str
     ) -> dict[str, list[int]]:
         """
@@ -408,7 +408,7 @@ async def cancel_position_orders(
         if order_types is None:
             order_types = ["entry", "stop", "target"]
 
-        position_orders = self.get_position_orders(contract_id)
+        position_orders = await self.get_position_orders(contract_id)
         # Track successful cancellations by type
         success_counts = {"entry": 0, "stop": 0, "target": 0, "failed": 0}
         error_messages: list[str] = []
@@ -503,7 +503,7 @@ async def update_position_order_sizes(
         # TODO: Implement multi-account support using account_id parameter
         _ = account_id  # Unused for now, reserved for future multi-account support
 
-        position_orders = self.get_position_orders(contract_id)
+        position_orders = await self.get_position_orders(contract_id)
         results: dict[str, Any] = {"modified": 0, "failed": 0, "errors": []}
 
         # Update stop and target orders

src/project_x_py/order_manager/tracking.py

@@ -227,7 +227,9 @@ def _unlink_oco_orders(self: "OrderManagerProtocol", order_id: int) -> int | Non
             self.oco_groups.pop(order_id, None)
             return None
 
-    def get_oco_linked_order(self: "OrderManagerProtocol", order_id: int) -> int | None:
+    async def get_oco_linked_order(
+        self: "OrderManagerProtocol", order_id: int
+    ) -> int | None:
         """
         Get the order ID linked to the given order in an OCO relationship.
 
@@ -1343,10 +1345,12 @@ def clear_order_tracking(self: "OrderManagerProtocol") -> None:
         self._completed_orders.clear()
 
         # Clear task monitoring data if they exist
-        if hasattr(self, "_task_results"):
-            self._task_results.clear()
-        if hasattr(self, "_cancellation_failures"):
-            self._cancellation_failures.clear()
+        task_results = getattr(self, "_task_results", None)
+        if task_results is not None:
+            task_results.clear()
+        cancellation_failures = getattr(self, "_cancellation_failures", None)
+        if cancellation_failures is not None:
+            cancellation_failures.clear()
 
         # Reset statistics
         self._memory_stats.update(

src/project_x_py/orderbook/__init__.py

@@ -487,15 +487,15 @@ async def get_spread_analysis(
         return await self.profile.get_spread_analysis(window_minutes)
 
     # Delegate memory methods
-    def get_memory_stats(self) -> dict[str, Any]:
+    async def get_memory_stats(self) -> dict[str, Any]:
         """
         Get comprehensive memory usage statistics.
 
         Delegates to MemoryManager.get_memory_stats().
         See MemoryManager.get_memory_stats() for complete documentation.
         """
-        # Call the synchronous memory manager method - matches base class signature
-        stats = self.memory_manager.get_memory_stats()
+        # Call the async memory manager method
+        stats = await self.memory_manager.get_memory_stats()
         return dict(stats) if stats else {}
 
     async def cleanup(self) -> None:

src/project_x_py/orderbook/base.py

@@ -890,30 +890,13 @@ async def get_orderbook_memory_usage(self) -> float:
 
         return base_memory + bids_memory + asks_memory + trades_memory + history_memory
 
-    def get_memory_stats(self) -> dict[str, Any]:
+    async def get_memory_stats(self) -> dict[str, Any]:
         """
-        Get comprehensive memory and statistics (synchronous for backward compatibility).
+        Get comprehensive memory and statistics.
 
         Returns orderbook-specific statistics compatible with the collector expectations.
         """
-        import asyncio
-
-        # For backward compatibility, run async methods in a new event loop if needed
-        try:
-            loop = asyncio.get_event_loop()
-            if loop.is_running():
-                # If we're in an async context, we can't use async methods synchronously
-                # Return basic memory stats only
-                return self._get_basic_memory_stats()
-        except RuntimeError:
-            pass
-
-        # If no loop is running, we can create one
-        try:
-            return asyncio.run(self._get_comprehensive_stats())
-        except RuntimeError:
-            # Fallback to basic stats if async operations fail
-            return self._get_basic_memory_stats()
+        return await self._get_comprehensive_stats()
 
     def _get_basic_memory_stats(self) -> dict[str, Any]:
         """Get basic memory stats without async operations."""

src/project_x_py/orderbook/memory.py

@@ -332,7 +332,7 @@ async def _cleanup_market_history(self) -> None:
         # Delta history - deque handles its own cleanup with maxlen
         # No manual cleanup needed for deque with maxlen
 
-    def get_memory_stats(self) -> OrderbookStats:
+    async def get_memory_stats(self) -> OrderbookStats:
         """
         Get comprehensive memory usage statistics.
 
@@ -342,8 +342,6 @@ def get_memory_stats(self) -> OrderbookStats:
         debugging memory issues, and validating that the cleanup strategies are working
         as expected.
 
-        Note: This is a synchronous method that computes stats immediately.
-
         Returns:
             Dict containing comprehensive memory statistics including:
                 orderbook_bids_count: Number of bid price levels

src/project_x_py/position_manager/reporting.py

@@ -63,7 +63,7 @@
 class PositionReportingMixin:
     """Mixin for statistics, history, and report generation."""
 
-    def get_position_statistics(
+    async def get_position_statistics(
         self: "PositionManagerProtocol",
     ) -> "PositionManagerStats":
         """

src/project_x_py/position_manager/tracking.py

@@ -623,6 +623,6 @@ async def add_callback(
             "add_callback is deprecated. Use TradingSuite.on() with EventType enum instead."
         )
 
-    def get_position_history_size(self, contract_id: str) -> int:
+    async def get_position_history_size(self, contract_id: str) -> int:
         """Get the current size of position history for a contract."""
         return len(self.position_history.get(contract_id, deque()))

src/project_x_py/realtime_data_manager/core.py

@@ -568,10 +568,9 @@ def _init_data_manager_counters(self) -> None:
         # These will be tracked using the new BaseStatisticsTracker async methods
         # Called during __init__ but actual counter setup happens async
 
-    def get_memory_stats(self) -> "RealtimeDataManagerStats":
-        """Get comprehensive memory usage statistics (synchronous for backward compatibility)."""
-        # This method remains synchronous to maintain backward compatibility
-        # but pulls data from both legacy stats and new statistics system
+    async def get_memory_stats(self) -> "RealtimeDataManagerStats":
+        """Get comprehensive memory usage statistics."""
+        # Async method for proper I/O handling and new statistics system compatibility
 
         # Update current statistics from data structures
         timeframe_stats = {}
@@ -612,7 +611,13 @@ def get_memory_stats(self) -> "RealtimeDataManagerStats":
         # Add overflow stats if available
         overflow_stats = {}
         if hasattr(self, "get_overflow_stats"):
-            overflow_stats = self.get_overflow_stats()
+            try:
+                method = self.get_overflow_stats
+                if callable(method):
+                    # Method is always async now
+                    overflow_stats = await method()
+            except Exception:
+                overflow_stats = {}
 
         # Add lock optimization stats
         lock_stats = {}