Merge pull request #62 from TexasCoding/v3.5.1_testing

fix: resolve critical TradingSuite bugs identified by TDD test suite (v3.5.1)

Author: TexasCoding

.claude/agents/code-reviewer.md

@@ -1,6 +1,7 @@
 ---
 name: code-reviewer
 description: Perform thorough code reviews for the project-x-py async trading SDK, focusing on async patterns, real-time performance, financial data integrity, and API stability. Use PROACTIVELY for PR reviews and before releases.
+tools: Glob, Grep, LS, Read, WebFetch, TodoWrite, WebSearch, BashOutput, KillBash, ListMcpResourcesTool, ReadMcpResourceTool, Bash
 model: sonnet
 color: yellow
 ---

.claude/commands/test-module.md

@@ -23,6 +23,7 @@
            3. Refactor: Improve the code's design and quality while ensuring all tests remain green.
        * **Bug Discovery**: The primary goal of this TDD approach is to uncover any bugs in the core logic. If a test fails, it is because the implementation is incorrect, not the test. Fix the code to match the
          test's expectations.
+       * **Fix All Issues/Bugs Found when they are found**: When testing reveals a bug in core logic we need to fix the bug immediately. Never make tests pass without fixing the underlying issue!
 
   ## Final Deliverable:
 

.secrets.baseline

@@ -133,7 +133,7 @@
         "filename": "CHANGELOG.md",
         "hashed_secret": "89a6cfe2a229151e8055abee107d45ed087bbb4f",
         "is_verified": false,
-        "line_number": 1984
+        "line_number": 2010
       }
     ],
     "README.md": [
@@ -325,5 +325,5 @@
       }
     ]
   },
-  "generated_at": "2025-08-30T16:25:48Z"
+  "generated_at": "2025-08-30T21:20:10Z"
 }

CHANGELOG.md

@@ -14,6 +14,32 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Migration guides will be provided for all breaking changes
 - Semantic versioning (MAJOR.MINOR.PATCH) is strictly followed
 
+## [3.5.1] - 2025-01-30
+
+### 🐛 Fixed
+
+**Critical Bug Fixes from TDD Test Suite**:
+- **Context Manager Re-entry**: Fixed issue where TradingSuite context manager couldn't be re-entered after exit
+- **ManagedTrade Attributes**: Added missing property accessors for `risk_manager`, `order_manager`, and `position_manager`
+- **Event Loop Handling**: Fixed `get_stats_sync()` to properly handle nested event loops using ThreadPoolExecutor
+- **Deprecation Warnings**: Ensured consistent deprecation warnings when accessing components directly
+- **Config Validation**: Fixed config file validation to check file extension before attempting file operations
+
+**Session Management Fixes**:
+- Fixed `set_session_type()`, `get_session_data()`, and `get_session_statistics()` to work correctly in multi-instrument mode
+- Session methods now properly iterate over all instrument contexts when in multi-instrument mode
+- Added fallback for single-instrument backward compatibility mode
+
+**Test Suite Fixes**:
+- Updated benchmark tests to use private attributes (`_orders`, `_positions`, etc.)
+- Fixed integration tests to properly mock multi-instrument contexts
+- Resolved statistics and event bus test failures caused by property-only access
+
+### 🔧 Changed
+
+- Component attributes (`data`, `orders`, `positions`, `orderbook`, `risk_manager`) are now stored as private attributes with deprecation warning properties
+- Context manager always initializes when entering context, regardless of `auto_connect` setting
+
 ## [3.5.0] - 2025-01-25
 
 ### 🚀 Major Feature: Multi-Instrument TradingSuite

README.md

@@ -21,9 +21,9 @@ A **high-performance async Python SDK** for the [ProjectX Trading Platform](http
 
 This Python SDK acts as a bridge between your trading strategies and the ProjectX platform, handling all the complex API interactions, data processing, and real-time connectivity.
 
-## 🚀 v3.5.0 - Multi-Instrument TradingSuite
+## 🚀 v3.5.1 - Multi-Instrument TradingSuite with Critical Bug Fixes
 
-**Latest Version**: v3.5.0 - Major enhancement enabling TradingSuite to manage multiple instruments simultaneously. This revolutionary feature enables complex multi-asset trading strategies, portfolio management, and cross-instrument analysis while maintaining full backward compatibility.
+**Latest Version**: v3.5.1 - Critical bug fixes for TradingSuite including context manager re-entry, event loop handling, and session management in multi-instrument mode. The v3.5.0 release introduced multi-instrument support enabling complex multi-asset trading strategies while maintaining full backward compatibility.
 
 **Key Benefits**:
 - 🎯 **Multi-Asset Strategies**: Trade ES vs NQ pairs, commodity spreads, sector rotation
@@ -32,7 +32,7 @@ This Python SDK acts as a bridge between your trading strategies and the Project
 - 🛡️ **Backward Compatible**: Existing single-instrument code continues to work
 - ⚡ **Performance Optimized**: Parallel context creation and resource sharing
 
-See [CHANGELOG.md](CHANGELOG.md) for complete v3.5.0 release notes and migration guide.
+See [CHANGELOG.md](CHANGELOG.md) for complete v3.5.1 bug fixes and v3.5.0 release notes with migration guide.
 
 ### 📦 Production Stability Guarantee
 

docs/index.md

@@ -7,8 +7,8 @@
 
 **project-x-py** is a high-performance **async Python SDK** for the [ProjectX Trading Platform](https://www.projectx.com/) Gateway API. This library enables developers to build sophisticated trading strategies and applications by providing comprehensive async access to futures trading operations, real-time market data, Level 2 orderbook analysis, and a complete technical analysis suite with 58+ TA-Lib compatible indicators including pattern recognition.
 
-!!! note "Version 3.5.0 - Multi-Instrument TradingSuite"
-    **Revolutionary Release**: Complete multi-instrument support enabling traders to manage multiple futures contracts simultaneously. Features include pairs trading, cross-market arbitrage, portfolio-level risk management, and advanced analytics across instruments. Full backward compatibility maintained with zero breaking changes.
+!!! note "Version 3.5.1 - Multi-Instrument TradingSuite with Critical Bug Fixes"
+    **Latest Release**: Critical bug fixes for TradingSuite including context manager re-entry, event loop handling, and session management in multi-instrument mode. The v3.5.0 release introduced revolutionary multi-instrument support enabling traders to manage multiple futures contracts simultaneously with pairs trading, cross-market arbitrage, and portfolio-level risk management. Full backward compatibility maintained.
 
 !!! note "Stable Production Release"
     Since v3.1.1, this project maintains strict semantic versioning with backward compatibility between minor versions. Breaking changes only occur in major version releases (4.0.0+). Deprecation warnings are provided for at least 2 minor versions before removal.
@@ -216,6 +216,14 @@ mnq_context = suite["MNQ"]  # Access specific instrument
 
 ## Recent Changes
 
+### v3.5.1 - Critical Bug Fixes (2025-01-30)
+- **Fixed**: Context manager re-entry issue in TradingSuite
+- **Fixed**: ManagedTrade missing property accessors
+- **Fixed**: Event loop handling in `get_stats_sync()` for nested async contexts
+- **Fixed**: Inconsistent deprecation warnings for direct component access
+- **Fixed**: Config file validation order (extension check before file operations)
+- **Fixed**: Session management methods in multi-instrument mode
+
 ### v3.5.0 - Multi-Instrument TradingSuite (2025-01-25)
 - **MAJOR**: Revolutionary multi-instrument support for simultaneous contract management
 - **Added**: `InstrumentContext` dataclass for encapsulating instrument-specific managers

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "project-x-py"
-version = "3.5.0"
+version = "3.5.1"
 description = "High-performance Python SDK for futures trading with real-time WebSocket data, technical indicators, order management, and market depth analysis"
 readme = "README.md"
 license = { text = "MIT" }

src/project_x_py/__init__.py

@@ -109,7 +109,7 @@
     - `utils`: Utility functions and calculations
 """
 
-__version__ = "3.5.0"
+__version__ = "3.5.1"
 __author__ = "TexasCoding"
 
 # Core client classes - renamed from Async* to standard names

src/project_x_py/indicators/__init__.py

@@ -202,7 +202,7 @@
 )
 
 # Version info
-__version__ = "3.5.0"
+__version__ = "3.5.1"
 __author__ = "TexasCoding"
 
 

src/project_x_py/risk_manager/core.py

@@ -526,8 +526,15 @@ async def attach_risk_orders(
             # Create bracket response structure
             from project_x_py.models import BracketOrderResponse
 
+            # Success should only be True if ALL requested orders succeeded
+            success = True
+            if stop_loss and (not stop_response or not stop_response.success):
+                success = False
+            if take_profit and (not target_response or not target_response.success):
+                success = False
+
             bracket_response = BracketOrderResponse(
-                success=bool(stop_response or target_response),
+                success=success,
                 entry_order_id=None,  # No entry for existing position
                 stop_order_id=stop_response.orderId
                 if stop_response and stop_response.success
@@ -541,7 +548,9 @@ async def attach_risk_orders(
                 entry_response=None,
                 stop_response=stop_response,
                 target_response=target_response,
-                error_message=None,
+                error_message=None
+                if success
+                else "One or more risk orders failed to place",
             )
 
             # Setup trailing stop if configured
@@ -902,9 +911,10 @@ async def _monitor_trailing_stop(
             while True:
                 # Get current price
                 if self.positions is None:
-                    raise ValueError(
-                        "Position manager not set. Call set_position_manager() to resolve circular dependency."
+                    logger.warning(
+                        "Position manager not set for trailing stop monitoring. Exiting monitor."
                     )
+                    break
 
                 current_positions = await self.positions.get_all_positions()
                 current_pos = next(