example cleanup

Author: TexasCoding

examples/01_basic_client_connection_v3.py

@@ -69,7 +69,7 @@ async def main() -> bool:
         stats = suite.get_stats()
         print(f"   Connected: {stats['connected']}")
         print(f"   Instrument: {stats['instrument']}")
-        print(f"   Features: {stats['features']}")
+        print(f"   Features: {stats['components']}")
 
         # Clean disconnect
         await suite.disconnect()

examples/02_order_management.py

@@ -245,7 +245,7 @@ async def main() -> bool:
             print("   (Will trigger if price reaches this level)")
 
             if await wait_for_user_confirmation("Place stop order?"):
-                stop_response = await order_manager.place_stop_order(  # type: ignore[misc]
+                stop_response = await order_manager.place_stop_order(
                     contract_id=contract_id,
                     side=0,  # Buy
                     size=1,
@@ -286,7 +286,7 @@ async def main() -> bool:
             print("   Risk/Reward: 1:2 ratio")
 
             if await wait_for_user_confirmation("Place bracket order?"):
-                bracket_response = await order_manager.place_bracket_order(  # type: ignore[misc]
+                bracket_response = await order_manager.place_bracket_order(
                     contract_id=contract_id,
                     side=0,  # Buy
                     size=1,
@@ -504,7 +504,7 @@ async def main() -> bool:
                             f"Closing {side_text} position: {position.contractId} ({position.size} contracts)"
                         )
 
-                        response = await order_manager.close_position(  # type: ignore[misc]
+                        response = await order_manager.close_position(
                             position.contractId, method="market"
                         )
 

examples/03_position_management.py

@@ -137,17 +137,17 @@ async def display_risk_metrics(position_manager: "PositionManager") -> None:
     try:
         # Get risk metrics if available
         try:
-            if hasattr(position_manager, "check_risk_limits"):
-                risk_check = await position_manager.check_risk_limits()
+            if hasattr(position_manager, "get_risk_metrics"):
+                risk_check = await position_manager.get_risk_metrics()
                 if risk_check and risk_check.get("within_limits"):
                     print("✅ All positions within risk limits")
                 else:
                     print("❌ Risk limit violations detected")
             else:
                 print("Risk limits check not available")
 
-            if hasattr(position_manager, "get_risk_summary"):
-                risk_summary = await position_manager.get_risk_summary()
+            if hasattr(position_manager, "get_risk_metrics"):
+                risk_summary = await position_manager.get_risk_metrics()
                 print("\nRisk Summary:")
                 print(
                     f"  Total Exposure: ${risk_summary.get('total_exposure', 0):,.2f}"
@@ -218,9 +218,9 @@ async def monitor_positions(
                 print(f"  Total P&L: ${total_pnl:,.2f}")
 
                 # Get summary if available
-                if hasattr(position_manager, "get_portfolio_summary"):
+                if hasattr(position_manager, "get_portfolio_pnl"):
                     try:
-                        summary = await position_manager.get_portfolio_summary()
+                        summary = await position_manager.get_portfolio_pnl()
                         print(
                             f"  Win rate: {summary.get('win_rate', 0):.1%} ({summary.get('winning_trades', 0)}/{summary.get('total_trades', 0)})"
                         )
@@ -330,8 +330,8 @@ async def main() -> bool:
             print("\n📊 Portfolio Statistics:")
             print("-" * 80)
             try:
-                if hasattr(suite.positions, "get_portfolio_statistics"):
-                    stats = await suite.positions.get_portfolio_statistics()
+                if hasattr(suite.positions, "get_portfolio_pnl"):
+                    stats = await suite.positions.get_portfolio_pnl()
                     print(f"  Total Trades: {stats.get('total_trades', 0)}")
                     print(f"  Winning Trades: {stats.get('winning_trades', 0)}")
                     print(f"  Average Win: ${stats.get('average_win', 0):,.2f}")
@@ -347,8 +347,8 @@ async def main() -> bool:
             print("\n📈 Performance Analytics:")
             print("-" * 80)
             try:
-                if hasattr(suite.positions, "get_performance_analytics"):
-                    analytics = await suite.positions.get_performance_analytics()
+                if hasattr(suite.positions, "get_portfolio_pnl"):
+                    analytics = await suite.positions.get_portfolio_pnl()
                     print(f"  Total P&L: ${analytics.get('total_pnl', 0):,.2f}")
                     print(f"  Max Drawdown: ${analytics.get('max_drawdown', 0):,.2f}")
                     print(
@@ -419,8 +419,8 @@ async def main() -> bool:
         print("=" * 80)
 
         try:
-            if hasattr(suite.positions, "get_session_summary"):
-                session_summary = await suite.positions.get_session_summary()
+            if hasattr(suite.positions, "get_portfolio_pnl"):
+                session_summary = await suite.positions.get_portfolio_pnl()
                 print(f"  Session Duration: {session_summary.get('duration', 'N/A')}")
                 print(
                     f"  Positions Opened: {session_summary.get('positions_opened', 0)}"

examples/04_realtime_data.py

@@ -34,12 +34,13 @@
     TradingSuite,
     setup_logging,
 )
+from project_x_py.types.protocols import RealtimeDataManagerProtocol
 
 if TYPE_CHECKING:
     from project_x_py.realtime_data_manager import RealtimeDataManager
 
 
-async def display_current_prices(data_manager: "RealtimeDataManager"):
+async def display_current_prices(data_manager: "RealtimeDataManager") -> None:
     """Display current prices across all timeframes asynchronously."""
     print("\n📊 Current Prices:")
 
@@ -84,7 +85,7 @@ async def display_current_prices(data_manager: "RealtimeDataManager"):
             print(f"   {timeframe:>6}: No data")
 
 
-async def display_memory_stats(data_manager):
+async def display_memory_stats(data_manager: "RealtimeDataManager") -> None:
     """Display memory usage statistics asynchronously."""
     try:
         # get_memory_stats is synchronous in async data manager
@@ -106,7 +107,7 @@ async def display_memory_stats(data_manager):
         print(f"   ❌ Memory stats error: {e}")
 
 
-async def display_system_statistics(data_manager):
+async def display_system_statistics(data_manager: "RealtimeDataManager") -> None:
     """Display comprehensive system and validation statistics asynchronously."""
     try:
         # Use validation status instead of get_statistics (which doesn't exist)
@@ -138,7 +139,7 @@ async def display_system_statistics(data_manager):
         print(f"   ❌ System stats error: {e}")
 
 
-async def demonstrate_historical_analysis(data_manager):
+async def demonstrate_historical_analysis(data_manager: "RealtimeDataManager") -> None:
     """Demonstrate historical data analysis asynchronously."""
     print("\n📈 Historical Data Analysis:")
 
@@ -158,7 +159,7 @@ async def demonstrate_historical_analysis(data_manager):
             if data is not None and not data.is_empty():
                 # Calculate basic statistics
                 avg_price = data["close"].mean()
-                price_range = data["close"].max() - data["close"].min()
+                price_range = float(data["close"].max()) - float(data["close"].min())
                 total_volume = data["volume"].sum()
 
                 print(f"   {tf} Analysis (last 100 bars):")
@@ -172,7 +173,7 @@ async def demonstrate_historical_analysis(data_manager):
         print(f"   ❌ Analysis error: {e}")
 
 
-async def new_bar_callback(data):
+async def new_bar_callback(data: dict[str, Any]) -> None:
     """Handle new bar creation asynchronously."""
     timestamp = datetime.now().strftime("%H:%M:%S")
     timeframe = data["timeframe"]
@@ -182,7 +183,7 @@ async def new_bar_callback(data):
     )
 
 
-async def main():
+async def main() -> bool:
     """Main async real-time data streaming demonstration."""
 
     # Setup logging
@@ -248,7 +249,7 @@ async def main():
         print("\n🔔 Registering optional event handlers for demonstration...")
         try:
             # Use the EventBus through TradingSuite
-            suite.on(EventType.NEW_BAR, new_bar_callback)
+            await suite.on(EventType.NEW_BAR, new_bar_callback)
             print("✅ Optional event handlers registered!")
         except Exception as e:
             print(f"⚠️ Event handler registration error: {e}")
@@ -266,19 +267,19 @@ async def main():
         print("=" * 60)
 
         # Create concurrent monitoring tasks
-        async def monitor_prices():
+        async def monitor_prices() -> None:
             """Monitor and display prices periodically."""
             while True:
                 await asyncio.sleep(10)  # Update every 10 seconds
                 await display_current_prices(data_manager)
 
-        async def monitor_statistics():
+        async def monitor_statistics() -> None:
             """Monitor and display statistics periodically."""
             while True:
                 await asyncio.sleep(30)  # Update every 30 seconds
                 await display_system_statistics(data_manager)
 
-        async def monitor_memory():
+        async def monitor_memory() -> None:
             """Monitor and display memory usage periodically."""
             while True:
                 await asyncio.sleep(60)  # Update every minute

examples/05_orderbook_analysis.py

@@ -41,7 +41,7 @@
 from project_x_py.orderbook import OrderBook
 
 
-async def display_best_prices(orderbook):
+async def display_best_prices(orderbook: OrderBook) -> None:
     """Display current best bid/ask prices."""
     best_prices = await orderbook.get_best_bid_ask()
     best_bid = best_prices.get("bid")
@@ -67,7 +67,7 @@ async def display_best_prices(orderbook):
         print("   No bid/ask available", flush=True)
 
 
-async def display_market_depth(orderbook):
+async def display_market_depth(orderbook: OrderBook) -> None:
     """Display market depth on both sides."""
     # Get bid and ask levels separately
     bids_df = await orderbook.get_orderbook_bids(levels=5)
@@ -116,7 +116,7 @@ async def display_market_depth(orderbook):
             print("(Balanced ⚖️)", flush=True)
 
 
-async def display_trade_flow(orderbook):
+async def display_trade_flow(orderbook: OrderBook) -> None:
     """Display recent trade flow analysis."""
     trades = await orderbook.get_recent_trades(count=10)
 
@@ -153,7 +153,7 @@ async def display_trade_flow(orderbook):
         )
 
 
-async def display_market_microstructure(orderbook):
+async def display_market_microstructure(orderbook: OrderBook) -> None:
     """Display market microstructure analysis."""
     # Use get_advanced_market_metrics instead
     try:
@@ -189,7 +189,7 @@ async def display_market_microstructure(orderbook):
         )
 
 
-async def display_iceberg_detection(orderbook):
+async def display_iceberg_detection(orderbook: OrderBook) -> None:
     """Display potential iceberg orders."""
     # Use detect_iceberg_orders instead of detect_icebergs
     icebergs = await orderbook.detect_iceberg_orders()
@@ -215,7 +215,7 @@ async def display_iceberg_detection(orderbook):
         print("   No iceberg orders detected", flush=True)
 
 
-async def monitor_orderbook_realtime(orderbook: OrderBook, duration: int = 45):
+async def monitor_orderbook_realtime(orderbook: OrderBook, duration: int = 45) -> None:
     """Monitor orderbook in real-time for specified duration."""
     print(f"\n🔄 Real-time Monitoring ({duration} seconds)...", flush=True)
     print("=" * 60, flush=True)
@@ -253,7 +253,7 @@ async def monitor_orderbook_realtime(orderbook: OrderBook, duration: int = 45):
     print("\n✅ Real-time monitoring completed", flush=True)
 
 
-async def demonstrate_comprehensive_methods(orderbook: OrderBook):
+async def demonstrate_comprehensive_methods(orderbook: OrderBook) -> None:
     """Demonstrate all comprehensive orderbook methods after 2 minutes."""
     print("\n⏰ Waiting 2 minutes for data accumulation...", flush=True)
     print(
@@ -398,7 +398,7 @@ async def demonstrate_comprehensive_methods(orderbook: OrderBook):
         print(f"   Error: {e}", flush=True)
 
 
-async def main():
+async def main() -> bool:
     """Main async orderbook analysis demonstration."""
     logger = setup_logging(level="INFO")
     print("🚀 Async Level 2 Orderbook Analysis Example (v3.0.0)", flush=True)