fix: Remove stub methods causing authentication failure

- Removed stub _make_request() from AuthenticationMixin that was returning None
- Removed stub _refresh_authentication() from HttpMixin
- These stubs were overriding actual implementations from other mixins
- Added proper TYPE_CHECKING imports and Protocol type hints instead
- All methods now properly typed with ProjectXClientProtocol for self parameter
- Authentication now works correctly with all examples passing

The stub methods were added for type annotation purposes but were inadvertently
overriding the real implementations due to Python's MRO (Method Resolution Order).
Using TYPE_CHECKING with Protocol type hints is the correct approach for typing
mixins that depend on methods from other mixins.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: TexasCoding

src/project_x_py/client/auth.py

@@ -54,7 +54,7 @@ async def main():
 import base64
 import datetime
 from datetime import timedelta
-from typing import Any
+from typing import TYPE_CHECKING
 
 import orjson
 import pytz
@@ -70,6 +70,9 @@ async def main():
     validate_response,
 )
 
+if TYPE_CHECKING:
+    from project_x_py.types import ProjectXClientProtocol
+
 logger = ProjectXLogger.get_logger(__name__)
 
 
@@ -82,18 +85,6 @@ class AuthenticationMixin:
     account_name: str | None
     headers: dict[str, str]
 
-    async def _make_request(
-        self,
-        method: str,
-        endpoint: str,
-        data: dict[str, Any] | None = None,
-        params: dict[str, Any] | None = None,
-        headers: dict[str, str] | None = None,
-        retry_count: int = 0,
-    ) -> Any:
-        """Provided by HttpMixin."""
-        _ = (method, endpoint, data, params, headers, retry_count)
-
     def __init__(self) -> None:
         """Initialize authentication attributes."""
         super().__init__()
@@ -102,7 +93,7 @@ def __init__(self) -> None:
         self._authenticated = False
         self.account_info: Account | None = None
 
-    async def _refresh_authentication(self) -> None:
+    async def _refresh_authentication(self: "ProjectXClientProtocol") -> None:
         """
         Refresh authentication if token is expired or about to expire.
 
@@ -118,7 +109,7 @@ async def _refresh_authentication(self) -> None:
         if self._should_refresh_token():
             await self.authenticate()
 
-    def _should_refresh_token(self) -> bool:
+    def _should_refresh_token(self: "ProjectXClientProtocol") -> bool:
         """
         Check if the authentication token should be refreshed.
 
@@ -140,7 +131,7 @@ def _should_refresh_token(self) -> bool:
         return datetime.datetime.now(pytz.UTC) >= (self.token_expiry - buffer_time)
 
     @handle_errors("authenticate")
-    async def authenticate(self) -> None:
+    async def authenticate(self: "ProjectXClientProtocol") -> None:
         """
         Authenticate with ProjectX API and select account.
 
@@ -179,7 +170,6 @@ async def authenticate(self) -> None:
         response = await self._make_request("POST", "/Auth/loginKey", data=auth_data)
 
         if not response:
-            logger.error(f"Empty response from auth endpoint")
             raise ProjectXAuthenticationError(ErrorMessages.AUTH_FAILED)
 
         self.session_token = response["token"]
@@ -252,7 +242,7 @@ async def authenticate(self) -> None:
             },
         )
 
-    async def _ensure_authenticated(self) -> None:
+    async def _ensure_authenticated(self: "ProjectXClientProtocol") -> None:
         """
         Ensure client is authenticated before making API calls.
 
@@ -277,7 +267,7 @@ async def _ensure_authenticated(self) -> None:
 
     @handle_errors("list accounts")
     @validate_response(required_fields=["success", "accounts"])
-    async def list_accounts(self) -> list[Account]:
+    async def list_accounts(self: "ProjectXClientProtocol") -> list[Account]:
         """
         List all accounts available to the authenticated user.
 

src/project_x_py/client/http.py

@@ -52,7 +52,7 @@ async def main():
 """
 
 import time
-from typing import Any, TypeVar
+from typing import TYPE_CHECKING, Any, TypeVar
 
 import httpx
 
@@ -77,6 +77,9 @@ async def main():
     retry_on_network_error,
 )
 
+if TYPE_CHECKING:
+    from project_x_py.types import ProjectXClientProtocol
+
 T = TypeVar("T")
 
 logger = ProjectXLogger.get_logger(__name__)
@@ -94,16 +97,13 @@ class HttpMixin:
     cache_hit_count: int
     api_call_count: int
 
-    async def _refresh_authentication(self) -> None:
-        """Provided by AuthenticationMixin."""
-
     def __init__(self) -> None:
         """Initialize HTTP client attributes."""
         super().__init__()
         self._client: httpx.AsyncClient | None = None
         self.api_call_count = 0
 
-    async def _create_client(self) -> httpx.AsyncClient:
+    async def _create_client(self: "ProjectXClientProtocol") -> httpx.AsyncClient:
         """
         Create an optimized httpx async client with connection pooling and retries.
 
@@ -147,7 +147,7 @@ async def _create_client(self) -> httpx.AsyncClient:
 
         return client
 
-    async def _ensure_client(self) -> httpx.AsyncClient:
+    async def _ensure_client(self: "ProjectXClientProtocol") -> httpx.AsyncClient:
         """
         Ensure HTTP client is initialized and ready for API requests.
 
@@ -169,7 +169,7 @@ async def _ensure_client(self) -> httpx.AsyncClient:
     @handle_rate_limit()
     @retry_on_network_error(max_attempts=3)
     async def _make_request(
-        self,
+        self: "ProjectXClientProtocol",
         method: str,
         endpoint: str,
         data: dict[str, Any] | None = None,
@@ -280,9 +280,6 @@ async def _make_request(
                         retry_count=retry_count + 1,
                     )
                     return retry_result
-                logger.error(
-                    f"Authentication failed for {endpoint}, status: {response.status_code}, response: {response.text[:200]}"
-                )
                 raise ProjectXAuthenticationError(ErrorMessages.AUTH_FAILED)
 
             # Handle client errors
@@ -297,15 +294,6 @@ async def _make_request(
                 except Exception:
                     error_msg = response.text
 
-                # Log authentication endpoint errors for debugging
-                if endpoint == "/Auth/loginKey":
-                    logger.error(
-                        f"Auth endpoint error - Status: {response.status_code}, Message: {error_msg}"
-                    )
-                    return (
-                        None  # Return None for auth failures to match expected behavior
-                    )
-
                 if response.status_code == 404:
                     raise ProjectXDataError(
                         format_error_message(
@@ -330,7 +318,7 @@ async def _make_request(
 
     @handle_errors("get health status")
     async def get_health_status(
-        self,
+        self: "ProjectXClientProtocol",
     ) -> PerformanceStatsResponse:
         """
         Get client statistics and performance metrics.