feat(android): Document audio capture bug

Mattijs Korpershoek · Mattijs Korpershoek · commit aed5d7b01510 · 2024-12-02T15:25:48.000+01:00
We received an e2e error for an audio capture bug.

Document the steps that are needed to solve it by providing a patch and links to
other patches that need to be applied.

Signed-off-by: Mattijs Korpershoek &lt;mkorpershoek@baylibre.com&gt;
diff --git a/source/devices/AM62PX/android/0001-audio-update-default-value-for-audio-capture-in.patch b/source/devices/AM62PX/android/0001-audio-update-default-value-for-audio-capture-in.patch
@@ -0,0 +1,44 @@
+From 110fbd20bfd39fec96fcfecc87be3c497a2cb5c3 Mon Sep 17 00:00:00 2001
+From: Guillaume La Roque <glaroque@baylibre.com>
+Date: Fri, 27 Sep 2024 09:57:44 +0200
+Subject: [PATCH] audio: update default value for audio capture(in)
+
+Actually in code buffer size check is done to compare period size and count
+for xml with default value(IN_PCM_BUFFER_SIZE_DEFAULT), if xml value
+was higher than default we use default but default value was low.
+
+To support more hardware we need to set a default value to higher
+value to give possibility to set period size and count with xml file and
+each hardware should define in audio_policy_configuration.xml period
+size and period count value accordly to hardware capabilities instead of
+doing limitation in source code.
+
+For example on TI AM62P 256 for period size is too low we need actually 512
+to be able to do capture.
+
+Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
+---
+ audio/audio_hw.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/audio/audio_hw.c b/audio/audio_hw.c
+index 3aa24b0e8185..60f512da2fe2 100644
+--- a/audio/audio_hw.c
++++ b/audio/audio_hw.c
+@@ -66,10 +66,10 @@
+ #define OUT_CHANNEL_COUNT_DEFAULT 2
+ #define OUT_RATE_DEFAULT 44100
+ 
+-#define IN_PERIOD_SIZE_DEFAULT 256
+-#define IN_PERIOD_COUNT_DEFAULT 4
++#define IN_PERIOD_SIZE_DEFAULT 1024
++#define IN_PERIOD_COUNT_DEFAULT 16
+ #define IN_CHANNEL_MASK_DEFAULT AUDIO_CHANNEL_IN_MONO
+-#define IN_CHANNEL_COUNT_DEFAULT 1
++#define IN_CHANNEL_COUNT_DEFAULT 2
+ #define IN_RATE_DEFAULT 44100
+ 
+ #define IN_PCM_BUFFER_SIZE_DEFAULT \
+-- 
+2.47.0
+
diff --git a/source/devices/AM62PX/android/Release_Specific_Release_Notes.rst b/source/devices/AM62PX/android/Release_Specific_Release_Notes.rst
@@ -119,3 +119,8 @@ Known Issues
      - Some commands don't work from native console, but work via adb shell
      - N/A
      - N/A
+
+   * - `e2e 1410786 <https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1410786/sk-am62p-lp-analog-input-microphone-connected-to-3-5mm-jack-not-working>`_
+     - Analog Input Microphone connected to 3.5mm jack not working
+     - Apply :download:`this patch <0001-audio-update-default-value-for-audio-capture-in.patch>` in :file:`external/tinyhal`, `patch 1 <https://git.ti.com/cgit/android/device-ti-am62x/commit/?h=d-android14-release&id=15025d9dc1039469dd1260c837684edb17f991c1>`_ and `patch 2 <https://git.ti.com/cgit/android/device-ti-am62x/commit/?h=d-android14-release&id=61f86f096f71825df6665bb4e15110a5f5d74aea>`_ in :file:`device/ti/am62x`
+     - N/A
diff --git a/source/devices/AM62X/android/0001-audio-update-default-value-for-audio-capture-in.patch b/source/devices/AM62X/android/0001-audio-update-default-value-for-audio-capture-in.patch
@@ -0,0 +1,44 @@
+From 110fbd20bfd39fec96fcfecc87be3c497a2cb5c3 Mon Sep 17 00:00:00 2001
+From: Guillaume La Roque <glaroque@baylibre.com>
+Date: Fri, 27 Sep 2024 09:57:44 +0200
+Subject: [PATCH] audio: update default value for audio capture(in)
+
+Actually in code buffer size check is done to compare period size and count
+for xml with default value(IN_PCM_BUFFER_SIZE_DEFAULT), if xml value
+was higher than default we use default but default value was low.
+
+To support more hardware we need to set a default value to higher
+value to give possibility to set period size and count with xml file and
+each hardware should define in audio_policy_configuration.xml period
+size and period count value accordly to hardware capabilities instead of
+doing limitation in source code.
+
+For example on TI AM62P 256 for period size is too low we need actually 512
+to be able to do capture.
+
+Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
+---
+ audio/audio_hw.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/audio/audio_hw.c b/audio/audio_hw.c
+index 3aa24b0e8185..60f512da2fe2 100644
+--- a/audio/audio_hw.c
++++ b/audio/audio_hw.c
+@@ -66,10 +66,10 @@
+ #define OUT_CHANNEL_COUNT_DEFAULT 2
+ #define OUT_RATE_DEFAULT 44100
+ 
+-#define IN_PERIOD_SIZE_DEFAULT 256
+-#define IN_PERIOD_COUNT_DEFAULT 4
++#define IN_PERIOD_SIZE_DEFAULT 1024
++#define IN_PERIOD_COUNT_DEFAULT 16
+ #define IN_CHANNEL_MASK_DEFAULT AUDIO_CHANNEL_IN_MONO
+-#define IN_CHANNEL_COUNT_DEFAULT 1
++#define IN_CHANNEL_COUNT_DEFAULT 2
+ #define IN_RATE_DEFAULT 44100
+ 
+ #define IN_PCM_BUFFER_SIZE_DEFAULT \
+-- 
+2.47.0
+
diff --git a/source/devices/AM62X/android/Release_Specific_Release_Notes.rst b/source/devices/AM62X/android/Release_Specific_Release_Notes.rst
@@ -115,3 +115,8 @@ Known Issues
      - Some commands don't work from native console, but work via adb shell
      - N/A
      - N/A
+
+   * - `e2e 1410786 <https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1410786/sk-am62p-lp-analog-input-microphone-connected-to-3-5mm-jack-not-working>`_
+     - Analog Input Microphone connected to 3.5mm jack not working
+     - Apply :download:`this patch <0001-audio-update-default-value-for-audio-capture-in.patch>` in :file:`external/tinyhal`, `patch 1 <https://git.ti.com/cgit/android/device-ti-am62x/commit/?h=d-android14-release&id=15025d9dc1039469dd1260c837684edb17f991c1>`_ and `patch 2 <https://git.ti.com/cgit/android/device-ti-am62x/commit/?h=d-android14-release&id=61f86f096f71825df6665bb4e15110a5f5d74aea>`_ in :file:`device/ti/am62x`
+     - N/A
