Adding Wave spinner

[H999]

Hi, I just updated pip today and looked at the src saw it use spinner so pretty, and I was directed here by pip.
At the file rich_spinners.py I wondered why you don't have the wave spinner?

Adding in rich_spinners.py (with the original spirit of using standard library):

...
# MIT License
import itertools
import random

wave_frames=[''.join(item) for item in itertools.product('▁▂▃▄▅▆▇█', repeat=4) if len(set(item)) == 4]
random.shuffle(wave_frames)

SPINNERS = {
    "wave": {
        "interval": 120,
        "frames": wave_frames,
    },
...
}

and test with this:

from rich.progress import (
    BarColumn,
    Progress,
    ProgressColumn,
    SpinnerColumn,
    TextColumn,
    TimeRemainingColumn,
    DownloadColumn,
    FileSizeColumn,
    TimeElapsedColumn,
    TransferSpeedColumn,
)
import time


def test(style):
    total = 100
    step = 1
    columns = (
        TextColumn("test [progress.description]{task.description}"),
        TimeElapsedColumn(),
        BarColumn(),
        SpinnerColumn(spinner_name='wave', finished_text=f'[{style}]{{████}}', style=style),
        TextColumn("[progress.percentage]{task.percentage:>3.0f}%"),
        TextColumn("eta","[progress.percentage]"),
        TimeRemainingColumn(),
        DownloadColumn(),
        FileSizeColumn(),
        TransferSpeedColumn(),
    )
    progress = Progress(*columns, refresh_per_second=1000)
    task_id = progress.add_task(" ", total=total)
    with progress:
        for chunk in range(total):
            # yield chunk
            time.sleep(0.000000127)
            # if not chunk%1000:
            #     print(chunk)
            progress.update(task_id, advance=step)

test("green")

it look quite ok, like the music is playing

I think it will be nicer when you have it in core lib, so what do you think if you apply it

Note:
- When use itertools.product I think with 4 char is enough, larger is slower to process
- For future the wave spinner should have the random.shuffle where it used not init 1 time in rich_spinners.py

[willmcgugan]

Can I see a video?

[H999]

ok, here you are

Command.Prompt.-.cmd.-.py.2022-04-01.21-50-48.mp4

[willmcgugan]

Doesn't look that great TBH. Now if it was a sine wave, that might be more interesting.

[H999]

thanks, but if it is a sine wave I don't think it more interesting, because it will use the static frames don't have the random look like music play like this. How about the idea how do you think it good enough to have in main lib. If you want I will find the way to sort it to be sine wave

[H999]

you can try this with smooth sine wave

SPINNERS = {
    "wave_sine": {
        "interval": 120,
        "frames": ["▁▂▃▄", "▂▃▄▅", "▃▄▅▆", "▄▅▆▇", "▅▆▇█", "▆▇█▇", "▇█▇▆", "█▇▆▅", "▇▆▅▄", "▆▅▄▃", "▅▄▃▂", "▄▃▂▁", "▃▂▁▂", "▂▁▂▃"],
    },
...
}

Command.Prompt.-.cmd.-.py.2022-04-01.23-59-45.mp4

[willmcgugan]

I like that. Feel free to submit a PR.

[H999]

=]]]] maybe I keep both of them, I will submit a PR later

[H999]

hello @willmcgugan, I submitted a PR here.
After submitted, I found that src have spinner growVertical similar with wave have 1 size length but the frames not smooth much I think you should update the frames from "▁▃▄▅▆▇▆▅▄▃" to "▁▂▃▄▅▆▇█▇▆▅▄▃▂".
And I not sure where should I locate the def init the frames so I put it in rich_spinners.py because it do only 1 mission is init the waves frames, if you think somewhere else is better you can relocate it

[FedeClaudi]

The sine wave one is very cool, I might steal it for Term 😬

[H999]

=]]]]] Really, it would be my honor for my code to take part in your prj, don't be shy when use it because I think anybody can do it soon or late if they know code. If I push a PR to here, it mean I want to contribute and accept the MIT license, so just feel free to use it (except rich team don't want - but I don't think this situation will have 🤣).
ps: oh! you use the Julia, it very nice, I was planning to learn it but I don't have time, if have something to say about that is very derailed from the track 😅

[H999]

But really TBH, you are don't like the music wave like this. With me it awesome more than the sine wave.