Merge pull request #4617 from Textualize/heigh-zero

zero height renderables

Author: willmcgugan

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+
+### Changed
+
+- `get_content_height` will now return 0 if the renderable is Falsey https://github.com/Textualize/textual/pull/4617
+
 ## [0.65.2] - 2023-06-06
 
 ### Fixed

examples/code_browser.tcss

@@ -23,6 +23,7 @@ CodeBrowser.-show-tree #tree-view {
 #code-view {
     overflow: auto scroll;
     min-width: 100%;
+    hatch: right $primary;   
 }
 #code {
     width: auto;

src/textual/timer.py

@@ -118,7 +118,10 @@ async def stop_timer(timer: Timer) -> None:
             if timer._task is not None:
                 timer._active.set()
                 timer._task.cancel()
-                await timer._task
+                try:
+                    await timer._task
+                except CancelledError:
+                    pass
 
         await gather(*[stop_timer(timer) for timer in list(timers)])
 

src/textual/widget.py

@@ -1345,13 +1345,17 @@ def get_content_height(self, container: Size, viewport: Size, width: int) -> int
 
             renderable = self.render()
             if isinstance(renderable, Text):
-                height = len(
-                    renderable.wrap(
-                        self._console,
-                        width,
-                        no_wrap=renderable.no_wrap,
-                        tab_size=renderable.tab_size or 8,
+                height = (
+                    len(
+                        renderable.wrap(
+                            self._console,
+                            width,
+                            no_wrap=renderable.no_wrap,
+                            tab_size=renderable.tab_size or 8,
+                        )
                     )
+                    if renderable
+                    else 0
                 )
             else:
                 options = self._console.options.update_width(width).update(

src/textual/widgets/_label.py

@@ -10,5 +10,6 @@ class Label(Static):
     Label {
         width: auto;
         height: auto;
+        min-height: 1;
     }
     """