Merge pull request #6040 from Textualize/pretty-fix

fix for pretty

Author: willmcgugan

src/textual/widgets/_pretty.py

@@ -6,10 +6,10 @@
 
 from rich.pretty import Pretty as PrettyRenderable
 
-from textual.widget import Widget
+from textual.widgets import Static
 
 
-class Pretty(Widget):
+class Pretty(Static):
     """A pretty-printing widget.
 
     Used to pretty-print any object.
@@ -37,27 +37,13 @@ def __init__(
             id: The ID of the pretty in the DOM.
             classes: The CSS classes of the pretty.
         """
-        super().__init__(
-            name=name,
-            id=id,
-            classes=classes,
-        )
-        self._renderable = PrettyRenderable(object)
-
-    def render(self) -> PrettyRenderable:
-        """Render the pretty-printed object.
-
-        Returns:
-            The rendered pretty-print.
-        """
-        return self._renderable
+        super().__init__(name=name, id=id, classes=classes)
+        self.update(object)
 
     def update(self, object: Any) -> None:
         """Update the content of the pretty widget.
 
         Args:
             object: The object to pretty-print.
         """
-        self._renderable = PrettyRenderable(object)
-        self.clear_cached_dimensions()
-        self.refresh(layout=True)
+        super().update(PrettyRenderable(object))

tests/snapshot_tests/__snapshots__/test_snapshots/test_pretty_auto.svg

@@ -4538,3 +4538,35 @@ def compose(self) -> ComposeResult:
                 )
 
     assert snap_compare(StreamApp())
+
+
+def test_pretty_auto(snap_compare):
+    """Test that pretty works with auto dimensions.
+
+    You should see 'Hello World' including strings, 3 times in a purple box, top left.
+
+    """
+    from textual.widgets import Pretty
+
+    class Demo(App):
+        CSS = """
+        Vertical {
+            background: blue 30%;
+            height: auto;
+            width: auto;
+        }
+
+        Pretty {
+            width: auto;            
+            height: auto;
+            background: red 30%;
+        }
+        """
+
+        def compose(self) -> ComposeResult:
+            with Vertical():
+                yield Pretty("hello world")
+                yield Pretty("hello world")
+                yield Pretty("hello world")
+
+    assert snap_compare(Demo())