Merge pull request #5322 from Textualize/cp-disable

Cp disable

Author: willmcgugan

src/textual/widgets/_footer.py

@@ -207,9 +207,10 @@ def __init__(
     def compose(self) -> ComposeResult:
         if not self._bindings_ready:
             return
+        active_bindings = self.screen.active_bindings
         bindings = [
             (binding, enabled, tooltip)
-            for (_, binding, enabled, tooltip) in self.screen.active_bindings.values()
+            for (_, binding, enabled, tooltip) in active_bindings.values()
             if binding.show
         ]
         action_to_bindings: defaultdict[str, list[tuple[Binding, bool, str]]]
@@ -229,20 +230,22 @@ def compose(self) -> ComposeResult:
                 tooltip=tooltip,
             ).data_bind(Footer.compact)
         if self.show_command_palette and self.app.ENABLE_COMMAND_PALETTE:
-            for key, binding in self.app._bindings:
-                if binding.action in (
-                    "app.command_palette",
-                    "command_palette",
-                ):
-                    yield FooterKey(
-                        key,
-                        self.app.get_key_display(binding),
-                        binding.description,
-                        binding.action,
-                        classes="-command-palette",
-                        tooltip=binding.tooltip or binding.description,
-                    )
-                    break
+            try:
+                _node, binding, enabled, tooltip = active_bindings[
+                    self.app.COMMAND_PALETTE_BINDING
+                ]
+            except KeyError:
+                pass
+            else:
+                yield FooterKey(
+                    binding.key,
+                    self.app.get_key_display(binding),
+                    binding.description,
+                    binding.action,
+                    classes="-command-palette",
+                    disabled=not enabled,
+                    tooltip=binding.tooltip or binding.description,
+                )
 
     async def bindings_changed(self, screen: Screen) -> None:
         self._bindings_ready = True

tests/snapshot_tests/__snapshots__/test_snapshots/test_disable_command_palette.svg

@@ -2858,3 +2858,23 @@ async def run_before(pilot: Pilot) -> None:
         await pilot.click(Select)
 
     snap_compare(SelectApp(), run_before=run_before)
+
+
+def test_disable_command_palette(snap_compare):
+    """Test command palette may be disabled by check_action.
+    You should see a footer with an enabled binding, and the command palette binding greyed out."""
+
+    class FooterApp(App):
+        BINDINGS = [("b", "bell", "Bell")]
+
+        def compose(self) -> ComposeResult:
+            yield Footer()
+
+        def check_action(
+            self, action: str, parameters: tuple[object, ...]
+        ) -> bool | None:
+            if action == "command_palette":
+                return None
+            return True
+
+    snap_compare(FooterApp())