Skip to content

Commit 2ac0b60

Browse files
authored
Merge pull request #1181 from davep/bug/1175/missing-borders
Don't take transparent to imply not visible
2 parents 758b9a7 + 7213834 commit 2ac0b60

File tree

3 files changed

+259
-262
lines changed

3 files changed

+259
-262
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
3434

3535
- Fixed DataTable row not updating after add https://github.com/Textualize/textual/issues/1026
3636
- Fixed issues with animation. Now objects of different types may be animated.
37+
- Fixed containers with transparent background not showing borders https://github.com/Textualize/textual/issues/1175
3738

3839
## [0.4.0] - 2022-11-08
3940

src/textual/_compositor.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -633,11 +633,7 @@ def _get_renders(
633633
def is_visible(widget: Widget) -> bool:
634634
"""Return True if the widget is (literally) visible by examining various
635635
properties which affect whether it can be seen or not."""
636-
return (
637-
widget.visible
638-
and not widget.is_transparent
639-
and widget.styles.opacity > 0
640-
)
636+
return widget.visible and widget.styles.opacity > 0
641637

642638
_Region = Region
643639

0 commit comments

Comments
 (0)