possible optimization

willmcgugan · willmcgugan · commit 2e46624f7342 · 2025-06-01T10:35:53.000+01:00
diff --git a/src/textual/markup.py b/src/textual/markup.py
@@ -5,7 +5,7 @@
 
 from __future__ import annotations
 
-from operator import attrgetter
+from operator import itemgetter
 
 from textual.css.parse import substitute_references
 from textual.css.tokenizer import UnexpectedEnd
@@ -420,7 +420,7 @@ def process_text(template_text: str, /) -> str:
         ]
     )
     spans.reverse()
-    spans.sort(key=attrgetter("start"))
+    spans.sort(key=itemgetter(0))  # Zeroth item of Span is 'start' attribute
 
     content = Content(
         content_text,

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`
`6`	`6`	`from __future__ import annotations`
`7`	`7`
`8`		`-from operator import attrgetter`
	`8`	`+from operator import itemgetter`
`9`	`9`
`10`	`10`	`from textual.css.parse import substitute_references`
`11`	`11`	`from textual.css.tokenizer import UnexpectedEnd`
`@@ -420,7 +420,7 @@ def process_text(template_text: str, /) -> str:`
`420`	`420`	`]`
`421`	`421`	`)`
`422`	`422`	`spans.reverse()`
`423`		`- spans.sort(key=attrgetter("start"))`
	`423`	`+ spans.sort(key=itemgetter(0)) # Zeroth item of Span is 'start' attribute`
`424`	`424`
`425`	`425`	`content = Content(`
`426`	`426`	`content_text,`