changelog

Author: willmcgugan

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+
+## Changed
+
+- Fixed Select not scrolling highlight in to view when clicked https://github.com/Textualize/textual/issues/5255
+
 ## [0.88.1] - 2024-11-30
 
 ### Fixed

src/textual/widgets/_option_list.py

@@ -880,6 +880,7 @@ def scroll_to_highlight(self, top: bool = False) -> None:
             top: Scroll highlight to top of the list.
         """
         highlighted = self.highlighted
+
         if highlighted is None or not self.is_mounted:
             return
 

tests/snapshot_tests/test_snapshots.py

@@ -2843,9 +2843,8 @@ def action_add_pane(self) -> None:
     snap_compare(ExampleApp(), press=["a", "r", "a"])
 
 
-def test_click_expand_select(snap_compare):
-    """Regression test for https://github.com/Textualize/textual/issues/5255
-    Should show a select with 15 highlighted."""
+def test_click_expand(snap_compare):
+    """Should show an expanded select with 15 highlighted."""
 
     class SelectApp(App):
         def compose(self) -> ComposeResult: