Merge pull request #5730 from TomJGooding/fix-option-list-fix-size-when-options-removed

fix(option list): fix size when options removed or cleared

Author: willmcgugan

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed markup escaping edge cases https://github.com/Textualize/textual/pull/5697
 - Fixed incorrect auto height in Collapsible https://github.com/Textualize/textual/pull/5703
 - Fixed issue with keymaps and single-letter keys https://github.com/Textualize/textual/pull/5726
+- Fixed `OptionList` size after removing or clearing options https://github.com/Textualize/textual/issues/5728
 - Fixed footer / key panel not updating when keymaps are applied https://github.com/Textualize/textual/pull/5724
 - Fixed alignment not being applied when there are min and max limits on dimensions https://github.com/Textualize/textual/pull/5732
 

src/textual/widgets/_option_list.py

@@ -534,7 +534,7 @@ def _remove_option(self, option: Option) -> Self:
             del self._id_to_option[option._id]
         del self._option_to_index[option]
         self.highlighted = self.highlighted
-        self.refresh()
+        self._clear_caches()
         return self
 
     def _pre_remove_option(self, option: Option, index: int) -> None:
@@ -759,8 +759,7 @@ def _get_option_render(self, option: Option, style: Style) -> list[Strip]:
 
     def _update_lines(self) -> None:
         """Update internal structures when new lines are added."""
-        if not self.options or not self.scrollable_content_region:
-            # No options -- nothing to
+        if not self.scrollable_content_region:
             return
 
         line_cache = self._line_cache