snapshots

Author: willmcgugan

CHANGELOG.md

@@ -20,11 +20,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Added `OptionList.set_options` https://github.com/Textualize/textual/pull/6048
 - Added `TextArea.suggestion` https://github.com/Textualize/textual/pull/6048
 - Added `TextArea.placeholder` https://github.com/Textualize/textual/pull/6048
+- Added `Widget.get_line_filters`
 
 ### Changed
 
 - Breaking change: The `renderable` property on the `Static` widget has been changed to `content`. https://github.com/Textualize/textual/pull/6041
 - Breaking change: Renamed `Label` constructor argument `renderable` to `content` for consistency https://github.com/Textualize/textual/pull/6045
+- Breaking change: Optimization to line API to avoid applying background styles to widget content. In practice this means that you can no longer rely on blank Segments automatically getting the background color.
 
 # [5.3.0] - 2025-08-07
 

src/textual/_styles_cache.py

@@ -108,15 +108,15 @@ def render_widget(self, widget: Widget, crop: Region) -> list[Strip]:
         border_title = widget._border_title
         border_subtitle = widget._border_subtitle
 
-        base_background, background = widget._opacity_background_colors
+        base_background, background = widget.background_colors
         styles = widget.styles
         strips = self.render(
             styles,
             widget.region.size,
             base_background,
             background,
             widget.render_line,
-            widget.app._enabled_filters,
+            widget.get_line_filters(),
             (
                 None
                 if border_title is None
@@ -417,7 +417,7 @@ def post(segments: Iterable[Segment]) -> Iterable[Segment]:
         elif (pad_top and y < gutter.top) or (
             pad_bottom and y >= height - gutter.bottom
         ):
-            background_rich_style = from_color(bgcolor=background.rich_color)
+            background_rich_style = inner.rich_style
             left_style = Style(
                 foreground=base_background + border_left_color.multiply_alpha(opacity)
             )
@@ -444,8 +444,6 @@ def post(segments: Iterable[Segment]) -> Iterable[Segment]:
             else:
                 line = Strip.blank(content_width, inner.rich_style)
 
-            if inner:
-                line = Segment.apply_style(line, inner.rich_style)
             if (text_opacity := styles.text_opacity) != 1.0:
                 line = TextOpacity.process_segments(line, text_opacity, ansi_theme)
             line = line_post(line_pad(line, pad_left, pad_right, inner.rich_style))

src/textual/dom.py

@@ -1144,22 +1144,22 @@ def _get_subtitle_style_information(
             VisualStyle.from_rich_style(styles.border_subtitle_style),
         )
 
-    @property
-    def background_colors(self) -> tuple[Color, Color]:
-        """The background color and the color of the parent's background.
-
-        Returns:
-            `(<background color>, <color>)`
-        """
-        base_background = background = BLACK
-        for node in reversed(self.ancestors_with_self):
-            styles = node.styles
-            base_background = background
-            background += styles.background.tint(styles.background_tint)
-        return (base_background, background)
+    # @property
+    # def background_colors(self) -> tuple[Color, Color]:
+    #     """The background color and the color of the parent's background.
+
+    #     Returns:
+    #         `(<background color>, <color>)`
+    #     """
+    #     base_background = background = BLACK
+    #     for node in reversed(self.ancestors_with_self):
+    #         styles = node.styles
+    #         base_background = background
+    #         background += styles.background.tint(styles.background_tint)
+    #     return (base_background, background)
 
     @property
-    def _opacity_background_colors(self) -> tuple[Color, Color]:
+    def background_colors(self) -> tuple[Color, Color]:
         """Background colors adjusted for opacity.
 
         Returns:

src/textual/scrollbar.py

@@ -287,7 +287,7 @@ def render(self) -> RenderableType:
             background = styles.scrollbar_background
             color = styles.scrollbar_color
         if background.a < 1:
-            base_background, _ = self.parent._opacity_background_colors
+            base_background, _ = self.parent.background_colors
             background = base_background + background
         color = background + color
         scrollbar_style = Style.from_color(color.rich_color, background.rich_color)

src/textual/widget.py

@@ -94,6 +94,7 @@
 if TYPE_CHECKING:
     from textual.app import App, ComposeResult
     from textual.css.query import QueryType
+    from textual.filter import LineFilter
     from textual.message_pump import MessagePump
     from textual.scrollbar import (
         ScrollBar,
@@ -674,6 +675,14 @@ def text_selection(self) -> Selection | None:
         """Text selection information, or `None` if no text is selected in this widget."""
         return self.screen.selections.get(self, None)
 
+    def get_line_filters(self) -> Sequence[LineFilter]:
+        """Get the line filters enabled for this widget.
+
+        Returns:
+            A sequence of LineFilter instances.
+        """
+        return self.app._enabled_filters
+
     def preflight_checks(self) -> None:
         """Called in debug mode to do preflight checks.
 
@@ -4088,7 +4097,7 @@ def render_line(self, y: int) -> Strip:
         try:
             line = self._render_cache.lines[y]
         except IndexError:
-            line = Strip.blank(self.size.width, self.rich_style)
+            line = Strip.blank(self.size.width, self.visual_style.rich_style)
 
         return line
 

src/textual/widgets/_input.py

@@ -601,7 +601,7 @@ def is_valid(self) -> bool:
 
     def render_line(self, y: int) -> Strip:
         if y != 0:
-            return Strip.blank(self.size.width)
+            return Strip.blank(self.size.width, self.rich_style)
 
         console = self.app.console
         console_options = self.app.console_options

src/textual/widgets/_masked_input.py

@@ -553,7 +553,7 @@ def set_classes() -> None:
 
     def render_line(self, y: int) -> Strip:
         if y != 0:
-            return Strip.blank(self.size.width)
+            return Strip.blank(self.size.width, self.rich_style)
 
         result = self._value
         width = self.content_size.width

src/textual/widgets/_option_list.py

@@ -875,7 +875,10 @@ def render_line(self, y: int) -> Strip:
             option_index, line_offset = self._lines[line_number]
             option = self.options[option_index]
         except IndexError:
-            return Strip.blank(self.scrollable_content_region.width)
+            return Strip.blank(
+                self.scrollable_content_region.width,
+                self.get_visual_style("option-list--option").rich_style,
+            )
 
         mouse_over = self._mouse_hovering_over == option_index
         component_class = ""
@@ -895,7 +898,10 @@ def render_line(self, y: int) -> Strip:
         try:
             strip = strips[line_offset]
         except IndexError:
-            return Strip.blank(self.scrollable_content_region.width)
+            return Strip.blank(
+                self.scrollable_content_region.width,
+                self.get_visual_style("option-list--option").rich_style,
+            )
         return strip
 
     def validate_highlighted(self, highlighted: int | None) -> int | None:

src/textual/widgets/_text_area.py

@@ -1264,6 +1264,11 @@ def _render_line(self, y: int) -> Strip:
             A rendered line.
         """
         theme = self._theme
+        base_style = (
+            theme.base_style
+            if theme and theme.base_style is not None
+            else self.rich_style
+        )
 
         wrapped_document = self.wrapped_document
         scroll_x, scroll_y = self.scroll_offset
@@ -1275,7 +1280,7 @@ def _render_line(self, y: int) -> Strip:
         out_of_bounds = y_offset >= wrapped_document.height
 
         if out_of_bounds:
-            return Strip.blank(self.size.width)
+            return Strip.blank(self.size.width, base_style)
 
         # Get the line corresponding to this offset
         try:
@@ -1284,7 +1289,7 @@ def _render_line(self, y: int) -> Strip:
             line_info = None
 
         if line_info is None:
-            return Strip.blank(self.size.width)
+            return Strip.blank(self.size.width, base_style)
 
         line_index, section_offset = line_info
 
@@ -1474,11 +1479,7 @@ def _render_line(self, y: int) -> Strip:
         text_strip = text_strip.extend_cell_length(target_width, line_style)
         strip = Strip.join([Strip(gutter, cell_length=gutter_width), text_strip])
 
-        return strip.apply_style(
-            theme.base_style
-            if theme and theme.base_style is not None
-            else self.rich_style
-        )
+        return strip.apply_style(base_style)
 
     @property
     def text(self) -> str: