absolute offset public

Author: willmcgugan

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 
 - Digits are now thin by default, style with text-style: bold to get bold digits https://github.com/Textualize/textual/pull/5094
+- Made `Widget.absolute_offset` public https://github.com/Textualize/textual/pull/5097
 
 ## [0.82.0] - 2024-10-03
 

src/textual/_compositor.py

@@ -557,8 +557,8 @@ def _constrain(
 
         region = region.translate_inside(
             constrain_region.shrink(styles.margin),
-            constrain_x == "inside",
-            constrain_y == "inside",
+            constrain_x != "none",
+            constrain_y != "none",
         )
 
         return region
@@ -697,13 +697,12 @@ def add_widget(
 
                         widget_order = order + ((layer_index, z, layer_order),)
 
-                        if overlay and (
-                            sub_widget.styles.constrain_x != "none"
-                            or sub_widget.styles.constrain_y != "none"
-                        ):
-                            widget_region = self._constrain(
-                                sub_widget.styles, widget_region, no_clip
-                            )
+                        if overlay:
+                            has_rule = sub_widget.styles.has_rule
+                            if has_rule("constrain_x") or has_rule("constrain_y"):
+                                widget_region = self._constrain(
+                                    sub_widget.styles, widget_region, no_clip
+                                )
 
                         if widget._cover_widget is None:
                             add_widget(
@@ -752,16 +751,16 @@ def add_widget(
 
                 widget_region = region + layout_offset
 
-                if widget._absolute_offset is not None:
+                if widget.absolute_offset is not None:
                     margin = styles.margin
                     widget_region = widget_region.reset_offset.translate(
-                        widget._absolute_offset + margin.top_left
+                        widget.absolute_offset + margin.top_left
                     )
                     widget_region = widget_region.translate(
                         styles.offset.resolve(widget_region.grow(margin).size, size)
                     )
-
-                if styles.constrain_x != "none" or styles.constrain_y != "none":
+                has_rule = styles.has_rule
+                if has_rule("constrain_x") or has_rule("constrain_y"):
                     widget_region = self._constrain(styles, widget_region, no_clip)
 
                 map[widget._render_widget] = _MapGeometry(

src/textual/css/_styles_builder.py

@@ -1066,7 +1066,7 @@ def process_constrain(self, name: str, tokens: list[Token]) -> None:
             self.styles._rules["constrain_x"] = constrain_x  # type: ignore
             self.styles._rules["constrain_y"] = constrain_y  # type: ignore
         else:
-            self.error(name, tokens[0], "one or two values here")
+            self.error(name, tokens[0], "one or two values expected here")
 
     def process_constrain_x(self, name: str, tokens: list[Token]) -> None:
         try:

src/textual/screen.py

@@ -1278,7 +1278,7 @@ def _handle_tooltip_timer(self, widget: Widget) -> None:
                 tooltip.display = False
             else:
                 tooltip.display = True
-                tooltip._absolute_offset = self.app.mouse_position
+                tooltip.absolute_offset = self.app.mouse_position
                 tooltip.update(tooltip_content)
 
     def _handle_mouse_move(self, event: events.MouseMove) -> None:

src/textual/widget.py

@@ -422,7 +422,7 @@ def __init__(
 
         self._tooltip: RenderableType | None = None
         """The tooltip content."""
-        self._absolute_offset: Offset | None = None
+        self.absolute_offset: Offset | None = None
         """Force an absolute offset for the widget (used by tooltips)."""
 
         self._scrollbar_changes: set[tuple[bool, bool]] = set()

src/textual/widgets/_tooltip.py

@@ -8,7 +8,6 @@ class Tooltip(Static, inherit_css=False):
     Tooltip {
         layer: _tooltips;
         margin: 1 2;
-
         padding: 1 2;
         background: $background;
         width: auto;

tests/snapshot_tests/snapshot_apps/tooltips.py

@@ -4,6 +4,7 @@
 
 class TooltipApp(App[None]):
     TOOLTIP_DELAY = 0.4
+
     def compose(self) -> ComposeResult:
         progress_bar = ProgressBar(100, show_eta=False)
         progress_bar.advance(10)