Merge branch 'main' into windows-logging

Author: willmcgugan

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,6 +1,6 @@
 ---
-name: Bug report
-about: Create a report to help us improve
+name: Report a bug
+about: Report a crash or something not working as described in the docs
 title: ''
 labels: ''
 assignees: ''
@@ -11,14 +11,18 @@ Have you checked closed issues? (https://github.com/Textualize/textual/issues?q=
 
 Have you checked against the most recent version of Textual? (https://pypi.org/search/?q=textual)
 
-## Feature requests
+## Consider discussions!
 
-Please post feature requests to Ideas. (https://github.com/Textualize/textual/discussions/categories/ideas)
+Issues are for actionable items only.
+If Textual crashes or behaves differently from the docs, then submit an issue.
+If you want to know how to do something, or you have a suggestion for a new feature, then open a discussion (https://github.com/Textualize/textual/discussions/).
 
+For realtime help, join our discord server (https://discord.gg/Enf6Z3qhVr)
 
 ## The bug
 
-Please give a brief but clear explanation of the issue. If you can, include a complete working example that demonstrates the bug. **Check it can run without modifications.**
+Please give a brief but clear explanation of the issue.
+If you can, include a complete working example that demonstrates the bug. **Check it can run without modifications.**
 
 It will be helpful if you run the following command and paste the results:
 

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,8 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Get help or request a feature
+    url: https://github.com/Textualize/textual/discussions
+    about: Discussions are best for getting feedback
+  - name: Chat to Textual devs
+    url : https://discord.gg/Enf6Z3qhVr
+    about: Join our Discord server for realtime assistance

.github/ISSUE_TEMPLATE/task.md

@@ -5,12 +5,27 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+
 ## Unreleased
 
+### Added 
+
+- Added `compact` parameter to `MaskedInput` https://github.com/Textualize/textual/pull/5952
+
 ### Fixed
 
+- Fixed `query_one` and `query_exactly_one` not raising documented `WrongType` exception.
 - Fixed logging to a file on Windows https://github.com/Textualize/textual/issues/5941
 
+### Changed
+
+- Breaking change: `Widget.anchor` now has different semantics. It should be applied to a container and anchors to the bottom of the scroll position. https://github.com/Textualize/textual/pull/5950
+
+### Added
+
+- Added `Markdown.append` https://github.com/Textualize/textual/pull/5950
+- Added `Widget.release_anchor` https://github.com/Textualize/textual/pull/5950
+
 ## [3.7.1] - 2025-07-09
 
 ### Fixed

CHANGELOG.md

@@ -74,6 +74,7 @@ def compose(self) -> ComposeResult:
     def on_mount(self) -> None:
         """You might want to change the model if you don't have access to it."""
         self.model = llm.get_model("gpt-4o")
+        self.query_one("#chat-view").anchor()
 
     @on(Input.Submitted)
     async def on_input(self, event: Input.Submitted) -> None:
@@ -82,8 +83,6 @@ async def on_input(self, event: Input.Submitted) -> None:
         event.input.clear()
         await chat_view.mount(Prompt(event.value))
         await chat_view.mount(response := Response())
-        response.anchor()
-
         self.send_prompt(event.value, response)
 
     @work(thread=True)

examples/mother.py

@@ -36,12 +36,12 @@
 from textual.geometry import NULL_SPACING, Offset, Region, Size, Spacing
 from textual.map_geometry import MapGeometry
 from textual.strip import Strip, StripRenderable
+from textual.widget import Widget
 
 if TYPE_CHECKING:
     from typing_extensions import TypeAlias
 
     from textual.screen import Screen
-    from textual.widget import Widget
 
 
 class ReflowResult(NamedTuple):
@@ -605,6 +605,18 @@ def add_widget(
                     # Get the region that will be updated
                     sub_clip = clip.intersection(child_region)
 
+                    if widget._anchored and not widget._anchor_released:
+                        scroll_y = widget.scroll_y
+                        new_scroll_y = (
+                            arrange_result.spatial_map.total_region.bottom
+                            - (
+                                widget.container_size.height
+                                - widget.scrollbar_size_horizontal
+                            )
+                        )
+                        widget.set_reactive(Widget.scroll_y, new_scroll_y)
+                        widget.watch_scroll_y(scroll_y, new_scroll_y)
+
                     if visible_only:
                         placements = arrange_result.get_visible_placements(
                             sub_clip - child_region.offset + widget.scroll_offset

src/textual/_compositor.py

@@ -18,7 +18,7 @@
 # to be unsuccessful?
 _MAX_SEQUENCE_SEARCH_THRESHOLD = 32
 
-_re_mouse_event = re.compile("^" + re.escape("\x1b[") + r"(<?[-?\d;]+[mM]|M...)\Z")
+_re_mouse_event = re.compile("^" + re.escape("\x1b[") + r"(<?[-\d;]+[mM]|M...)\Z")
 _re_terminal_mode_response = re.compile(
     "^" + re.escape("\x1b[") + r"\?(?P<mode_id>\d+);(?P<setting_parameter>\d)\$y"
 )
@@ -50,7 +50,7 @@
 
 
 class XTermParser(Parser[Message]):
-    _re_sgr_mouse = re.compile(r"\x1b\[<(-?\d+);(-?\d+);(-?\d+)([Mm])")
+    _re_sgr_mouse = re.compile(r"\x1b\[<(\d+);(-?\d+);(-?\d+)([Mm])")
 
     def __init__(self, debug: bool = False) -> None:
         self.last_x = 0.0

src/textual/_xterm_parser.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import dataclasses
+import re
 from functools import lru_cache
 from typing import Iterable, Iterator, NoReturn
 
@@ -16,7 +17,13 @@
     SelectorType,
 )
 from textual.css.styles import Styles
-from textual.css.tokenize import Token, tokenize, tokenize_declarations, tokenize_values
+from textual.css.tokenize import (
+    IDENTIFIER,
+    Token,
+    tokenize,
+    tokenize_declarations,
+    tokenize_values,
+)
 from textual.css.tokenizer import ReferencedBy, UnexpectedEnd
 from textual.css.types import CSSLocation, Specificity3
 from textual.suggestions import get_suggestion
@@ -33,6 +40,21 @@
     "nested": (SelectorType.NESTED, (0, 0, 0)),
 }
 
+RE_ID_SELECTOR = re.compile("#" + IDENTIFIER)
+
+
+@lru_cache(maxsize=128)
+def is_id_selector(selector: str) -> bool:
+    """Is the selector a single ID selector, i.e. "#foo"?
+
+    Args:
+        selector: A CSS selector.
+
+    Returns:
+        `True` if the selector is a simple ID selector, otherwise `False`.
+    """
+    return RE_ID_SELECTOR.fullmatch(selector) is not None
+
 
 def _add_specificity(
     specificity1: Specificity3, specificity2: Specificity3

src/textual/css/parse.py

@@ -242,7 +242,7 @@ def first(
             if expect_type is not None:
                 if not isinstance(first, expect_type):
                     raise WrongType(
-                        f"Query value is wrong type; expected {expect_type}, got {type(first)}"
+                        f"Query value is the wrong type; expected type {expect_type.__name__!r}, found {first}"
                     )
             return first
         else:
@@ -324,7 +324,7 @@ def last(
         last = self.nodes[-1]
         if expect_type is not None and not isinstance(last, expect_type):
             raise WrongType(
-                f"Query value is wrong type; expected {expect_type}, got {type(last)}"
+                f"Query value is the wrong type; expected type {expect_type.__name__!r}, found {last}"
             )
         return last
 

src/textual/css/query.py

@@ -40,16 +40,16 @@
 from textual.css.constants import VALID_DISPLAY, VALID_VISIBILITY
 from textual.css.errors import DeclarationError, StyleValueError
 from textual.css.match import match
-from textual.css.parse import parse_declarations, parse_selectors
-from textual.css.query import InvalidQueryFormat, NoMatches, TooManyMatches
+from textual.css.parse import is_id_selector, parse_declarations, parse_selectors
+from textual.css.query import InvalidQueryFormat, NoMatches, TooManyMatches, WrongType
 from textual.css.styles import RenderStyles, Styles
 from textual.css.tokenize import IDENTIFIER
 from textual.css.tokenizer import TokenError
 from textual.message_pump import MessagePump
 from textual.reactive import Reactive, ReactiveError, _Mutated, _watch
 from textual.style import Style as VisualStyle
 from textual.timer import Timer
-from textual.walk import walk_breadth_first, walk_depth_first
+from textual.walk import walk_breadth_first, walk_breadth_search_id, walk_depth_first
 from textual.worker_manager import WorkerManager
 
 if TYPE_CHECKING:
@@ -65,9 +65,6 @@
     from textual.widget import Widget
     from textual.worker import Worker, WorkType, ResultType
 
-    # Unused & ignored imports are needed for the docs to link to these objects:
-    from textual.css.query import WrongType  # type: ignore  # noqa: F401
-
 from typing_extensions import Literal
 
 _re_identifier = re.compile(IDENTIFIER)
@@ -1469,6 +1466,24 @@ def query_one(
         else:
             query_selector = selector.__name__
 
+        if is_id_selector(query_selector):
+            cache_key = (base_node._nodes._updates, query_selector, expect_type)
+            cached_result = base_node._query_one_cache.get(cache_key)
+            if cached_result is not None:
+                return cached_result
+            if (
+                node := walk_breadth_search_id(
+                    base_node, query_selector[1:], with_root=False
+                )
+            ) is not None:
+                if expect_type is not None and not isinstance(node, expect_type):
+                    raise WrongType(
+                        f"Node matching {query_selector!r} is the wrong type; expected type {expect_type.__name__!r}, found {node}"
+                    )
+                base_node._query_one_cache[cache_key] = node
+                return node
+            raise NoMatches(f"No nodes match {query_selector!r} on {base_node!r}")
+
         try:
             selector_set = parse_selectors(query_selector)
         except TokenError:
@@ -1488,12 +1503,14 @@ def query_one(
             if not match(selector_set, node):
                 continue
             if expect_type is not None and not isinstance(node, expect_type):
-                continue
+                raise WrongType(
+                    f"Node matching {query_selector!r} is the wrong type; expected type {expect_type.__name__!r}, found {node}"
+                )
             if cache_key is not None:
                 base_node._query_one_cache[cache_key] = node
             return node
 
-        raise NoMatches(f"No nodes match {selector!r} on {self!r}")
+        raise NoMatches(f"No nodes match {query_selector!r} on {base_node!r}")
 
     if TYPE_CHECKING:
 
@@ -1561,19 +1578,19 @@ def query_exactly_one(
             if not match(selector_set, node):
                 continue
             if expect_type is not None and not isinstance(node, expect_type):
-                continue
+                raise WrongType(
+                    f"Node matching {query_selector!r} is the wrong type; expected type {expect_type.__name__!r}, found {node}"
+                )
             for later_node in iter_children:
                 if match(selector_set, later_node):
-                    if expect_type is not None and not isinstance(node, expect_type):
-                        continue
                     raise TooManyMatches(
                         "Call to query_one resulted in more than one matched node"
                     )
             if cache_key is not None:
                 base_node._query_one_cache[cache_key] = node
             return node
 
-        raise NoMatches(f"No nodes match {selector!r} on {self!r}")
+        raise NoMatches(f"No nodes match {query_selector!r} on {base_node!r}")
 
     if TYPE_CHECKING: