Merge pull request #4606 from Textualize/hatch-fix

hatch hotfix

Author: willmcgugan

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.65.1] - 2024-06-05
+
+### Fixed
+
+- Fixed hot reloading with hatch rule https://github.com/Textualize/textual/pull/4606
+- Fixed hatch style parsing https://github.com/Textualize/textual/pull/4606
+
 ## [0.65.0] - 2024-06-05
 
 ### Added
@@ -2062,6 +2069,7 @@ https://textual.textualize.io/blog/2022/11/08/version-040/#version-040
 - New handler system for messages that doesn't require inheritance
 - Improved traceback handling
 
+[0.65.1]: https://github.com/Textualize/textual/compare/v0.65.0...v0.65.1
 [0.65.0]: https://github.com/Textualize/textual/compare/v0.64.0...v0.65.0
 [0.64.0]: https://github.com/Textualize/textual/compare/v0.63.6...v0.64.0
 [0.63.6]: https://github.com/Textualize/textual/compare/v0.63.5...v0.63.6

docs/examples/styles/hatch.tcss

@@ -1,6 +1,7 @@
 .hatch {
     height: 1fr;
     border: solid $secondary;
+  
     &.cross {
         hatch: cross $success;
     }

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "textual"
-version = "0.65.0"
+version = "0.65.1"
 homepage = "https://github.com/Textualize/textual"
 repository = "https://github.com/Textualize/textual"
 documentation = "https://textual.textualize.io/"

src/textual/css/_style_properties.py

@@ -1148,7 +1148,11 @@ class HatchProperty:
     def __get__(self, obj: StylesBase, type: type[StylesBase]) -> tuple[str, Color]:
         return cast("tuple[str, Color]", obj.get_rule("hatch", (" ", TRANSPARENT)))
 
-    def __set__(self, obj: StylesBase, value: tuple[str, Color | str]) -> None:
+    def __set__(self, obj: StylesBase, value: tuple[str, Color | str] | None) -> None:
+        _rich_traceback_omit = True
+        if value is None:
+            obj.clear_rule("hatch")
+            return
         character, color = value
         if len(character) != 1:
             try:

src/textual/css/_styles_builder.py

@@ -1058,51 +1058,73 @@ def process_constrain(self, name: str, tokens: list[Token]) -> None:
             self.styles._rules[name] = value  # type: ignore
 
     def process_hatch(self, name: str, tokens: list[Token]) -> None:
-        character = " "
+        if not tokens:
+            return
+        character: str | None = None
         color = TRANSPARENT
         opacity = 1.0
 
-        for token in tokens:
-            if token.name == "token":
-                if token.value not in VALID_HATCH:
-                    self.error(
-                        name,
-                        tokens[0],
-                        string_enum_help_text(name, VALID_HATCH, context="css"),
-                    )
-                character = HATCHES[token.value]
-            elif token.name == "string":
-                character = token.value[1:-1]
-                if len(character) != 1:
-                    self.error(
-                        name,
-                        token,
-                        f"Hatch requires a string of length 1; got {token.value}",
-                    )
-                if cell_len(character) != 1:
-                    self.error(
-                        name,
-                        token,
-                        f"Hatch requires a string with a *cell length* of 1; got {token.value}",
-                    )
-            elif token.name == "color":
-                try:
-                    color = Color.parse(token.value)
-                except Exception as error:
-                    self.error(
-                        name,
-                        token,
-                        color_property_help_text(name, context="css", error=error),
-                    )
-            elif token.name == "scalar":
-                opacity_scalar = opacity = Scalar.parse(token.value)
+        if len(tokens) not in (2, 3):
+            self.error(name, tokens[0], "2 or 3 values expected here")
+
+        character_token, color_token, *opacity_tokens = tokens
+
+        if character_token.name == "token":
+            if character_token.value not in VALID_HATCH:
+                self.error(
+                    name,
+                    tokens[0],
+                    string_enum_help_text(name, VALID_HATCH, context="css"),
+                )
+            character = HATCHES[character_token.value]
+        elif character_token.name == "string":
+            character = character_token.value[1:-1]
+            if len(character) != 1:
+                self.error(
+                    name,
+                    character_token,
+                    f"Hatch type requires a string of length 1; got {character_token.value}",
+                )
+            if cell_len(character) != 1:
+                self.error(
+                    name,
+                    character_token,
+                    f"Hatch type requires a string with a *cell length* of 1; got {character_token.value}",
+                )
+
+        if color_token.name in ("color", "token"):
+            try:
+                color = Color.parse(color_token.value)
+            except Exception as error:
+                self.error(
+                    name,
+                    color_token,
+                    color_property_help_text(name, context="css", error=error),
+                )
+        else:
+            self.error(
+                name, color_token, f"Expected a color; found {color_token.value!r}"
+            )
+
+        if opacity_tokens:
+            opacity_token = opacity_tokens[0]
+            if opacity_token.name == "scalar":
+                opacity_scalar = opacity = Scalar.parse(opacity_token.value)
                 if opacity_scalar.unit != Unit.PERCENT:
                     self.error(
-                        name, token, "hatch alpha must be given as a percentage."
+                        name,
+                        opacity_token,
+                        "hatch alpha must be given as a percentage.",
                     )
                 opacity = clamp(opacity_scalar.value / 100.0, 0, 1.0)
+            else:
+                self.error(
+                    name,
+                    opacity_token,
+                    f"expected a percentage here; found {opacity_token.value!r}",
+                )
 
-        self.styles._rules[name] = (character, color.multiply_alpha(opacity))
+        self.styles._rules[name] = (character or " ", color.multiply_alpha(opacity))
 
     def _get_suggested_property_name_for_rule(self, rule_name: str) -> str | None:
         """

tests/snapshot_tests/__snapshots__/test_snapshots.ambr

@@ -6,7 +6,7 @@
 class HatchApp(App):
     CSS = """
     Screen {
-        hatch: right $primary;
+        hatch: right slateblue;
     }
     #one {
         hatch: left $success;