microoptimizations

Author: willmcgugan

src/textual/app.py

@@ -776,6 +776,11 @@ def is_dom_root(self) -> bool:
         """Is this a root node (i.e. the App)?"""
         return True
 
+    @property
+    def is_attached(self) -> bool:
+        """Is this node linked to the app through the DOM?"""
+        return True
+
     @property
     def debug(self) -> bool:
         """Is debug mode enabled?"""

src/textual/dom.py

@@ -746,8 +746,7 @@ def css_path_nodes(self) -> list[DOMNode]:
         append = result.append
 
         node: DOMNode = self
-        while isinstance(node._parent, DOMNode):
-            node = node._parent
+        while isinstance((node := node._parent), DOMNode):
             append(node)
         return result[::-1]
 
@@ -1078,12 +1077,11 @@ def ancestors_with_self(self) -> list[DOMNode]:
         Returns:
             A list of nodes.
         """
-        nodes: list[MessagePump | None] = []
+        nodes: list[MessagePump | None] = [self]
         add_node = nodes.append
         node: MessagePump | None = self
-        while node is not None:
+        while (node := node._parent) is not None:
             add_node(node)
-            node = node._parent
         return cast("list[DOMNode]", nodes)
 
     @property
@@ -1093,7 +1091,12 @@ def ancestors(self) -> list[DOMNode]:
         Returns:
             A list of nodes.
         """
-        return self.ancestors_with_self[1:]
+        nodes: list[MessagePump | None] = []
+        add_node = nodes.append
+        node: MessagePump | None = self
+        while (node := node._parent) is not None:
+            add_node(node)
+        return cast("list[DOMNode]", nodes)
 
     @property
     def displayed_children(self) -> list[Widget]:

src/textual/message_pump.py

@@ -247,8 +247,6 @@ def app(self) -> "App[object]":
     @property
     def is_attached(self) -> bool:
         """Is this node linked to the app through the DOM?"""
-        if self.is_dom_root:
-            return True
         node: MessagePump | None = self
         while (node := node._parent) is not None:
             if node.is_dom_root:

src/textual/walk.py

@@ -65,14 +65,13 @@ def walk_depth_first(
     if with_root and isinstance(root, check_type):
         yield root
     while stack:
-        node = next(stack[-1], None)
-        if node is None:
+        if (node := next(stack[-1], None)) is None:
             pop()
         else:
             if isinstance(node, check_type):
                 yield node
-            if node.children:
-                push(iter(node.children))
+            if children := node._nodes:
+                push(iter(children))
 
 
 @overload
@@ -127,4 +126,4 @@ def walk_breadth_first(
         node = popleft()
         if isinstance(node, check_type):
             yield node
-        extend(node.children)
+        extend(node._nodes)