Merge pull request #4842 from Textualize/crop-size

remove clip_size

Author: willmcgugan

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 
 - Input cursor will no longer jump to the end on focus https://github.com/Textualize/textual/pull/4773
+- Removed `Size.cip_size`, which was a clone of `crop_size`
 
 ### Fixed
 

src/textual/geometry.py

@@ -627,19 +627,6 @@ def expand(self, size: tuple[int, int]) -> Region:
             height + expand_height * 2,
         )
 
-    def clip_size(self, size: tuple[int, int]) -> Region:
-        """Clip the size to fit within minimum values.
-
-        Args:
-            size: Maximum width and height.
-
-        Returns:
-            New region.
-        """
-        x, y, width, height = self
-        max_width, max_height = size
-        return Region(x, y, min(width, max_width), min(height, max_height))
-
     @lru_cache(maxsize=1024)
     def overlaps(self, other: Region) -> bool:
         """Check if another region overlaps this region.

src/textual/layouts/grid.py

@@ -253,7 +253,7 @@ def apply_height_limits(widget: Widget, height: int) -> int:
             )
             region = (
                 Region(x, y, int(width + margin.width), int(height + margin.height))
-                .clip_size(cell_size)
+                .crop_size(cell_size)
                 .shrink(margin)
             )
             add_placement(

tests/test_geometry.py

@@ -210,10 +210,6 @@ def test_crop_size():
     assert Region(10, 20, 100, 200).crop_size((500, 40)) == Region(10, 20, 100, 40)
 
 
-def test_clip_size():
-    assert Region(10, 10, 100, 80).clip_size((50, 100)) == Region(10, 10, 50, 80)
-
-
 def test_region_overlaps():
     assert Region(10, 10, 30, 20).overlaps(Region(0, 0, 20, 20))
     assert not Region(10, 10, 5, 5).overlaps(Region(15, 15, 20, 20))