Logging file delivery error

Author: darrenburns

src/textual/driver.py

@@ -7,7 +7,7 @@
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, BinaryIO, Iterator, Literal, TextIO
 
-from . import events
+from . import events, log
 from .events import MouseUp
 
 if TYPE_CHECKING:
@@ -245,6 +245,10 @@ def save_file_thread(binary: BinaryIO | TextIO, mode: str) -> None:
             except Exception as error:
                 # If any exception occurs during the delivery, pass
                 # it on to the app via a DeliveryFailed event.
+                log.error(f"Failed to deliver file: {error}")
+                import traceback
+
+                log.error(str(traceback.format_exc()))
                 self._delivery_failed(delivery_key, exception=error)
             finally:
                 if not binary.closed:

src/textual/drivers/web_driver.py

@@ -269,10 +269,8 @@ def on_meta(self, packet_type: str, payload: dict[str, object]) -> None:
                         log.info(f"Delivery complete for {delivery_key}")
                         file_like.close()
                         del deliveries[delivery_key]
-                        self._app.call_from_thread(
-                            self._delivery_complete, delivery_key=delivery_key
-                        )
-                except Exception:
+                        self._delivery_complete(delivery_key, save_path=None)
+                except Exception as error:
                     file_like.close()
                     del deliveries[delivery_key]
 
@@ -284,6 +282,8 @@ def on_meta(self, packet_type: str, payload: dict[str, object]) -> None:
 
                     log.error(str(traceback.format_exc()))
 
+                    self._delivery_failed(delivery_key, exception=error)
+
     def open_url(self, url: str, new_tab: bool = True) -> None:
         """Open a URL in the default web browser.