Merge pull request #5736 from Textualize/scrollbar-refresh

fix scrollbar refresh issue

Author: willmcgugan

CHANGELOG.md

@@ -15,13 +15,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed `OptionList` size after removing or clearing options https://github.com/Textualize/textual/issues/5728
 - Fixed footer / key panel not updating when keymaps are applied https://github.com/Textualize/textual/pull/5724
 - Fixed alignment not being applied when there are min and max limits on dimensions https://github.com/Textualize/textual/pull/5732
+- Fixed issues with OptionList scrollbar not updating https://github.com/Textualize/textual/pull/5736
 
 ### Changed
 
 - Collapsible title now accepts str, Text, or Content https://github.com/Textualize/textual/pull/5697
 - Rich Text objects will be converted to Content in OptionList and other widgets https://github.com/Textualize/textual/pull/5712
 - Textual will always convert dim attributes to RGB by default https://github.com/Textualize/textual/pull/5715
-- Notifications will now use Textual markup (previously they used Console markup) https://github.com/Textualize/textual/pull/5719
+- Notifications will now use content markup (previously they used Console markup) https://github.com/Textualize/textual/pull/5719
 
 ### Added
 

src/textual/widget.py

@@ -3873,13 +3873,11 @@ def _scroll_update(self, virtual_size: Size) -> None:
             self.vertical_scrollbar.window_size = (
                 height - self.scrollbar_size_horizontal
             )
-            if self.vertical_scrollbar._repaint_required:
-                self.vertical_scrollbar.refresh()
+            self.vertical_scrollbar.refresh()
         if self.show_horizontal_scrollbar:
             self.horizontal_scrollbar.window_virtual_size = virtual_size.width
             self.horizontal_scrollbar.window_size = width - self.scrollbar_size_vertical
-            if self.horizontal_scrollbar._repaint_required:
-                self.horizontal_scrollbar.refresh()
+            self.horizontal_scrollbar.refresh()
 
         self.scroll_x = self.validate_scroll_x(self.scroll_x)
         self.scroll_y = self.validate_scroll_y(self.scroll_y)

src/textual/widgets/_option_list.py

@@ -311,6 +311,8 @@ def clear_options(self) -> Self:
         self._option_to_index.clear()
         self.highlighted = None
         self.refresh()
+        self.scroll_to(0, 0, animate=False)
+        self._update_lines()
         return self
 
     def add_options(self, new_options: Iterable[OptionListContent]) -> Self: