Refine

Author: willmcgugan

src/textual/demo/demo_app.py

@@ -57,7 +57,7 @@ class DemoApp(App):
             tooltip="Save an SVG 'screenshot' of the current screen",
         ),
         Binding(
-            "ctrl+m",
+            "ctrl+a",
             "app.maximize",
             "Maximize",
             tooltip="Maximized the focused widget (if possible)",

src/textual/demo/widgets.py

@@ -537,7 +537,7 @@ class Sparklines(containers.VerticalGroup):
         VerticalScroll {
             height: auto;
             border: heavy transparent;
-            &:focus { border: heavy $accent; }
+            &:focus { border: heavy $border; }
         }
     }
 
@@ -686,13 +686,11 @@ class Trees(containers.VerticalGroup):
     def compose(self) -> ComposeResult:
         yield Markdown(self.TREES_MD)
         with containers.VerticalGroup():
-            yield Tree("80s movies")
-
-    def on_mount(self) -> None:
-        tree = self.query_one(Tree)
-        tree.show_root = False
-        tree.add_json(MOVIES_TREE)
-        tree.root.expand()
+            tree = Tree("80s movies")
+            tree.show_root = False
+            tree.add_json(MOVIES_TREE)
+            tree.root.expand()
+            yield tree
 
 
 class TextAreas(containers.VerticalGroup):
@@ -754,14 +752,17 @@ def on_select_changed(self, event: Select.Changed) -> None:
 class YourWidgets(containers.VerticalGroup):
     DEFAULT_CLASSES = "column"
     YOUR_MD = """\
-## Your widget here
+## Your Widget Here!
 
 The Textual API allows you to [build custom re-usable widgets](https://textual.textualize.io/guide/widgets/#custom-widgets) and share them across projects.
 Custom widgets can be themed, just like the builtin widget library.
 
 Combine existing widgets to add new functionality, or use the powerful [Line API](https://textual.textualize.io/guide/widgets/#line-api) for unique creations.
 
 """
+    DEFAULT_CSS = """
+    YourWidgets { margin-bottom: 2; }
+    """
 
     def compose(self) -> ComposeResult:
         yield Markdown(self.YOUR_MD)
@@ -773,13 +774,11 @@ class WidgetsScreen(PageScreen):
     CSS = """
     WidgetsScreen { 
         align-horizontal: center;
-        Markdown {
-            background: transparent;
-        }
+        Markdown { background: transparent; }
         & > VerticalScroll {
             scrollbar-gutter: stable;
             &> * {            
-                &:last-of-type { margin-bottom: 2; } 
+              
                 &:even { background: $boost; }
                 padding-bottom: 1;
             }

src/textual/renderables/sparkline.py

@@ -6,6 +6,7 @@
 
 from rich.color import Color
 from rich.console import Console, ConsoleOptions, RenderResult
+from rich.measure import Measurement
 from rich.segment import Segment
 from rich.style import Style
 
@@ -95,6 +96,11 @@ def __rich_console__(
             bucket_index += step
             yield Segment(self.BARS[bar_index], Style.from_color(bar_color))
 
+    def __rich_measure__(
+        self, console: "Console", options: "ConsoleOptions"
+    ) -> Measurement:
+        return Measurement(self.width or options.max_width, 1)
+
 
 if __name__ == "__main__":
     console = Console()

src/textual/widgets/_sparkline.py

@@ -88,8 +88,6 @@ def __init__(
     def render(self) -> RenderResult:
         """Renders the sparkline when there is data available."""
         data = self.data or []
-        if not data:
-            return ""
         _, base = self.background_colors
         min_color = base + (
             self.get_component_styles("sparkline--min-color").color