event loop test

Author: willmcgugan

CHANGELOG.md

@@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 
 - Fixed `OptionList` causing excessive redrawing https://github.com/Textualize/textual/pull/5766
-- Log messages could be written to stdout when there was no app, which could happen when using run_async or threads. Now they will be supressed, unless the env var `TEXTUAL_DEBUG` is set
+- Log messages could be written to stdout when there was no app, which could happen when using run_async or threads. Now they will be suppressed, unless the env var `TEXTUAL_DEBUG` is set
 
 ### Added
 

src/textual/app.py

@@ -2126,7 +2126,7 @@ def run(
         mouse: bool = True,
         size: tuple[int, int] | None = None,
         auto_pilot: AutopilotCallbackType | None = None,
-        loop_factory: Callable[[], AbstractEventLoop] | None = None,
+        loop: AbstractEventLoop | None = None,
     ) -> ReturnType | None:
         """Run the app.
 
@@ -2138,7 +2138,7 @@ def run(
             size: Force terminal size to `(WIDTH, HEIGHT)`,
                 or None to auto-detect.
             auto_pilot: An auto pilot coroutine.
-            loop_factory: Callable which returns a new asyncio Loop, or `None` to use default.
+            loop: Asyncio loop instance, or `None` to use default.
         Returns:
             App return value.
         """
@@ -2156,12 +2156,10 @@ async def run_app() -> None:
 
         if _ASYNCIO_GET_EVENT_LOOP_IS_DEPRECATED:
             # N.B. This doesn't work with Python<3.10, as we end up with 2 event loops:
-            asyncio.run(run_app(), loop_factory=loop_factory)
+            asyncio.run(run_app(), loop_factory=None if loop is None else lambda: loop)
         else:
             # However, this works with Python<3.10:
-            event_loop = (
-                asyncio.get_event_loop() if loop_factory is None else loop_factory()
-            )
+            event_loop = asyncio.get_event_loop() if loop is None else loop
             event_loop.run_until_complete(run_app())
         return self.return_value
 

tests/test_app.py

@@ -1,3 +1,4 @@
+import asyncio
 import contextlib
 
 import pytest
@@ -340,3 +341,15 @@ def on_click(self, event: events.Click) -> None:
             # Each click is outwith the time threshold, so a click chain is never created.
             await raw_click(pilot, "#one")
             assert click_count == i
+
+
+def test_app_loop() -> None:
+    """Test that App.run accepts a loop argument."""
+
+    class MyApp(App[int]):
+        def on_mount(self) -> None:
+            self.exit(42)
+
+    app = MyApp()
+    result = app.run(loop=asyncio.new_event_loop())
+    assert result == 42