Merge pull request #5681 from Textualize/table-overflow

fix table scroll

Author: willmcgugan

CHANGELOG.md

@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed additional spaces after text-wrapping https://github.com/Textualize/textual/pull/5657
 - Added missing `scroll_end` parameter to the `Log.write_line` method https://github.com/Textualize/textual/pull/5672
 - Restored support for blink https://github.com/Textualize/textual/pull/5675
+- Fixed scrolling breaking on DataTable with `overflow: hidden` https://github.com/Textualize/textual/pull/5681
 
 ### Added
 

src/textual/scroll_view.py

@@ -33,13 +33,15 @@ def is_scrollable(self) -> bool:
         return True
 
     def watch_scroll_x(self, old_value: float, new_value: float) -> None:
-        if self.show_horizontal_scrollbar and old_value != new_value:
+        if self.show_horizontal_scrollbar:
             self.horizontal_scrollbar.position = new_value
+        if round(old_value) != round(new_value):
             self.refresh()
 
     def watch_scroll_y(self, old_value: float, new_value: float) -> None:
-        if self.show_vertical_scrollbar and (old_value) != (new_value):
+        if self.show_vertical_scrollbar:
             self.vertical_scrollbar.position = new_value
+        if round(old_value) != round(new_value):
             self.refresh()
 
     def on_mount(self):
@@ -174,7 +176,6 @@ def refresh_lines(self, y_start: int, line_count: int = 1) -> None:
             y_start: First line to refresh.
             line_count: Total number of lines to refresh.
         """
-
         refresh_region = Region(
             0,
             y_start - self.scroll_offset.y,

src/textual/widget.py

@@ -4003,7 +4003,6 @@ def refresh(
         Returns:
             The `Widget` instance.
         """
-
         if layout:
             self._layout_required = True
             for ancestor in self.ancestors: