merge

Author: willmcgugan

.github/workflows/pythonpackage.yml

@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
     defaults:
       run:
         shell: bash
@@ -35,18 +35,18 @@ jobs:
           cache: "poetry"
       - name: Install dependencies
         run: poetry install --no-interaction --extras syntax
-        if: ${{ matrix.python-version != '3.12' }}
-      - name: Install dependencies for 3.12 # https://github.com/Textualize/textual/issues/3491#issuecomment-1854156476
+        if: ${{ matrix.python-version != '3.13' }}
+      - name: Install dependencies for 3.13
         run: poetry install --no-interaction
-        if: ${{ matrix.python-version == '3.12' }}
+        if: ${{ matrix.python-version == '3.13' }}
       - name: Test with pytest
         run: |
           poetry run pytest tests -v --cov=./src/textual --cov-report=xml:./coverage.xml --cov-report term-missing
-        if: ${{ matrix.python-version != '3.12' }}
-      - name: Test with pytest for 3.12 # https://github.com/Textualize/textual/issues/3491#issuecomment-1854156476
+        if: ${{ matrix.python-version != '3.13' }}
+      - name: Test with pytest for 3.13
         run: |
           poetry run pytest tests -v --cov=./src/textual --cov-report=xml:./coverage.xml --cov-report term-missing -m 'not syntax'
-        if: ${{ matrix.python-version == '3.12' }}
+        if: ${{ matrix.python-version == '3.13' }}
       - name: Upload snapshot report
         if: always()
         uses: actions/upload-artifact@v3

CHANGELOG.md

@@ -5,6 +5,19 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+
+## Changed
+
+- Fixed Select not scrolling highlight in to view when clicked https://github.com/Textualize/textual/issues/5255
+
+## [0.88.1] - 2024-11-30
+
+### Fixed
+
+- Fixed excessive rendering of the OptionList https://github.com/Textualize/textual/pull/5311
+- Fixed rendering glitches in Select https://github.com/Textualize/textual/pull/5311
+
 ## [0.88.0] - 2024-11-29
 
 ### Fixed
@@ -2600,6 +2613,7 @@ https://textual.textualize.io/blog/2022/11/08/version-040/#version-040
 - New handler system for messages that doesn't require inheritance
 - Improved traceback handling
 
+[0.88.1]: https://github.com/Textualize/textual/compare/v0.88.0...v0.88.1
 [0.88.0]: https://github.com/Textualize/textual/compare/v0.87.1...v0.88.0
 [0.87.1]: https://github.com/Textualize/textual/compare/v0.87.0...v0.87.1
 [0.87.0]: https://github.com/Textualize/textual/compare/v0.86.4...v0.87.0

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "textual"
-version = "0.88.0"
+version = "0.88.1"
 homepage = "https://github.com/Textualize/textual"
 repository = "https://github.com/Textualize/textual"
 documentation = "https://textual.textualize.io/"
@@ -9,8 +9,8 @@ description = "Modern Text User Interface framework"
 authors = ["Will McGugan <[email protected]>"]
 license = "MIT"
 readme = "README.md"
-classifiers = [
-    "Development Status :: 4 - Beta",
+classifiers = [    
+    "Development Status :: 5 - Production/Stable",
     "Environment :: Console",
     "Intended Audience :: Developers",
     "Operating System :: Microsoft :: Windows :: Windows 10",

src/textual/widgets/_option_list.py

@@ -195,7 +195,7 @@ class OptionList(ScrollView, can_focus=True):
     | `option-list--separator` | Target the separators. |
     """
 
-    highlighted: reactive[int | None] = reactive["int | None"](None)
+    highlighted: reactive[int | None] = reactive(None)
     """The index of the currently-highlighted option, or `None` if no option is highlighted."""
 
     class OptionMessage(Message):
@@ -880,6 +880,7 @@ def scroll_to_highlight(self, top: bool = False) -> None:
             top: Scroll highlight to top of the list.
         """
         highlighted = self.highlighted
+
         if highlighted is None or not self.is_mounted:
             return
 
@@ -901,6 +902,10 @@ def scroll_to_highlight(self, top: bool = False) -> None:
             immediate=True,
         )
 
+    def on_show(self) -> None:
+        if self.highlighted is not None:
+            self.scroll_to_highlight()
+
     def validate_highlighted(self, highlighted: int | None) -> int | None:
         """Validate the `highlighted` property value on access."""
         if highlighted is None or not self._options:

src/textual/widgets/_select.py

@@ -414,7 +414,7 @@ def _setup_variables_for_options(
 
     def _setup_options_renderables(self) -> None:
         """Sets up the `Option` renderables associated with the `Select` options."""
-        self._select_options: list[Option] = [
+        options: list[Option] = [
             (
                 Option(Text(self.prompt, style="dim"))
                 if value == self.BLANK
@@ -425,7 +425,7 @@ def _setup_options_renderables(self) -> None:
 
         option_list = self.query_one(SelectOverlay)
         option_list.clear_options()
-        option_list.add_options(self._select_options)
+        option_list.add_options(options)
 
     def _init_selected_option(self, hint: SelectType | NoSelection = BLANK) -> None:
         """Initialises the selected option for the `Select`."""