Skip to content

Commit efa4e9a

Browse files
committed
changelog
1 parent 11c3790 commit efa4e9a

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1414
- Fixed modal bindings https://github.com/Textualize/textual/issues/2194
1515
- Fix binding enter to active button https://github.com/Textualize/textual/issues/2194
1616

17+
### [Changed]
18+
19+
- tab and shift+tab are now defined on Screen.
20+
1721
## [0.17.1] - 2023-03-30
1822

1923
### Fixed

tests/test_binding_inheritance.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,8 @@ class NoBindings(App[None]):
3939
async def test_just_app_no_bindings() -> None:
4040
"""An app with no bindings should have no bindings, other than ctrl+c."""
4141
async with NoBindings().run_test() as pilot:
42-
assert list(pilot.app._bindings.keys.keys()) == ["ctrl+c", "tab", "shift+tab"]
42+
assert list(pilot.app._bindings.keys.keys()) == ["ctrl+c"]
4343
assert pilot.app._bindings.get_key("ctrl+c").priority is True
44-
assert pilot.app._bindings.get_key("tab").priority is False
45-
assert pilot.app._bindings.get_key("shift+tab").priority is False
4644

4745

4846
##############################################################################
@@ -63,9 +61,7 @@ class AlphaBinding(App[None]):
6361
async def test_just_app_alpha_binding() -> None:
6462
"""An app with a single binding should have just the one binding."""
6563
async with AlphaBinding().run_test() as pilot:
66-
assert sorted(pilot.app._bindings.keys.keys()) == sorted(
67-
["ctrl+c", "tab", "shift+tab", "a"]
68-
)
64+
assert sorted(pilot.app._bindings.keys.keys()) == sorted(["ctrl+c", "a"])
6965
assert pilot.app._bindings.get_key("ctrl+c").priority is True
7066
assert pilot.app._bindings.get_key("a").priority is True
7167

@@ -87,9 +83,7 @@ class LowAlphaBinding(App[None]):
8783
async def test_just_app_low_priority_alpha_binding() -> None:
8884
"""An app with a single low-priority binding should have just the one binding."""
8985
async with LowAlphaBinding().run_test() as pilot:
90-
assert sorted(pilot.app._bindings.keys.keys()) == sorted(
91-
["ctrl+c", "tab", "shift+tab", "a"]
92-
)
86+
assert sorted(pilot.app._bindings.keys.keys()) == sorted(["ctrl+c", "a"])
9387
assert pilot.app._bindings.get_key("ctrl+c").priority is True
9488
assert pilot.app._bindings.get_key("a").priority is False
9589

0 commit comments

Comments
 (0)