Merge pull request #4308 from Textualize/fix-data-bind

fix data binding

Author: willmcgugan

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+
+## [0.53.1] - 2023-03-18
+
+### Fixed
+
+- Fixed issue with data binding
+
 ## [0.53.0] - 2023-03-18
 
 ### Added
@@ -1781,6 +1788,7 @@ https://textual.textualize.io/blog/2022/11/08/version-040/#version-040
 - New handler system for messages that doesn't require inheritance
 - Improved traceback handling
 
+[0.53.1]: https://github.com/Textualize/textual/compare/v0.53.0...v0.53.1
 [0.53.0]: https://github.com/Textualize/textual/compare/v0.52.1...v0.53.0
 [0.52.1]: https://github.com/Textualize/textual/compare/v0.52.0...v0.52.1
 [0.52.0]: https://github.com/Textualize/textual/compare/v0.51.0...v0.52.0

src/textual/dom.py

@@ -278,7 +278,7 @@ def compose(self) -> ComposeResult:
                     f"Unable to bind data; {reactive.owner.__name__} is not defined on {parent.__class__.__name__}."
                 )
             self._reactive_connect[name] = (parent, reactive)
-        self._initialize_data_bind()
+        self.call_later(self._initialize_data_bind)
         return self
 
     def _initialize_data_bind(self) -> None:

tests/test_data_bind.py

@@ -22,7 +22,7 @@ def compose(self) -> ComposeResult:
 
 async def test_data_binding():
     app = DataBindApp()
-    async with app.run_test():
+    async with app.run_test() as pilot:
 
         # Check default
         assert app.bar == "Bar"
@@ -51,6 +51,7 @@ async def test_data_binding():
 
         # Bind data outside of compose
         label2.data_bind(foo=DataBindApp.bar)
+        await pilot.pause()
         # Confirm new binding has propagated
         assert label2.foo == "Baz"