Header widget improvements #2890
davetapley
started this conversation in
Ideas
Replies: 1 comment 2 replies
-
The Header was one of the first widget we did, and it could certainly use some more work. I think you can set the icon to empty string, or maybe a space to disable it. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Will you accept a PR to make the icon optional?
textual/src/textual/widgets/_header.py
Lines 153 to 155 in a35e92b
Alternatively perhaps the icon should have some docs to show how to set it. I see ⬇️ but I'm not sure what how you'd change that?
textual/src/textual/widgets/_header.py
Line 27 in a35e92b
Then it could be allowed to be
None
(I'd argue that should be the default) and that would be how you turn it off and on?Similarly I'm not sure about the default 'click to make it tall' semantics?
It seems like that should be something you should have to opt in to?
e.g. if I have custom content
hello there
:But then if someone clicks on it the see the app name below and center aligned? 😬
Also less critical, but I feel like the default header and footer background colors should be the same?
textual/src/textual/widgets/_header.py
Lines 115 to 119 in a35e92b
textual/src/textual/widgets/_footer.py
Lines 34 to 36 in a35e92b
Beta Was this translation helpful? Give feedback.
All reactions