Skip to content

Commit 5b1ed24

Browse files
committed
WDIO v8 | Code Refactoring
1 parent 49f6678 commit 5b1ed24

File tree

6 files changed

+26
-13
lines changed

6 files changed

+26
-13
lines changed

jsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"types": [
44
"node",
55
"@wdio/globals/types",
6-
"@wdio/mocha-framework"
6+
"@wdio/mocha-framework",
7+
"expect-webdriverio"
78
]
89
}
910
}

package-lock.json

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"@wdio/mocha-framework": "^8.1.2",
2020
"@wdio/selenium-standalone-service": "^8.1.2",
2121
"@wdio/spec-reporter": "^8.1.2",
22+
"allure-commandline": "^2.20.1",
2223
"wdio-docker-service": "^3.2.1",
2324
"wdio-video-reporter": "^3.4.0",
2425
"webdriverio": "^8.1.2"
@@ -31,7 +32,8 @@
3132
"posttest:docker": "docker-compose down",
3233
"checkupdates": "npx npm-check-updates -u",
3334
"cleanup": "rmdir /Q /S reports",
34-
"generateAllureReport": "allure generate ./reports/video-reports/allure-raw -o ./reports/video-reports/allure-report --clean && allure open ./reports/video-reports/allure-report"
35+
"generateAllureReport": "allure generate ./reports/video-reports/allure-raw -o ./reports/video-reports/allure-report --clean && allure open ./reports/video-reports/allure-report",
36+
"allurereport:ci": "allure generate ./reports/video-reports/allure-raw -o ./reports/video-reports/allure-report --clean"
3537
},
3638
"repository": {
3739
"type": "git",

test/pageobjects/herokuApp/login.page.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
2-
31
import Page from './page.js';
42

53
/**

test/specs/example.e2e.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,8 @@ import LoginPage from '../pageobjects/herokuApp/login.page.js';
22
import SecurePage from '../pageobjects/herokuApp/secure.page.js';
33

44
describe('Login:', () => {
5-
before('Open application', async () => {
6-
await LoginPage.open();
7-
});
8-
95
it('should login with valid credentials', async () => {
10-
6+
await LoginPage.open();
117
await LoginPage.login('tomsmith', 'SuperSecretPassword!');
128

139
await expect(SecurePage.flashAlert).toBeExisting();

test/specs/orangeHrm.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ import { username, password } from '../../resources/config.js';
55

66
describe('OrangeHRM Login Test', () => {
77

8-
before('Open application', async () => {
8+
it('should allow access with correct credential', async () => {
99
await LoginPage.open();
10-
});
1110

12-
it('should allow access with correct credential', async () => {
11+
await expect(LoginPage.loginForm).toBeExisting();
12+
1313
await waitAndSetValue(LoginPage.username, username, 1000);
14-
await waitAndSetValue(LoginPage.password, password, 500);
14+
await waitAndSetValue(LoginPage.password, password, 1000);
1515
await LoginPage.loginBtn.click();
1616

1717
await expect(Topbar.usernameDropdownMenu).toBeExisting();

0 commit comments

Comments
 (0)