[IMP] rec addr

Author: ThanhDodeurOdoo

src/models/channel.ts

@@ -53,7 +53,7 @@ interface ChannelCreateOptions {
     key?: string;
     /** Whether to enable WebRTC functionality */
     useWebRtc?: boolean;
-    useRecording?: boolean;
+    recordingAddress?: string | null;
 }
 interface JoinResult {
     /** The channel instance */
@@ -105,7 +105,7 @@ export class Channel extends EventEmitter {
         issuer: string,
         options: ChannelCreateOptions = {}
     ): Promise<Channel> {
-        const { key, useWebRtc = true, useRecording = true } = options;
+        const { key, useWebRtc = true, recordingAddress } = options;
         const safeIssuer = `${remoteAddress}::${issuer}`;
         const oldChannel = Channel.recordsByIssuer.get(safeIssuer);
         if (oldChannel) {
@@ -115,7 +115,7 @@ export class Channel extends EventEmitter {
         const channelOptions: ChannelCreateOptions & {
             worker?: Worker;
             router?: Router;
-        } = { key, useRecording: useWebRtc && useRecording };
+        } = { key, recordingAddress: useWebRtc ? recordingAddress : null };
         if (useWebRtc) {
             channelOptions.worker = await getWorker();
             channelOptions.router = await channelOptions.worker.createRouter({
@@ -186,7 +186,7 @@ export class Channel extends EventEmitter {
         const now = new Date();
         this.createDate = now.toISOString();
         this.remoteAddress = remoteAddress;
-        this.recorder = config.recording.enabled && options.useRecording ? new Recorder(this) : undefined;
+        this.recorder = config.recording.enabled && options.recordingAddress ? new Recorder(this, options.recordingAddress) : undefined;
         this.key = key ? Buffer.from(key, "base64") : undefined;
         this.uuid = crypto.randomUUID();
         this.name = `${remoteAddress}*${this.uuid.slice(-5)}`;
@@ -291,6 +291,7 @@ export class Channel extends EventEmitter {
      * @fires Channel#close
      */
     close(): void {
+        this.recorder?.stop();
         for (const session of this.sessions.values()) {
             session.off("close", this._onSessionClose);
             session.close({ code: SESSION_CLOSE_CODE.CHANNEL_CLOSED });

src/models/recorder.ts

@@ -8,10 +8,13 @@ export class Recorder extends EventEmitter {
     channel: Channel;
     state: "started" | "stopped" = "stopped";
     ffmpeg = null;
+    /** Path to which the final recording will be uploaded to */
+    recordingAddress: string;
 
-    constructor(channel: Channel) {
+    constructor(channel: Channel, recordingAddress: string) {
         super();
         this.channel = channel;
+        this.recordingAddress = recordingAddress;
     }
 
     async start() {

src/services/http.ts

@@ -79,6 +79,29 @@ function setupRoutes(routeListener: RouteListener): void {
             return res.end(JSON.stringify(channelStats));
         }
     });
+    /**
+     * GET /v1/channel
+     *
+     * Creates (or reuses) a media channel for the authenticated client.
+     *
+     * ### Headers
+     * - `Authorization: Bearer <JWT>` — required.
+     *   The JWT must include the `iss` (issuer) claim identifying the caller.
+     *
+     * ### Query Parameters
+     * - `webRTC` — optional, defaults to `"true"`.
+     *   When set to `"false"`, disables WebRTC setup and creates a non-media channel.
+     * - `recordingAddress` — optional.
+     *   If provided, enables recording and specifies the destination address
+     *   for recorded media streams. This address should most likely include a secret token,
+     *   so that it can be used publicly. For example http://example.com/recording/123?token=asdasdasdasd
+     *
+     * ### Responses
+     * - `200 OK` — returns `{ uuid: string, url: string }`
+     * - `401 Unauthorized` — missing or invalid Authorization header
+     * - `403 Forbidden` — missing `iss` claim
+     * - `500 Internal Server Error` — failed to create the channel
+     */
     routeListener.get(`/v${API_VERSION}/channel`, {
         callback: async (req, res, { host, protocol, remoteAddress, searchParams }) => {
             try {
@@ -99,7 +122,7 @@ function setupRoutes(routeListener: RouteListener): void {
                 const channel = await Channel.create(remoteAddress, claims.iss, {
                     key: claims.key,
                     useWebRtc: searchParams.get("webRTC") !== "false",
-                    useRecording: searchParams.get("recording") !== "false"
+                    recordingAddress: searchParams.get("recordingAddress")
                 });
                 res.setHeader("Content-Type", "application/json");
                 res.statusCode = 200;