CI Cleanup (#126)

* add PHONY targets, make CI run with `bash` and exit on error

---------

Signed-off-by: Jack Luar <[email protected]>

Author: luarss

.github/workflows/ci-secret.yaml

@@ -12,6 +12,10 @@ on:
       - 'Makefile'
       - 'docker-compose.yml'
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build-backend-docker:
     runs-on: self-hosted
@@ -23,7 +27,8 @@ jobs:
     - name: Checkout code
       uses: actions/checkout@v4
     - name: Setup prereqs
-      run: make init-dev
+      run: |
+        make init-dev
     - name: Run formatting checks
       run: |
         make check

.github/workflows/ci.yaml

@@ -10,6 +10,10 @@ on:
       - 'Makefile'
       - 'docker-compose.yml'
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build-backend-docker:
     runs-on: self-hosted
@@ -21,7 +25,8 @@ jobs:
     - name: Checkout code
       uses: actions/checkout@v4
     - name: Setup prereqs
-      run: make init-dev
+      run: |
+        make init-dev
     - name: Run formatting checks
       run: |
         make check

Makefile

@@ -1,27 +1,32 @@
-.PHONY: init init-dev format check
-
 FOLDERS=backend frontend evaluation
 
+.PHONY: init
 init:
 	@for folder in $(FOLDERS); do (cd $$folder && make init && cd ../); done
 
+.PHONY: init-dev
 init-dev:
 	@for folder in $(FOLDERS); do (cd $$folder && make init-dev && cd ../); done
 
+.PHONY: format
 format:
 	@for folder in $(FOLDERS); do (cd $$folder && make format && cd ../); done
 
+.PHONY: check
 check:
 	@for folder in $(FOLDERS); do (cd $$folder && make check && cd ../); done
 	@. ./backend/.venv/bin/activate && \
 		pre-commit run --all-files
 
+.PHONY: docker-up
 docker-up:
 	@docker compose up --build --wait
 
+.PHONY: docker-down
 docker-down:
 	@docker compose down --remove-orphans
 
+.PHONY: changelog
 changelog:
 	@git log --pretty=format:"%h%x09%an%x09%ad%x09%s" --date=short --since="2024-06-01" > CHANGELOG.md
 	@cd .github/workflows && python changelog_report.py

backend/.env.example

@@ -22,10 +22,10 @@ GOOGLE_EMBEDDINGS="text-embedding-004"
 HF_EMBEDDINGS="thenlper/gte-large"
 HF_RERANKER="BAAI/bge-reranker-base"
 
-LANGCHAIN_TRACING_V2=
-LANGCHAIN_ENDPOINT=
-LANGCHAIN_API_KEY=
-LANGCHAIN_PROJECT=
+LANGSMITH_TRACING=true
+LANGSMITH_ENDPOINT="https://api.smith.langchain.com"
+LANGSMITH_API_KEY=
+LANGSMITH_PROJECT=
 
 HF_TOKEN=
 

backend/Makefile

@@ -1,17 +1,21 @@
+.PHONY: init
 init:
 	@python3 -m venv .venv && \
 		. .venv/bin/activate && \
 		pip install -r requirements.txt && \
 		pip install -e .
 
+.PHONY: init-dev
 init-dev: init
 	@. .venv/bin/activate && \
 		pip install -r requirements-test.txt
 
+.PHONY: format
 format:
 	@. .venv/bin/activate && \
 		ruff format
 
+.PHONY: check
 check:
 	@. .venv/bin/activate && \
 		mypy . && \

evaluation/Makefile

@@ -1,28 +1,32 @@
-.PHONY: init init-dev format check clean
-
+.PHONY: init
 init:
 	@python3 -m venv .venv && \
 		. .venv/bin/activate && \
 		pip install -r requirements.txt && \
 		pip install -e .
 
+.PHONY: init-dev
 init-dev: init
 	@. .venv/bin/activate && \
 		pip install -r requirements-test.txt
 
+.PHONY: format
 format:
 	@. .venv/bin/activate && \
 		ruff format
 
+.PHONY: check
 check:
 	@. .venv/bin/activate && \
 		mypy . && \
 		ruff check
 
+.PHONY: clean
 clean:
 	@rm -f llm_tests_output.txt
 	@rm -f **/.deepeval-cache.json
 
+.PHONY: llm-tests
 llm-tests: clean
 	@. .venv/bin/activate && \
 		cd auto_evaluation && \

frontend/Makefile

@@ -1,16 +1,20 @@
+.PHONY: init
 init:
 	@python3 -m venv .venv && \
 		. .venv/bin/activate && \
 		pip install -r requirements.txt
 
+.PHONY: init-dev
 init-dev: init
 	@. .venv/bin/activate && \
 		pip install -r requirements-test.txt
 
+.PHONY: format
 format:
 	@. .venv/bin/activate && \
 		ruff format
 
+.PHONY: check
 check:
 	@. .venv/bin/activate && \
 		mypy . && \