Skip to content

Commit a2d22cd

Browse files
authored
Fix backend build docs (#140)
* backend: fix wrong signature * Revert "Improve sanity_check robustness (#138)" --------- Signed-off-by: Jack Luar <jluar@precisioninno.com>
1 parent 7c8e269 commit a2d22cd

File tree

2 files changed

+13
-41
lines changed

2 files changed

+13
-41
lines changed

backend/src/chains/similarity_retriever_chain.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def embed_docs(
9595

9696
if pdf_files:
9797
self.processed_pdfs = self.vector_db.add_documents(
98-
file_paths=pdf_files,
98+
folder_paths=pdf_files,
9999
file_type="pdf",
100100
return_docs=return_docs,
101101
)

evaluation/auto_evaluation/eval_main.py

Lines changed: 12 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -56,47 +56,19 @@ def __init__(self, base_url: str, dataset: str, reranker_base_url: str = ""):
5656
def sanity_check(self):
5757
cur_time = time.time()
5858
while time.time() - cur_time < RETRY_TIMEOUT:
59-
try:
60-
# Check main endpoint
61-
response = requests.get(f"{self.base_url}/healthcheck", timeout=10)
62-
if response.status_code != 200:
63-
print(
64-
f"Main endpoint health check failed with status {response.status_code}"
65-
)
66-
time.sleep(RETRY_INTERVAL)
67-
continue
68-
except requests.exceptions.RequestException as e:
69-
print(f"Failed to connect to main endpoint: {e}")
70-
time.sleep(RETRY_INTERVAL)
71-
continue
72-
73-
# Check dataset exists
59+
if not requests.get(f"{self.base_url}/healthcheck").status_code == 200:
60+
raise ValueError("Endpoint is not running")
7461
if not os.path.exists(self.dataset):
75-
raise ValueError(f"Dataset path does not exist: {self.dataset}")
76-
77-
# Check reranker endpoint if provided
78-
if self.reranker_base_url:
79-
try:
80-
response = requests.get(
81-
f"{self.reranker_base_url}/healthcheck", timeout=10
82-
)
83-
if response.status_code != 200:
84-
print(
85-
f"Reranker endpoint health check failed with status {response.status_code}"
86-
)
87-
time.sleep(RETRY_INTERVAL)
88-
continue
89-
except requests.exceptions.RequestException as e:
90-
print(f"Failed to connect to reranker endpoint: {e}")
91-
time.sleep(RETRY_INTERVAL)
92-
continue
93-
94-
# All checks passed
95-
print("All sanity checks passed")
96-
return
97-
98-
# Timeout reached
99-
raise TimeoutError(f"Sanity checks failed after {RETRY_TIMEOUT} seconds")
62+
raise ValueError("Dataset path does not exist")
63+
if (
64+
self.reranker_base_url
65+
and not requests.get(
66+
f"{self.reranker_base_url}/healthcheck"
67+
).status_code
68+
== 200
69+
):
70+
raise ValueError("Reranker endpoint is not running")
71+
time.sleep(RETRY_INTERVAL)
10072

10173
def evaluate(self, retriever: str):
10274
retrieval_tcs = []

0 commit comments

Comments
 (0)