fixes

Signed-off-by: habibayassin <[email protected]>

Author: habibayassin

.github/workflows/github-actions-update-rules.yml

@@ -45,7 +45,7 @@ jobs:
             echo "has_update=false" >> "$GITHUB_OUTPUT"
           fi
           git add .
-          git commit -m "flow: update rules based on new golden reference"
+          git commit --signoff -m "flow: update rules based on new golden reference"
       - if: "${{ github.event.client_payload.branch }} != 'master'"
         name: update rules pr
         id: remote-update-pr

flow/util/genRuleFile.py

@@ -357,4 +357,4 @@ def gen_rule_file(design_dir, update, tighten, failing, variant, golden_metrics=
         parser.print_help()
         sys.exit(1)
 
-    gen_rule_file(args.dir, args.update, args.tighten, args.failing, args.variant)
+    gen_rule_file(args.dir, args.update, args.tighten, args.failing, args.variant)

flow/util/updateRules.py

@@ -9,6 +9,7 @@
 import requests
 from genRuleFile import get_golden
 from genRuleFile import update_rules
+from genRuleFile import get_metrics
 
 # make sure the working dir is flow/
 os.chdir(os.path.join(os.path.dirname(os.path.abspath(__file__)), '..'))
@@ -45,7 +46,7 @@
     test = '{} {}'.format(platform, design)
     dataFile = os.path.join(designsDir, runFilename)
     if os.path.exists(dataFile) and (platform != 'sky130hd_fakestack' or platform != 'src'):
-        metrics, error_metrics = get_metrics(args.commitSHA # commit
+        metrics, error_metrics = get_metrics(args.commitSHA, # commit
                             platform, # platform
                             design, # design
                             api_base_url # backend url
@@ -57,4 +58,4 @@
                     "base", # variant
                     metrics, # metrics needed for update, default is {} in case of file
                     args.overwrite # overwrite flag, default is false
-                    )
+                    )