Merge pull request #2640 from luarss/topic/at-tunable-vars

[Autotuner] - Tunable variables check v2

Author: vvbandeira

flow/scripts/variables.yaml

@@ -94,13 +94,15 @@ CORE_UTILIZATION:
     The core utilization percentage (0-100).
   stages:
     - floorplan
+  tunable: 1
 CORE_AREA:
   description: >
     The core area specified as a list of lower-left and upper-right corners in
     microns
     (X1 Y1 X2 Y2).
   stages:
     - floorplan
+  tunable: 1
 REPORT_CLOCK_SKEW:
   description: >
     Report clock skew as part of reporting metrics, starting at CTS, before which
@@ -328,6 +330,7 @@ CELL_PAD_IN_SITES_GLOBAL_PLACEMENT:
     - place
     - floorplan
   default: 0
+  tunable: 1
 CELL_PAD_IN_SITES_DETAIL_PLACEMENT:
   description: >
     Cell padding on both sides in site widths to ease routability in detail
@@ -337,6 +340,7 @@ CELL_PAD_IN_SITES_DETAIL_PLACEMENT:
     - cts
     - grt
   default: 0
+  tunable: 1
 PLACE_PINS_ARGS:
   description: |
     Arguments to place_pins
@@ -358,6 +362,7 @@ PLACE_DENSITY_LB_ADDON:
   stages:
     - floorplan
     - place
+  tunable: 1
 REPAIR_PDN_VIA_LAYER:
   description: |
     Remove power grid vias which generate DRC violations after detailed routing.
@@ -635,6 +640,7 @@ CORE_ASPECT_RATIO:
     `CORE_UTILIZATION` is undefined.
   stages:
     - floorplan
+  tunable: 1
 CORE_MARGIN:
   description: >
     The margin between the core area and die area, specified in microns.
@@ -644,13 +650,15 @@ CORE_MARGIN:
     is undefined.
   stages:
     - floorplan
+  tunable: 1
 DIE_AREA:
   description: >
     The die area specified as a list of lower-left and upper-right corners in
     microns
     (X1 Y1 X2 Y2).
   stages:
     - floorplan
+  tunable: 1
 RESYNTH_AREA_RECOVER:
   description: |
     Enable re-synthesis for area reclaim.
@@ -693,12 +701,14 @@ CTS_CLUSTER_DIAMETER:
   default: 20
   stages:
     - cts
+  tunable: 1
 CTS_CLUSTER_SIZE:
   description: >
     Maximum number of sinks per cluster.
   default: 50
   stages:
     - cts
+  tunable: 1
 CTS_SNAPSHOT:
   description: |
     Creates ODB/SDC files prior to clock net and setup/hold repair.

tools/AutoTuner/requirements.txt

@@ -10,3 +10,4 @@ protobuf==3.20.3
 SQLAlchemy==1.4.17
 urllib3<=1.26.15
 matplotlib==3.10.0
+pyyaml==6.0.1

tools/AutoTuner/src/autotuner/utils.py

@@ -2,6 +2,7 @@
 import json
 import os
 import re
+import yaml
 import subprocess
 import sys
 from multiprocessing import cpu_count
@@ -161,6 +162,21 @@ def parse_flow_variables(base_dir, platform):
     return variables
 
 
+def parse_tunable_variables():
+    """
+    Parse the tunable variables from variables.yaml
+    TODO: Tests.
+    """
+    cur_path = os.path.dirname(os.path.realpath(__file__))
+    vars_path = os.path.join(cur_path, "../../../../flow/scripts/variables.yaml")
+
+    # Read from variables.yaml and get variables with tunable = 1
+    with open(vars_path) as file:
+        result = yaml.safe_load(file)
+    variables = {key for key, value in result.items() if value.get("tunable", 0) == 1}
+    return variables
+
+
 def parse_config(
     config,
     base_dir,
@@ -177,7 +193,7 @@ def parse_config(
     options = ""
     sdc = {}
     fast_route = {}
-    # flow_variables = parse_flow_variables(base_dir, platform)
+    flow_variables = parse_tunable_variables()
     for key, value in config.items():
         # Keys that begin with underscore need special handling.
         if key.startswith("_"):
@@ -198,9 +214,9 @@ def parse_config(
         # Default case is VAR=VALUE
         else:
             # Sanity check: ignore all flow variables that are not tunable
-            # if key not in flow_variables:
-            #     print(f"[ERROR TUN-0017] Variable {key} is not tunable.")
-            #     sys.exit(1)
+            if key not in flow_variables:
+                print(f"[ERROR TUN-0017] Variable {key} is not tunable.")
+                sys.exit(1)
             options += f" {key}={value}"
     if sdc:
         write_sdc(sdc, path, sdc_original, constraints_sdc)