Merge pull request #2514 from Pinata-Consulting/variables-global-route-args

Variables global route args

Author: maliberty

flow/Makefile

@@ -160,7 +160,9 @@ export UTILS_DIR     ?= $(FLOW_HOME)/util
 export SCRIPTS_DIR   ?= $(FLOW_HOME)/scripts
 export TEST_DIR      ?= $(FLOW_HOME)/test
 
-$(foreach line,$(shell $(SCRIPTS_DIR)/defaults.py),$(eval export $(line)))
+# __SPACE__ is a workaround for whitespace hell in "foreach"; there
+# is no way to escape space in defaults.py and get "foreach" to work.
+$(foreach line,$(shell $(SCRIPTS_DIR)/defaults.py),$(eval export $(subst __SPACE__, ,$(line))))
 
 PUBLIC=nangate45 sky130hd sky130hs asap7 ihp-sg13g2 gf180
 

flow/scripts/defaults.py

@@ -12,4 +12,4 @@
 for key, value in data.items():
     if value.get("default", None) is None:
         continue
-    print(f'{key}?={value["default"]}')
+    print(f'export {key}?={str(value["default"]).replace(" ", "__SPACE__")}')

flow/scripts/global_route.tcl

@@ -12,15 +12,10 @@ proc global_route_helper {} {
 
   fast_route
 
-  # The default behavior if the user didn't specify GLOBAL_ROUTE_ARGS is to
-  # produce a drc report every 5 iterations.
-  #
-  # If GLOBAL_ROUTE_ARGS is specified, then we do only what the
-  # GLOBAL_ROUTE_ARGS specifies.
   proc do_global_route {} {
-    set all_args [concat [list -congestion_report_file $::global_route_congestion_report] \
-      [expr {[env_var_exists_and_non_empty GLOBAL_ROUTE_ARGS] ? $::env(GLOBAL_ROUTE_ARGS) : \
-      {-congestion_iterations 30 -congestion_report_iter_step 5 -verbose}}]]
+    set all_args [concat [list \
+      -congestion_report_file $::global_route_congestion_report] \
+      $::env(GLOBAL_ROUTE_ARGS)]
 
     log_cmd global_route {*}$all_args
   }

flow/scripts/variables.yaml

@@ -604,3 +604,9 @@ ABSTRACT_SOURCE:
     Which .odb file to use to create abstract
   stages:
     - generate_abstract
+GLOBAL_ROUTE_ARGS:
+  description: >
+    Replaces default arguments for global route.
+  stages:
+    - grt
+  default: -congestion_iterations 30 -congestion_report_iter_step 5 -verbose