Merge pull request #2784 from Pinata-Consulting/env-cleanup

env: cleanup and comments

Author: vvbandeira

dev_env.sh

@@ -1,9 +1,16 @@
 #!/usr/bin/env bash
-
-function setpaths() {
+#
+# Set developer paths and environment variables here,
+# user settings go in ./env.sh
+function __setpaths() {
     local DIR=$(readlink -f "$(dirname "${BASH_SOURCE[0]}")")
+    [ "$(find $DIR/dependencies -type f -user root)" ] && echo "WARNING! Files set up by sudo found in $DIR"
     export PATH="$DIR/dependencies/bin:$PATH"
     export CMAKE_INSTALL_RPATH=$DIR/dependencies/lib:$DIR/dependencies/lib64
-}
 
-setpaths
+    if [[ "$OSTYPE" == "darwin"* ]]; then
+        export CMAKE_PREFIX_PATH="$(brew --prefix or-tools)"
+    fi
+}
+__setpaths
+unset -f __setpaths

env.sh

@@ -1,24 +1,25 @@
-if [[ "$OSTYPE" == "darwin"* ]]; then
-  DIR="$(dirname $(perl -e 'use Cwd "abs_path";print abs_path(shift)' "${BASH_SOURCE[0]}"))"
-else
-  DIR="$(dirname $(readlink -f "${BASH_SOURCE[0]}"))"
-fi
+#!/usr/bin/env bash
+function __setpaths() {
+  if [[ "$OSTYPE" == "darwin"* ]]; then
+    DIR="$(dirname $(perl -e 'use Cwd "abs_path";print abs_path(shift)' "${BASH_SOURCE[0]}"))"
+  else
+    DIR="$(dirname $(readlink -f "${BASH_SOURCE[0]}"))"
+  fi
 
-if [ -f /opt/rh/rh-python38/enable ]; then
-  source /opt/rh/rh-python38/enable
-fi
+  export OPENROAD=${DIR}/tools/OpenROAD
+  echo "OPENROAD: ${OPENROAD}"
 
-export OPENROAD=${DIR}/tools/OpenROAD
-echo "OPENROAD: ${OPENROAD}"
+  # Set user paths and environment variables here,
+  # developer settings go in ./dev_env.sh
+  export PATH=${DIR}/tools/install/OpenROAD/bin:$PATH
+  export PATH=${DIR}/tools/install/yosys/bin:$PATH
 
-export PATH=${DIR}/dependencies/bin:$PATH
-export PATH=${DIR}/tools/install/OpenROAD/bin:$PATH
-export PATH=${DIR}/tools/install/yosys/bin:$PATH
+  if [[ "$OSTYPE" == "darwin"* ]]; then
+    export PATH="/Applications/KLayout/klayout.app/Contents/MacOS:$PATH"
+    export PATH="$(brew --prefix bison)/bin:$(brew --prefix flex)/bin:$(brew --prefix tcl-tk)/bin:$PATH"
+  fi
 
-if [[ "$OSTYPE" == "darwin"* ]]; then
-  export PATH="/Applications/KLayout/klayout.app/Contents/MacOS:$PATH"
-  export PATH="$(brew --prefix bison)/bin:$(brew --prefix flex)/bin:$(brew --prefix tcl-tk)/bin:$PATH"
-  export CMAKE_PREFIX_PATH="$(brew --prefix or-tools)"
-fi
-
-export FLOW_HOME=$DIR/flow
+  export FLOW_HOME=$DIR/flow
+}
+__setpaths
+unset -f __setpaths