make: silently suppress warnings in read_liberty.tcl, review feedback

Signed-off-by: Øyvind Harboe <[email protected]>

Author: oharboe

flow/scripts/load.tcl

@@ -3,7 +3,8 @@ source $::env(SCRIPTS_DIR)/util.tcl
 source $::env(SCRIPTS_DIR)/report_metrics.tcl
 
 proc load_design { design_file sdc_file } {
-  # Read liberty files
+  source_env_var_if_exists PLATFORM_TCL
+
   source $::env(SCRIPTS_DIR)/read_liberty.tcl
 
   # Read design files

flow/scripts/open.tcl

@@ -1,10 +1,10 @@
 source $::env(SCRIPTS_DIR)/util.tcl
-# Read liberty files
+
+source_env_var_if_exists PLATFORM_TCL
+
 source $::env(SCRIPTS_DIR)/read_liberty.tcl
 
-# Read def
 if { [env_var_exists_and_non_empty DEF_FILE] } {
-  # Read lef
   log_cmd read_lef $::env(TECH_LEF)
   log_cmd read_lef $::env(SC_LEF)
   if { [env_var_exists_and_non_empty ADDITIONAL_LEFS] } {

flow/scripts/read_liberty.tcl

@@ -1,9 +1,3 @@
-# Source platform-related Tcl command (initially for suppressing Liberty
-# warnings
-if { [env_var_exists_and_non_empty PLATFORM_TCL] } {
-  source $::env(PLATFORM_TCL)
-}
-
 #Read Liberty
 if { [env_var_exists_and_non_empty CORNERS] } {
   # corners

flow/scripts/util.tcl

@@ -205,3 +205,9 @@ proc place_density_with_lb_addon { } {
   }
   return $place_density
 }
+
+proc source_env_var_if_exists { env_var } {
+  if { [env_var_exists_and_non_empty $env_var] } {
+    source $::env($env_var)
+  }
+}