Skip to content

Commit 2694cfd

Browse files
committed
tests: simpler to maintain test_genElapsedTime.py
Signed-off-by: Øyvind Harboe <[email protected]>
1 parent 7a6057f commit 2694cfd

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

flow/test/test_genElapsedTime.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import unittest
44
from unittest.mock import patch
5-
from unittest.mock import MagicMock
65
from io import StringIO
76
import sys
87
import os
@@ -15,6 +14,7 @@
1514

1615
import genElapsedTime
1716

17+
1818
class TestElapsedTime(unittest.TestCase):
1919
def setUp(self):
2020
self.tmp_dir = tempfile.TemporaryDirectory()
@@ -31,8 +31,9 @@ def test_elapsed_time(self, mock_stdout):
3131
genElapsedTime.scan_logs(["--logDir", str(self.tmp_dir.name),
3232
"--noHeader"])
3333
# check if output is correct
34-
expected_output = self.tmp_dir.name + "\n1_test 5400 9440\nTotal 5400 9440\n"
35-
self.assertEqual(mock_stdout.getvalue(), expected_output)
34+
expected_output = (self.tmp_dir.name + "\n1_test 5400 9440\nTotal 5400 9440\n").split()
35+
actual_output = mock_stdout.getvalue().split()
36+
self.assertEqual(actual_output, expected_output)
3637

3738
@patch("sys.stdout", new_callable=StringIO)
3839
def test_zero_time(self, mock_stdout):
@@ -43,8 +44,9 @@ def test_zero_time(self, mock_stdout):
4344
# call the script with the test log file
4445
genElapsedTime.scan_logs(["--logDir", str(self.tmp_dir.name),
4546
"--noHeader"])
46-
expected_output = self.tmp_dir.name + "\n1_test 74 9440\nTotal 74 9440\n"
47-
self.assertEqual(mock_stdout.getvalue(), expected_output)
47+
expected_output = (self.tmp_dir.name + "\n1_test 74 9440\nTotal 74 9440\n").split()
48+
actual_output = mock_stdout.getvalue().split()
49+
self.assertEqual(actual_output, expected_output)
4850

4951
@patch("sys.stdout", new_callable=StringIO)
5052
def test_elapsed_time_longer_duration(self, mock_stdout):
@@ -56,9 +58,9 @@ def test_elapsed_time_longer_duration(self, mock_stdout):
5658
genElapsedTime.scan_logs(["--logDir", str(self.tmp_dir.name),
5759
"--noHeader"])
5860
# check if output is correct
59-
expected_output = (self.tmp_dir.name +
60-
"\n1_test 744 9440\nTotal 744 9440\n")
61-
self.assertEqual(mock_stdout.getvalue(), expected_output)
61+
expected_output = (self.tmp_dir.name + "\n1_test 744 9440 Total 744 9440").split()
62+
actual_output = mock_stdout.getvalue().split()
63+
self.assertEqual(actual_output, expected_output)
6264

6365
def test_missing_arg(self):
6466
with self.assertRaises(SystemExit):

0 commit comments

Comments
 (0)