Skip to content

Commit 55bfa95

Browse files
committed
uniquify experiment dir
Signed-off-by: Jack Luar <[email protected]>
1 parent 7259e8a commit 55bfa95

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

tools/AutoTuner/src/autotuner/distributed.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -510,9 +510,13 @@ def parse_arguments():
510510
else:
511511
args.experiment += f"-{args.mode}"
512512

513-
# Append a date for non-resume mode to ensure unique experiment dirs.
514-
if not args.resume:
515-
args.experiment += f"-{DATE}"
513+
# Experiment name must be unique. TODO: Have a single source of truth for EXPERIMENT_DIR.
514+
if os.path.exists(f"{LOCAL_DIR}/{args.platform}/{args.design}/{args.experiment}"):
515+
print(
516+
f"[ERROR TUN-0032] Experiment {args.experiment} already exists."
517+
" Please choose a different name."
518+
)
519+
sys.exit(1)
516520

517521
# Convert time to seconds
518522
if args.timeout_per_trial is not None:
@@ -710,6 +714,7 @@ def main():
710714
trial_name_creator=lambda x: f"variant-{x.trainable_name}-{x.trial_id}-ray",
711715
trial_dirname_creator=lambda x: f"variant-{x.trainable_name}-{x.trial_id}-ray",
712716
)
717+
exit()
713718
if args.algorithm == "pbt":
714719
os.environ["TUNE_MAX_PENDING_TRIALS_PG"] = str(args.jobs)
715720
tune_args["scheduler"] = search_algo

tools/AutoTuner/test/smoke_test_algo_eval.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ def setUp(self):
2323
f"python3 -m autotuner.distributed"
2424
f" --design {self.design}"
2525
f" --platform {self.platform}"
26-
f" --experiment {self.experiment}"
26+
f" --experiment {self.experiment}-{idx}"
2727
f" --config {self.config}"
2828
f" --yes"
2929
f" tune --samples 5"
3030
f" --algorithm {a} --eval {e}"
3131
f" --reference {self.reference}"
32-
for a, e in self.matrix
32+
for idx, (a, e) in enumerate(self.matrix)
3333
]
3434

3535
def make_base(self):

tools/AutoTuner/test/smoke_test_cpubudget.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def setUp(self):
1616
cur_dir,
1717
f"../../../flow/designs/{self.platform}/{self.design}/autotuner.json",
1818
)
19-
self.experiment = f"smoke-test-timeout-{self.platform}"
19+
self.experiment = f"smoke-test-cpubudget-{self.platform}"
2020

2121
cpu_budget = 1
2222
self.expected_timeout = cpu_budget / os.cpu_count()

tools/AutoTuner/test/smoke_test_sample_iteration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ def setUp(self):
2020
f"python3 -m autotuner.distributed"
2121
f" --design {self.design}"
2222
f" --platform {self.platform}"
23-
f" --experiment {self.experiment}"
23+
f" --experiment {self.experiment}-{idx}"
2424
f" --config {self.config}"
2525
f" --yes"
2626
f" tune --samples {s} --iterations {i}"
27-
for s, i in self.matrix
27+
for idx, (s, i) in enumerate(self.matrix)
2828
]
2929

3030
def test_sample_iteration(self):

tools/AutoTuner/test/smoke_test_timeout.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ def setUp(self):
2525
"python3 distributed.py"
2626
f" --design {self.design}"
2727
f" --platform {self.platform}"
28-
f" --experiment {self.experiment}"
28+
f" --experiment {self.experiment}-{idx}"
2929
f" --config {self.config}"
3030
f" --yes"
3131
f" {flag}"
3232
f" tune --samples 1"
33-
for flag in timeout_flags
33+
for idx, flag in enumerate(timeout_flags)
3434
]
3535

3636
def test_timeout(self):

0 commit comments

Comments
 (0)