Only do setup repair in floorplan.tcl

maliberty · maliberty · commit 5dda947cdea1 · 2025-06-27T05:04:47.000Z
Too early for hold and it creates new buffers with meaningless locations.

Signed-off-by: Matt Liberty &lt;mliberty@precisioninno.com&gt;
diff --git a/flow/scripts/floorplan.tcl b/flow/scripts/floorplan.tcl
@@ -110,7 +110,7 @@ if { [env_var_equals REMOVE_ABC_BUFFERS 1] } {
   # Skip clone & split
   set ::env(SETUP_MOVE_SEQUENCE) "unbuffer,sizeup,swap,buffer"
   set ::env(SKIP_LAST_GASP) 1
-  repair_timing_helper 0
+  repair_timing_helper -setup
 }
 
 puts "Default units for flow"
diff --git a/flow/scripts/util.tcl b/flow/scripts/util.tcl
@@ -22,10 +22,10 @@ proc fast_route {} {
   }
 }
 
-proc repair_timing_helper { {hold_margin 1} } {
-  set additional_args "-verbose"
+proc repair_timing_helper { args } {
+  set additional_args "$args -verbose"
   append_env_var additional_args SETUP_SLACK_MARGIN -setup_margin 1
-  if {$hold_margin || $::env(HOLD_SLACK_MARGIN) < 0} {
+  if {$::env(HOLD_SLACK_MARGIN) < 0} {
     append_env_var additional_args HOLD_SLACK_MARGIN -hold_margin 1
   }
   append_env_var additional_args SETUP_MOVE_SEQUENCE -sequence 1
diff --git a/tools/OpenROAD b/tools/OpenROAD
@@ -1 +1 @@
-Subproject commit e743761ef889c67a4cc3475b23be78358c9f5ace
+Subproject commit c79c8317e05ecbf45eba5096a74cb421ab97b7ae

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ if { [env_var_equals REMOVE_ABC_BUFFERS 1] } {`
`110`	`110`	`# Skip clone & split`
`111`	`111`	`set ::env(SETUP_MOVE_SEQUENCE) "unbuffer,sizeup,swap,buffer"`
`112`	`112`	`set ::env(SKIP_LAST_GASP) 1`
`113`		`- repair_timing_helper 0`
	`113`	`+ repair_timing_helper -setup`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`puts "Default units for flow"`
Original file line number	Diff line number	Diff line change
`@@ -22,10 +22,10 @@ proc fast_route {} {`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`
`25`		`-proc repair_timing_helper { {hold_margin 1} } {`
`26`		`- set additional_args "-verbose"`
	`25`	`+proc repair_timing_helper { args } {`
	`26`	`+ set additional_args "$args -verbose"`
`27`	`27`	`append_env_var additional_args SETUP_SLACK_MARGIN -setup_margin 1`
`28`		`- if {$hold_margin \|\| $::env(HOLD_SLACK_MARGIN) < 0} {`
	`28`	`+ if {$::env(HOLD_SLACK_MARGIN) < 0} {`
`29`	`29`	`append_env_var additional_args HOLD_SLACK_MARGIN -hold_margin 1`
`30`	`30`	`}`
`31`	`31`	`append_env_var additional_args SETUP_MOVE_SEQUENCE -sequence 1`